tools/libxl - Async Task Cancellation Query

From: Koushik Chakravarty <koushik.chakravarty@citrix.com>
To: Ian Jackson <Ian.Jackson@citrix.com>,
	Euan Harris <euan.harris@citrix.com>
Cc: "'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>
Subject: tools/libxl - Async Task Cancellation Query
Date: Wed, 8 Apr 2015 08:37:54 +0000	[thread overview]
Message-ID: <E638B0CB6CFBD44183ABE72A42E666268B0D48@SINPEX01CL03.citrite.net> (raw)

[-- Attachment #1.1: Type: text/plain, Size: 1061 bytes --]

Hi Ian,

I am currently looking into the asynchronous task cancellation in libxl and have a few very specific queries, if you could answer.

1.    In libxl_domain_resume(),why is libxl_ao_complete called before AO_INPROGRESS?

2.    In libxl_ao_cancel() - the function goes through the ctx->aos_inprogress and tries to find a suitable libxl_ao that matches the input libxl_asyncop_how. It does so, by a few 'if' checks. Regarding this -

a.    Where does the libxl__ao get inserted to the ctx->aos_inprogress? I could not find that somehow - sorry if I overlooked.

b.    Can I suggest adding a unique private 'id' field to the libxl_asyncop_how structure, that will be populated by AO_CREATE? This will help finding the matching corresponding libxl_ao from the ctx->aos_inprogress in libxl_ao_cancel() quicker by looking for search->id == libxl_asyncop_how->id.

3.    In libxl_device_vkb_add(), shouldn't the function invoke libxl__ao_abort in the error path?

Thanks in advance!

Regards,
Koushik Chakravarty
Mobile - +91-9663396424

[-- Attachment #1.2: Type: text/html, Size: 8045 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel