* [v1,1/4] EDAC, skx_edac: Fix function calling order in skx_exit()
@ 2018-11-16 13:28 Qiuxu Zhuo
0 siblings, 0 replies; 3+ messages in thread
From: Qiuxu Zhuo @ 2018-11-16 13:28 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Luck, Tony, mchehab, arozansk, linux-edac
Hi Boris,
> All 4 applied, thanks.
>
> Hint for the future: please teach your git to send the patches threaded, i.e., the
> mail header should have:
>
> In-Reply-To: <first mail's Message-ID>
> References: <first mail's Message-ID>
OK.
Thanks for the hint :-)
- Qiuxu
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v1,1/4] EDAC, skx_edac: Fix function calling order in skx_exit()
@ 2018-11-16 10:23 Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2018-11-16 10:23 UTC (permalink / raw)
To: Qiuxu Zhuo; +Cc: tony.luck, mchehab, arozansk, linux-edac
On Fri, Nov 16, 2018 at 03:33:36PM +0800, Qiuxu Zhuo wrote:
> The order of function calling in skx_exit() is not the reversed
> order in skx_init(). Fix it by calling functions in skx_exit()
> in a proper order.
>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> ---
> drivers/edac/skx_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
All 4 applied, thanks.
Hint for the future: please teach your git to send the patches threaded,
i.e., the mail header should have:
In-Reply-To: <first mail's Message-ID>
References: <first mail's Message-ID>
Thx.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v1,1/4] EDAC, skx_edac: Fix function calling order in skx_exit()
@ 2018-11-16 7:33 Qiuxu Zhuo
0 siblings, 0 replies; 3+ messages in thread
From: Qiuxu Zhuo @ 2018-11-16 7:33 UTC (permalink / raw)
To: bp; +Cc: tony.luck, mchehab, arozansk, linux-edac, Qiuxu Zhuo
The order of function calling in skx_exit() is not the reversed
order in skx_init(). Fix it by calling functions in skx_exit()
in a proper order.
Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
---
drivers/edac/skx_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/skx_edac.c b/drivers/edac/skx_edac.c
index a99ea61dad32..b23c8aaa5f2b 100644
--- a/drivers/edac/skx_edac.c
+++ b/drivers/edac/skx_edac.c
@@ -1339,11 +1339,11 @@ static void __exit skx_exit(void)
{
edac_dbg(2, "\n");
mce_unregister_decode_chain(&skx_mce_dec);
- skx_remove();
+ teardown_skx_debug();
if (nvdimm_count)
skx_adxl_put();
kfree(skx_msg);
- teardown_skx_debug();
+ skx_remove();
}
module_init(skx_init);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-16 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-16 13:28 [v1,1/4] EDAC, skx_edac: Fix function calling order in skx_exit() Qiuxu Zhuo
-- strict thread matches above, loose matches on Subject: below --
2018-11-16 10:23 Borislav Petkov
2018-11-16 7:33 Qiuxu Zhuo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.