[Buildroot] [PATCH] icu: Doesn't work on ARC yet

[Buildroot] [PATCH] icu: Doesn't work on ARC yet

[Mischa Jonker]

icu depends on __sync_sub_and_fetch and other atomic primitives that
don't exist in the ARC toolchain yet.

Signed-off-by: Mischa Jonker <mjonker@synopsys.com>
---
 package/icu/Config.in |    1 +
 1 file changed, 1 insertion(+)

diff --git a/package/icu/Config.in b/package/icu/Config.in
index 585bffb..3c041bb 100644
--- a/package/icu/Config.in
+++ b/package/icu/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_ICU
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_arc # atomic builtins
 	help
 	  International Components for Unicode.
 
-- 
1.7.9.5

[Buildroot] [PATCH] icu: Doesn't work on ARC yet

[Peter Korsgaard]

>>>>> "Mischa" == Mischa Jonker <Mischa.Jonker@synopsys.com> writes:

> icu depends on __sync_sub_and_fetch and other atomic primitives that
> don't exist in the ARC toolchain yet.

Thanks, but you also need to:

- Add the !arc dependency to the comment line belo
- Propagate the dependency to icu's reverse dependencies:
git grep -l 'select BR2_PACKAGE_ICU'
package/beecrypt/Config.in
package/cppcms/Config.in
package/php/Config.ext
package/qt5/qt5base/Config.in
package/webkit/Config.in

Care to fix that and resend?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] icu: Doesn't work on ARC yet

[Mischa Jonker]

> > icu depends on __sync_sub_and_fetch and other atomic primitives that
> > don't exist in the ARC toolchain yet.
> 
> Thanks, but you also need to:
> 
> - Add the !arc dependency to the comment line belo
> - Propagate the dependency to icu's reverse dependencies:
> git grep -l 'select BR2_PACKAGE_ICU'
> package/beecrypt/Config.in
> package/cppcms/Config.in
> package/php/Config.ext
> package/qt5/qt5base/Config.in
> package/webkit/Config.in
> 
> Care to fix that and resend?
> 

Thanks for the feedback. A new patch is coming up. I haven't changed package/webkit/Config.in as it cannot be selected for ARC already.

Mischa