* [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
@ 2021-04-17 7:29 ` DENG Qingfang
0 siblings, 0 replies; 9+ messages in thread
From: DENG Qingfang @ 2021-04-17 7:29 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
David S. Miller, Jakub Kicinski, Matthias Brugger,
Pablo Neira Ayuso, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel
Cc: Frank Wunderlich, Alex Ryabchenko
Issue was traffic problems after a while with increased ping times if
flow offload is active. It turns out that key_offset with cookie is
needed in rhashtable_params but was re-assigned to head_offset.
Fix the assignment.
Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
v1 -> v2:
Refined commit message according to Frank.
drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
index 4975106fbc42..f47f319f3ae0 100644
--- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
@@ -43,7 +43,7 @@ struct mtk_flow_entry {
static const struct rhashtable_params mtk_flow_ht_params = {
.head_offset = offsetof(struct mtk_flow_entry, node),
- .head_offset = offsetof(struct mtk_flow_entry, cookie),
+ .key_offset = offsetof(struct mtk_flow_entry, cookie),
.key_len = sizeof(unsigned long),
.automatic_shrinking = true,
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
@ 2021-04-17 7:29 ` DENG Qingfang
0 siblings, 0 replies; 9+ messages in thread
From: DENG Qingfang @ 2021-04-17 7:29 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
David S. Miller, Jakub Kicinski, Matthias Brugger,
Pablo Neira Ayuso, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel
Cc: Frank Wunderlich, Alex Ryabchenko
Issue was traffic problems after a while with increased ping times if
flow offload is active. It turns out that key_offset with cookie is
needed in rhashtable_params but was re-assigned to head_offset.
Fix the assignment.
Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
v1 -> v2:
Refined commit message according to Frank.
drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
index 4975106fbc42..f47f319f3ae0 100644
--- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
@@ -43,7 +43,7 @@ struct mtk_flow_entry {
static const struct rhashtable_params mtk_flow_ht_params = {
.head_offset = offsetof(struct mtk_flow_entry, node),
- .head_offset = offsetof(struct mtk_flow_entry, cookie),
+ .key_offset = offsetof(struct mtk_flow_entry, cookie),
.key_len = sizeof(unsigned long),
.automatic_shrinking = true,
};
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
2021-04-17 7:29 ` DENG Qingfang
(?)
@ 2021-04-17 7:34 ` Frank Wunderlich
-1 siblings, 0 replies; 9+ messages in thread
From: Frank Wunderlich @ 2021-04-17 7:34 UTC (permalink / raw)
To: linux-mediatek, DENG Qingfang, Felix Fietkau, John Crispin,
Sean Wang, Mark Lee, David S. Miller, Jakub Kicinski,
Matthias Brugger, Pablo Neira Ayuso, netdev, linux-arm-kernel,
linux-kernel
Cc: Alex Ryabchenko
Tested on Bananapi-r2 (please see my mt7623 patch for supporting offloading) with ~300 iperf3 iterations and uptime >6h
Tested-by: Frank Wunderlich <frank-w@public-files.de>
regards Frank
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
@ 2021-04-17 7:34 ` Frank Wunderlich
0 siblings, 0 replies; 9+ messages in thread
From: Frank Wunderlich @ 2021-04-17 7:34 UTC (permalink / raw)
To: linux-mediatek, DENG Qingfang, Felix Fietkau, John Crispin,
Sean Wang, Mark Lee, David S. Miller, Jakub Kicinski,
Matthias Brugger, Pablo Neira Ayuso, netdev, linux-arm-kernel,
linux-kernel
Cc: Alex Ryabchenko
Tested on Bananapi-r2 (please see my mt7623 patch for supporting offloading) with ~300 iperf3 iterations and uptime >6h
Tested-by: Frank Wunderlich <frank-w@public-files.de>
regards Frank
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
@ 2021-04-17 7:34 ` Frank Wunderlich
0 siblings, 0 replies; 9+ messages in thread
From: Frank Wunderlich @ 2021-04-17 7:34 UTC (permalink / raw)
To: linux-mediatek, DENG Qingfang, Felix Fietkau, John Crispin,
Sean Wang, Mark Lee, David S. Miller, Jakub Kicinski,
Matthias Brugger, Pablo Neira Ayuso, netdev, linux-arm-kernel,
linux-kernel
Cc: Alex Ryabchenko
Tested on Bananapi-r2 (please see my mt7623 patch for supporting offloading) with ~300 iperf3 iterations and uptime >6h
Tested-by: Frank Wunderlich <frank-w@public-files.de>
regards Frank
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
2021-04-17 7:29 ` DENG Qingfang
(?)
@ 2021-04-19 22:50 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-19 22:50 UTC (permalink / raw)
To: DENG Qingfang
Cc: nbd, john, sean.wang, Mark-MC.Lee, davem, kuba, matthias.bgg,
pablo, netdev, linux-arm-kernel, linux-mediatek, linux-kernel,
frank-w, d3adme4t
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 17 Apr 2021 15:29:04 +0800 you wrote:
> Issue was traffic problems after a while with increased ping times if
> flow offload is active. It turns out that key_offset with cookie is
> needed in rhashtable_params but was re-assigned to head_offset.
> Fix the assignment.
>
> Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
>
> [...]
Here is the summary with links:
- [v2,net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
https://git.kernel.org/netdev/net-next/c/6ecaf81d4ac6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
@ 2021-04-19 22:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-19 22:50 UTC (permalink / raw)
To: DENG Qingfang
Cc: nbd, john, sean.wang, Mark-MC.Lee, davem, kuba, matthias.bgg,
pablo, netdev, linux-arm-kernel, linux-mediatek, linux-kernel,
frank-w, d3adme4t
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 17 Apr 2021 15:29:04 +0800 you wrote:
> Issue was traffic problems after a while with increased ping times if
> flow offload is active. It turns out that key_offset with cookie is
> needed in rhashtable_params but was re-assigned to head_offset.
> Fix the assignment.
>
> Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
>
> [...]
Here is the summary with links:
- [v2,net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
https://git.kernel.org/netdev/net-next/c/6ecaf81d4ac6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
@ 2021-04-19 22:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-19 22:50 UTC (permalink / raw)
To: DENG Qingfang
Cc: nbd, john, sean.wang, Mark-MC.Lee, davem, kuba, matthias.bgg,
pablo, netdev, linux-arm-kernel, linux-mediatek, linux-kernel,
frank-w, d3adme4t
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 17 Apr 2021 15:29:04 +0800 you wrote:
> Issue was traffic problems after a while with increased ping times if
> flow offload is active. It turns out that key_offset with cookie is
> needed in rhashtable_params but was re-assigned to head_offset.
> Fix the assignment.
>
> Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
>
> [...]
Here is the summary with links:
- [v2,net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
https://git.kernel.org/netdev/net-next/c/6ecaf81d4ac6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread