Re: [PATCH v3 34/40] drm/i915: hdcp_check_link only on CP_IRQ

["Shankar, Uma" <uma.shankar@intel.com>]

>-----Original Message-----
>From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
>Ramalingam C
>Sent: Tuesday, April 3, 2018 7:28 PM
>To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
>seanpaul@chromium.org; daniel@ffwll.ch; chris@chris-wilson.co.uk;
>jani.nikula@linux.intel.com; Winkler, Tomas <tomas.winkler@intel.com>;
>Usyskin, Alexander <alexander.usyskin@intel.com>
>Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
>Subject: [Intel-gfx] [PATCH v3 34/40] drm/i915: hdcp_check_link only on CP_IRQ
>
>HDCP check link is invoked only on CP_IRQ detection, instead of all short pulses.
>

Looks ok.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

>v3:
>  No Changes.
>
>Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
>---
> drivers/gpu/drm/i915/intel_dp.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index 955a20208097..4a9f5a690528 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -4467,8 +4467,10 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
>
> 		if (sink_irq_vector & DP_AUTOMATED_TEST_REQUEST)
> 			intel_dp_handle_test_request(intel_dp);
>-		if (sink_irq_vector & (DP_CP_IRQ | DP_SINK_SPECIFIC_IRQ))
>-			DRM_DEBUG_DRIVER("CP or sink specific irq
>unhandled\n");
>+		if (sink_irq_vector & DP_CP_IRQ)
>+			intel_hdcp_check_link(intel_dp->attached_connector);
>+		if (sink_irq_vector & DP_SINK_SPECIFIC_IRQ)
>+			DRM_DEBUG_DRIVER("Sink specific irq unhandled\n");
> 	}
>
> 	/* defer to the hotplug work for link retraining if needed */ @@ -5438,9
>+5440,6 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool
>long_hpd)
>
> 		handled = intel_dp_short_pulse(intel_dp);
>
>-		/* Short pulse can signify loss of hdcp authentication */
>-		intel_hdcp_check_link(intel_dp->attached_connector);
>-
> 		if (!handled) {
> 			intel_dp->detect_done = false;
> 			goto put_power;
>--
>2.7.4
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx