* [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check @ 2020-03-26 7:49 Uma Shankar 2020-03-26 8:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork ` (3 more replies) 0 siblings, 4 replies; 7+ messages in thread From: Uma Shankar @ 2020-03-26 7:49 UTC (permalink / raw) To: intel-gfx; +Cc: SweeAun Khor, Souza This patch fixes the private_flags of mode to be checked and compared against uapi.mode and not from hw.mode. This helps properly trigger modeset at boot if desired by driver. It helps resolve audio_codec initialization issues if display is connected at boot. Initial discussion on this issue has happened on below thread: https://patchwork.freedesktop.org/series/74828/ Fixes: https://gitlab.freedesktop.org/drm/intel/issues/1363 Cc: Ville Syrjä <ville.syrjala@linux.intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com> Cc: Souza, Jose <jose.souza@intel.com> Suggested-by: Ville Syrjä <ville.syrjala@linux.intel.com> Signed-off-by: Uma Shankar <uma.shankar@intel.com> Signed-off-by: SweeAun Khor <swee.aun.khor@intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index fe55c7c713f1..e630429af2c0 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -14747,8 +14747,8 @@ static int intel_atomic_check(struct drm_device *dev, /* Catch I915_MODE_FLAG_INHERITED */ for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) { - if (new_crtc_state->hw.mode.private_flags != - old_crtc_state->hw.mode.private_flags) + if (new_crtc_state->uapi.mode.private_flags != + old_crtc_state->uapi.mode.private_flags) new_crtc_state->uapi.mode_changed = true; } -- 2.22.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix mode private_flags comparison at atomic_check 2020-03-26 7:49 [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check Uma Shankar @ 2020-03-26 8:22 ` Patchwork 2020-03-26 9:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-03-26 8:22 UTC (permalink / raw) To: Shankar, Uma; +Cc: intel-gfx == Series Details == Series: drm/i915/display: Fix mode private_flags comparison at atomic_check URL : https://patchwork.freedesktop.org/series/75106/ State : success == Summary == CI Bug Log - changes from CI_DRM_8190 -> Patchwork_17093 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/index.html Known issues ------------ Here are the changes found in Patchwork_17093 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@execlists: - fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927] / [i915#1430] / [i915#656]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/fi-bxt-dsi/igt@i915_selftest@live@execlists.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/fi-bxt-dsi/igt@i915_selftest@live@execlists.html #### Possible fixes #### * igt@i915_selftest@live@execlists: - {fi-tgl-u}: [DMESG-FAIL][3] ([i915#656]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/fi-tgl-u/igt@i915_selftest@live@execlists.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/fi-tgl-u/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@hangcheck: - fi-icl-u2: [INCOMPLETE][5] ([fdo#108569]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/fi-icl-u2/igt@i915_selftest@live@hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/fi-icl-u2/igt@i915_selftest@live@hangcheck.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [i915#1430]: https://gitlab.freedesktop.org/drm/intel/issues/1430 [i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656 Participating hosts (40 -> 37) ------------------------------ Additional (8): fi-glk-dsi fi-ilk-650 fi-ivb-3770 fi-elk-e7500 fi-bsw-kefka fi-blb-e6850 fi-bsw-nick fi-snb-2600 Missing (11): fi-bdw-5557u fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-hsw-4770 fi-cfl-8109u fi-kbl-7560u fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8190 -> Patchwork_17093 CI-20190529: 20190529 CI_DRM_8190: 73f711b364bc85c8a7189487c09431eb1f515ed0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5538: 47becbc9cd1fc7b1b78692f90fd3dcd5a9066965 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17093: c8956fda0a604ceb7e6400886acc9019ab4142e0 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == c8956fda0a60 drm/i915/display: Fix mode private_flags comparison at atomic_check == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix mode private_flags comparison at atomic_check 2020-03-26 7:49 [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check Uma Shankar 2020-03-26 8:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2020-03-26 9:49 ` Patchwork 2020-03-26 10:47 ` [Intel-gfx] [PATCH] " Maarten Lankhorst 2020-03-26 16:17 ` Ville Syrjälä 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-03-26 9:49 UTC (permalink / raw) To: Shankar, Uma; +Cc: intel-gfx == Series Details == Series: drm/i915/display: Fix mode private_flags comparison at atomic_check URL : https://patchwork.freedesktop.org/series/75106/ State : success == Summary == CI Bug Log - changes from CI_DRM_8190_full -> Patchwork_17093_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_17093_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@rcs0-s3: - shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl1/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110854]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@gem_exec_balancer@smoke.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb5/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@implicit-read-write-bsd1: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [i915#677]) +3 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd1.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb8/igt@gem_exec_schedule@implicit-read-write-bsd1.html * igt@gem_exec_schedule@implicit-write-read-blt: - shard-snb: [PASS][7] -> [INCOMPLETE][8] ([i915#82]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-snb6/igt@gem_exec_schedule@implicit-write-read-blt.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-snb2/igt@gem_exec_schedule@implicit-write-read-blt.html * igt@gem_exec_schedule@pi-shared-iova-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([i915#677]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb3/igt@gem_exec_schedule@pi-shared-iova-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb4/igt@gem_exec_schedule@pi-shared-iova-bsd.html * igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112146]) +4 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb1/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html * igt@gem_exec_suspend@basic-s3: - shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180] / [i915#93] / [i915#95]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl4/igt@gem_exec_suspend@basic-s3.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-kbl2/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live@execlists: - shard-apl: [PASS][15] -> [INCOMPLETE][16] ([fdo#103927] / [i915#1430] / [i915#656]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@i915_selftest@live@execlists.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl7/igt@i915_selftest@live@execlists.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#72]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy: - shard-skl: [PASS][19] -> [FAIL][20] ([IGT#5]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][21] -> [FAIL][22] ([i915#46]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@plain-flip-fb-recreate-interruptible: - shard-skl: [PASS][23] -> [FAIL][24] ([i915#34]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible.html * igt@kms_hdr@bpc-switch: - shard-skl: [PASS][25] -> [FAIL][26] ([i915#1188]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl4/igt@kms_hdr@bpc-switch.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl7/igt@kms_hdr@bpc-switch.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [i915#265]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_prime@basic-crc: - shard-apl: [PASS][31] -> [FAIL][32] ([i915#1031] / [i915#95]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl4/igt@kms_prime@basic-crc.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl1/igt@kms_prime@basic-crc.html - shard-kbl: [PASS][33] -> [FAIL][34] ([i915#1031] / [i915#93] / [i915#95]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl7/igt@kms_prime@basic-crc.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-kbl6/igt@kms_prime@basic-crc.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +5 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@perf_pmu@init-busy-vcs1: - shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#112080]) +8 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@perf_pmu@init-busy-vcs1.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb8/igt@perf_pmu@init-busy-vcs1.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109276]) +13 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb8/igt@prime_vgem@fence-wait-bsd2.html #### Possible fixes #### * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [SKIP][43] ([fdo#110841]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [SKIP][45] ([fdo#112080]) -> [PASS][46] +10 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb5/igt@gem_exec_parallel@vcs1-fds.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb4/igt@gem_exec_parallel@vcs1-fds.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [SKIP][47] ([i915#677]) -> [PASS][48] +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb8/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][49] ([fdo#112146]) -> [PASS][50] +3 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [SKIP][51] ([fdo#109276]) -> [PASS][52] +17 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_softpin@noreloc-s3: - shard-apl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +2 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@gem_softpin@noreloc-s3.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl7/igt@gem_softpin@noreloc-s3.html * igt@gen9_exec_parse@allowed-all: - shard-skl: [DMESG-WARN][55] ([i915#716]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl1/igt@gen9_exec_parse@allowed-all.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl4/igt@gen9_exec_parse@allowed-all.html - shard-apl: [DMESG-WARN][57] ([i915#716]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@gen9_exec_parse@allowed-all.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl3/igt@gen9_exec_parse@allowed-all.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][59] ([fdo#109349]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_draw_crc@draw-method-rgb565-render-untiled: - shard-glk: [FAIL][61] ([i915#52] / [i915#54]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-glk8/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-glk3/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html * igt@kms_flip@plain-flip-fb-recreate: - shard-skl: [FAIL][63] ([i915#34]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl10/igt@kms_flip@plain-flip-fb-recreate.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl4/igt@kms_flip@plain-flip-fb-recreate.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-kbl: [DMESG-WARN][65] ([i915#180]) -> [PASS][66] +2 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [FAIL][67] ([fdo#108145]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-glk: [FAIL][69] ([i915#899]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-y.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-glk2/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@no_drrs: - shard-iclb: [FAIL][71] ([i915#173]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@kms_psr@no_drrs.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb5/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_suspend: - shard-iclb: [SKIP][73] ([fdo#109441]) -> [PASS][74] +3 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@kms_psr@psr2_suspend.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb2/igt@kms_psr@psr2_suspend.html * igt@kms_setmode@basic: - shard-apl: [FAIL][75] ([i915#31]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl1/igt@kms_setmode@basic.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl6/igt@kms_setmode@basic.html - shard-skl: [FAIL][77] ([i915#31]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl1/igt@kms_setmode@basic.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-skl7/igt@kms_setmode@basic.html #### Warnings #### * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][79] ([i915#658]) -> [SKIP][80] ([i915#588]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@i915_pm_dc@dc3co-vpb-simulation.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-apl: [FAIL][81] ([fdo#108145]) -> [FAIL][82] ([fdo#108145] / [i915#95]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl4/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_psr2_su@page_flip: - shard-iclb: [FAIL][83] ([i915#608]) -> [SKIP][84] ([fdo#109642] / [fdo#111068]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@kms_psr2_su@page_flip.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-iclb5/igt@kms_psr2_su@page_flip.html * igt@runner@aborted: - shard-apl: ([FAIL][85], [FAIL][86]) ([fdo#103927] / [i915#716]) -> ([FAIL][87], [FAIL][88]) ([fdo#103927] / [i915#529]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@runner@aborted.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl8/igt@runner@aborted.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl7/igt@runner@aborted.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/shard-apl4/igt@runner@aborted.html [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#1031]: https://gitlab.freedesktop.org/drm/intel/issues/1031 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1430]: https://gitlab.freedesktop.org/drm/intel/issues/1430 [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#529]: https://gitlab.freedesktop.org/drm/intel/issues/529 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588 [i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608 [i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8190 -> Patchwork_17093 CI-20190529: 20190529 CI_DRM_8190: 73f711b364bc85c8a7189487c09431eb1f515ed0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5538: 47becbc9cd1fc7b1b78692f90fd3dcd5a9066965 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17093: c8956fda0a604ceb7e6400886acc9019ab4142e0 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17093/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check 2020-03-26 7:49 [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check Uma Shankar 2020-03-26 8:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-03-26 9:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-03-26 10:47 ` Maarten Lankhorst 2020-03-26 11:59 ` Shankar, Uma 2020-03-26 16:17 ` Ville Syrjälä 3 siblings, 1 reply; 7+ messages in thread From: Maarten Lankhorst @ 2020-03-26 10:47 UTC (permalink / raw) To: Uma Shankar, intel-gfx; +Cc: SweeAun Khor Op 26-03-2020 om 08:49 schreef Uma Shankar: > This patch fixes the private_flags of mode to be checked and > compared against uapi.mode and not from hw.mode. This helps > properly trigger modeset at boot if desired by driver. > > It helps resolve audio_codec initialization issues if display > is connected at boot. Initial discussion on this issue has happened > on below thread: > https://patchwork.freedesktop.org/series/74828/ > > Fixes: https://gitlab.freedesktop.org/drm/intel/issues/1363 Wrong use of fixes. :) Use dim fixes original-commit-id to reference the commit. And for this use the Closes: tag. Other than that looks good. :) So with headers fixed: Reviewed-By: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Ville Syrjä <ville.syrjala@linux.intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com> > Cc: Souza, Jose <jose.souza@intel.com> > Suggested-by: Ville Syrjä <ville.syrjala@linux.intel.com> > Signed-off-by: Uma Shankar <uma.shankar@intel.com> > Signed-off-by: SweeAun Khor <swee.aun.khor@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index fe55c7c713f1..e630429af2c0 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -14747,8 +14747,8 @@ static int intel_atomic_check(struct drm_device *dev, > /* Catch I915_MODE_FLAG_INHERITED */ > for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, > new_crtc_state, i) { > - if (new_crtc_state->hw.mode.private_flags != > - old_crtc_state->hw.mode.private_flags) > + if (new_crtc_state->uapi.mode.private_flags != > + old_crtc_state->uapi.mode.private_flags) > new_crtc_state->uapi.mode_changed = true; > } > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check 2020-03-26 10:47 ` [Intel-gfx] [PATCH] " Maarten Lankhorst @ 2020-03-26 11:59 ` Shankar, Uma 0 siblings, 0 replies; 7+ messages in thread From: Shankar, Uma @ 2020-03-26 11:59 UTC (permalink / raw) To: Maarten Lankhorst, intel-gfx; +Cc: Khor, Swee Aun > -----Original Message----- > From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Sent: Thursday, March 26, 2020 4:18 PM > To: Shankar, Uma <uma.shankar@intel.com>; intel-gfx@lists.freedesktop.org > Cc: Ville Syrjä <ville.syrjala@linux.intel.com>; Kai Vehmanen > <kai.vehmanen@linux.intel.com>; Souza, Jose <jose.souza@intel.com>; Khor, Swee > Aun <swee.aun.khor@intel.com> > Subject: Re: [PATCH] drm/i915/display: Fix mode private_flags comparison at > atomic_check > > Op 26-03-2020 om 08:49 schreef Uma Shankar: > > This patch fixes the private_flags of mode to be checked and compared > > against uapi.mode and not from hw.mode. This helps properly trigger > > modeset at boot if desired by driver. > > > > It helps resolve audio_codec initialization issues if display is > > connected at boot. Initial discussion on this issue has happened on > > below thread: > > https://patchwork.freedesktop.org/series/74828/ > > > > Fixes: https://gitlab.freedesktop.org/drm/intel/issues/1363 > > Wrong use of fixes. :) > > Use dim fixes original-commit-id to reference the commit. And for this use the > Closes: tag. > > Other than that looks good. :) > > So with headers fixed: Thanks for the feedback Maarten. Floated v2 with this updated. Regards, Uma Shankar > Reviewed-By: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > Cc: Ville Syrjä <ville.syrjala@linux.intel.com> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com> > > Cc: Souza, Jose <jose.souza@intel.com> > > Suggested-by: Ville Syrjä <ville.syrjala@linux.intel.com> > > Signed-off-by: Uma Shankar <uma.shankar@intel.com> > > Signed-off-by: SweeAun Khor <swee.aun.khor@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > > b/drivers/gpu/drm/i915/display/intel_display.c > > index fe55c7c713f1..e630429af2c0 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -14747,8 +14747,8 @@ static int intel_atomic_check(struct drm_device *dev, > > /* Catch I915_MODE_FLAG_INHERITED */ > > for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, > > new_crtc_state, i) { > > - if (new_crtc_state->hw.mode.private_flags != > > - old_crtc_state->hw.mode.private_flags) > > + if (new_crtc_state->uapi.mode.private_flags != > > + old_crtc_state->uapi.mode.private_flags) > > new_crtc_state->uapi.mode_changed = true; > > } > > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check 2020-03-26 7:49 [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check Uma Shankar ` (2 preceding siblings ...) 2020-03-26 10:47 ` [Intel-gfx] [PATCH] " Maarten Lankhorst @ 2020-03-26 16:17 ` Ville Syrjälä 2020-03-26 17:45 ` Shankar, Uma 3 siblings, 1 reply; 7+ messages in thread From: Ville Syrjälä @ 2020-03-26 16:17 UTC (permalink / raw) To: Uma Shankar; +Cc: SweeAun Khor, intel-gfx, Souza On Thu, Mar 26, 2020 at 01:19:28PM +0530, Uma Shankar wrote: > This patch fixes the private_flags of mode to be checked and > compared against uapi.mode and not from hw.mode. This helps > properly trigger modeset at boot if desired by driver. > > It helps resolve audio_codec initialization issues if display > is connected at boot. Initial discussion on this issue has happened > on below thread: > https://patchwork.freedesktop.org/series/74828/ > > Fixes: https://gitlab.freedesktop.org/drm/intel/issues/1363 > > Cc: Ville Syrjä <ville.syrjala@linux.intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com> > Cc: Souza, Jose <jose.souza@intel.com> > Suggested-by: Ville Syrjä <ville.syrjala@linux.intel.com> No one by that name here. > Signed-off-by: Uma Shankar <uma.shankar@intel.com> > Signed-off-by: SweeAun Khor <swee.aun.khor@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index fe55c7c713f1..e630429af2c0 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -14747,8 +14747,8 @@ static int intel_atomic_check(struct drm_device *dev, > /* Catch I915_MODE_FLAG_INHERITED */ > for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, > new_crtc_state, i) { > - if (new_crtc_state->hw.mode.private_flags != > - old_crtc_state->hw.mode.private_flags) > + if (new_crtc_state->uapi.mode.private_flags != > + old_crtc_state->uapi.mode.private_flags) > new_crtc_state->uapi.mode_changed = true; > } > > -- > 2.22.0 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check 2020-03-26 16:17 ` Ville Syrjälä @ 2020-03-26 17:45 ` Shankar, Uma 0 siblings, 0 replies; 7+ messages in thread From: Shankar, Uma @ 2020-03-26 17:45 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Khor, Swee Aun, intel-gfx > -----Original Message----- > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > Sent: Thursday, March 26, 2020 9:47 PM > To: Shankar, Uma <uma.shankar@intel.com> > Cc: intel-gfx@lists.freedesktop.org; Maarten Lankhorst > <maarten.lankhorst@linux.intel.com>; Kai Vehmanen > <kai.vehmanen@linux.intel.com>; Souza; Souza, Jose <jose.souza@intel.com>; > Khor, Swee Aun <swee.aun.khor@intel.com> > Subject: Re: [PATCH] drm/i915/display: Fix mode private_flags comparison at > atomic_check > > On Thu, Mar 26, 2020 at 01:19:28PM +0530, Uma Shankar wrote: > > This patch fixes the private_flags of mode to be checked and compared > > against uapi.mode and not from hw.mode. This helps properly trigger > > modeset at boot if desired by driver. > > > > It helps resolve audio_codec initialization issues if display is > > connected at boot. Initial discussion on this issue has happened on > > below thread: > > https://patchwork.freedesktop.org/series/74828/ > > > > Fixes: https://gitlab.freedesktop.org/drm/intel/issues/1363 > > > > Cc: Ville Syrjä <ville.syrjala@linux.intel.com> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com> > > Cc: Souza, Jose <jose.souza@intel.com> > > Suggested-by: Ville Syrjä <ville.syrjala@linux.intel.com> > > No one by that name here. Copied this from an existing reference, not sure how some characters got messed up ☹ > > Signed-off-by: Uma Shankar <uma.shankar@intel.com> > > Signed-off-by: SweeAun Khor <swee.aun.khor@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > > b/drivers/gpu/drm/i915/display/intel_display.c > > index fe55c7c713f1..e630429af2c0 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -14747,8 +14747,8 @@ static int intel_atomic_check(struct drm_device *dev, > > /* Catch I915_MODE_FLAG_INHERITED */ > > for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, > > new_crtc_state, i) { > > - if (new_crtc_state->hw.mode.private_flags != > > - old_crtc_state->hw.mode.private_flags) > > + if (new_crtc_state->uapi.mode.private_flags != > > + old_crtc_state->uapi.mode.private_flags) > > new_crtc_state->uapi.mode_changed = true; > > } > > > > -- > > 2.22.0 > > -- > Ville Syrjälä > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-26 17:46 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-26 7:49 [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check Uma Shankar 2020-03-26 8:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-03-26 9:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-03-26 10:47 ` [Intel-gfx] [PATCH] " Maarten Lankhorst 2020-03-26 11:59 ` Shankar, Uma 2020-03-26 16:17 ` Ville Syrjälä 2020-03-26 17:45 ` Shankar, Uma
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.