Re: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf

["Van Haaren, Harry" <harry.van.haaren@intel.com>]

> -----Original Message-----
> From: Varghese, Vipin
> Sent: Wednesday, April 4, 2018 12:52 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf
> 
> Sure Harry, I am ok with your suggestion.

Great!

Next steps;
1) Would you respin v3 the 1/2 patch to fix the compiler error?
   -- You may include my Acked-by: in the fixed commit.

2) Send v3 patch from above as reply to the 1/2 patch (http://dpdk.org/dev/patchwork/patch/35564/)
   -- Put Jerin on CC, as the patch should be ready for merge

3) Mark 1/2 and 2/2 (current revisions) as superseded to ensure 2/2 doesn't get merged :)


Cheers, -Harry


> > -----Original Message-----
> > From: Van Haaren, Harry
> > Sent: Tuesday, April 3, 2018 6:20 PM
> > To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org
> > Subject: RE: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf
> >
> > > -----Original Message-----
> > > From: Varghese, Vipin
> > > Sent: Thursday, March 1, 2018 7:35 PM
> > > To: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>
> > > Cc: Varghese, Vipin <vipin.varghese@intel.com>
> > > Subject: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf

<snip patch code changes>

> > I see the goal here - to ensure that the port buffer has items when we next
> enter
> > this function, possibly reducing a stall waiting for the ring access.
> >
> > In theory this is a good idea - in practice, I see a small performance
> degradation.
> > Hence, I suggest we drop this patch from the patchset, and merge 1/2 alone.