All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Varghese, Vipin" <vipin.varghese@intel.com>
Subject: Re: [PATCH v3] event/sw: code refractor to reduce the fetch stall
Date: Fri, 13 Apr 2018 16:19:54 +0000	[thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA65E02330A@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20180405085310.GB2674@jerin>

> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Thursday, April 5, 2018 9:53 AM
> To: Varghese, Vipin <vipin.varghese@intel.com>
> Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>
> Subject: Re: [PATCH v3] event/sw: code refractor to reduce the fetch stall
> 
> -----Original Message-----
> > Date: Thu, 5 Apr 2018 11:26:30 +0530
> > From: Vipin Varghese <vipin.varghese@intel.com>
> > To: dev@dpdk.org, harry.van.haaren@intel.com
> > CC: jerin.jacob@caviumnetworks.com, Vipin Varghese
> >  <vipin.varghese@intel.com>
> > Subject: [PATCH v3] event/sw: code refractor to reduce the fetch stall
> > X-Mailer: git-send-email 1.9.1
> >
> > With rearranging the code to prefetch the contents before
> > loop check increases performance from single and multistage
> > atomic pipeline.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> Applied to dpdk-next-eventdev/master. Thanks.


Hi Jerin,

On further investigation into the patch, the performance gains seem to be quite workload dependent.

Hereby a request to drop this patch from the next-eventdev tree, so that
we can investigate further, and rework / refactor for a future release.

Regards, -Harry

  reply	other threads:[~2018-04-13 16:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 19:34 [PATCH 1/2] event/sw: code refractor to reduce the fetch stall Vipin Varghese
2018-03-01 19:35 ` [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf Vipin Varghese
2018-04-03 12:50   ` Van Haaren, Harry
2018-04-04 11:51     ` Varghese, Vipin
2018-04-04 12:26       ` Van Haaren, Harry
2018-04-02  8:06 ` [PATCH 1/2] event/sw: code refractor to reduce the fetch stall Jerin Jacob
2018-04-03 12:47 ` Van Haaren, Harry
2018-04-05 11:24 ` [PATCH v2] " Vipin Varghese
2018-04-05  5:56   ` [PATCH v3] " Vipin Varghese
2018-04-05  8:53     ` Jerin Jacob
2018-04-13 16:19       ` Van Haaren, Harry [this message]
2018-04-14  5:28         ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E923DB57A917B54B9182A2E928D00FA65E02330A@IRSMSX101.ger.corp.intel.com \
    --to=harry.van.haaren@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.