All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] VT-d: drop pointless uses of __func__
@ 2016-08-24  7:54 Jan Beulich
  2016-08-24 20:30 ` Konrad Rzeszutek Wilk
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jan Beulich @ 2016-08-24  7:54 UTC (permalink / raw)
  To: xen-devel; +Cc: Kevin Tian, Feng Wu

[-- Attachment #1: Type: text/plain, Size: 4361 bytes --]

Debugging message text already includes file name and line number, so
also logging function names is redundant.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -242,8 +242,8 @@ static int remap_entry_to_ioapic_rte(
     if ( index < 0 || index > IREMAP_ENTRY_NR - 1 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: index (%d) for remap table is invalid !\n",
-                __func__, index);
+                "IO-APIC index (%d) for remap table is invalid\n",
+                index);
         return -EFAULT;
     }
 
@@ -255,8 +255,8 @@ static int remap_entry_to_ioapic_rte(
     if ( iremap_entry->val == 0 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: index (%d) get an empty entry!\n",
-                __func__, index);
+                "IO-APIC index (%d) has an empty entry\n",
+                index);
         unmap_vtd_domain_page(iremap_entries);
         spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
         return -EFAULT;
@@ -301,9 +301,8 @@ static int ioapic_rte_to_remap_entry(str
     if ( index > IREMAP_ENTRY_NR - 1 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: intremap index (%d) is larger than"
-                " the maximum index (%d)!\n",
-                __func__, index, IREMAP_ENTRY_NR - 1);
+                "IO-APIC intremap index (%d) larger than maximum index (%d)\n",
+                index, IREMAP_ENTRY_NR - 1);
         spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
         return -EFAULT;
     }
@@ -500,8 +499,8 @@ static int remap_entry_to_msi_msg(
     if ( index >= IREMAP_ENTRY_NR )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: index (%d) for remap table is invalid !\n",
-                __func__, index);
+                "MSI index (%d) for remap table is invalid\n",
+                index);
         return -EFAULT;
     }
 
@@ -513,8 +512,8 @@ static int remap_entry_to_msi_msg(
     if ( iremap_entry->val == 0 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: index (%d) get an empty entry!\n",
-                __func__, index);
+                "MSI index (%d) has an empty entry\n",
+                index);
         unmap_vtd_domain_page(iremap_entries);
         spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
         return -EFAULT;
@@ -585,9 +584,8 @@ static int msi_msg_to_remap_entry(
     if ( index > IREMAP_ENTRY_NR - 1 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: intremap index (%d) is larger than"
-                " the maximum index (%d)!\n",
-                __func__, index, IREMAP_ENTRY_NR - 1);
+                "MSI intremap index (%d) larger than maximum index (%d)!\n",
+                index, IREMAP_ENTRY_NR - 1);
         for ( i = 0; i < nr; ++i )
             msi_desc[i].remap_index = -1;
         spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
@@ -689,9 +687,8 @@ int __init intel_setup_hpet_msi(struct m
     if ( msi_desc->remap_index >= IREMAP_ENTRY_NR )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: intremap index (%d) is larger than"
-                " the maximum index (%d)!\n",
-                __func__, msi_desc->remap_index, IREMAP_ENTRY_NR - 1);
+                "HPET intremap index (%d) larger than maximum index (%d)!\n",
+                msi_desc->remap_index, IREMAP_ENTRY_NR - 1);
         msi_desc->remap_index = -1;
         rc = -ENXIO;
     }
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -129,11 +129,11 @@ static int context_get_domain_id(struct
 
         dom_index = context_domain_id(*context);
 
-        if ( dom_index < nr_dom && iommu->domid_map)
+        if ( dom_index < nr_dom && iommu->domid_map )
             domid = iommu->domid_map[dom_index];
         else
-            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds nr_dom %lu or iommu has no domid_map\n",
-                    __func__, dom_index, nr_dom);
+            dprintk(XENLOG_DEBUG VTDPREFIX, "dom_index %lu exceeds nr_dom %lu or iommu has no domid_map\n",
+                    dom_index, nr_dom);
     }
     return domid;
 }



[-- Attachment #2: VT-d-drop-__func__.patch --]
[-- Type: text/plain, Size: 4398 bytes --]

VT-d: drop pointless uses of __func__

Debugging message text already includes file name and line number, so
also logging function names is redundant.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -242,8 +242,8 @@ static int remap_entry_to_ioapic_rte(
     if ( index < 0 || index > IREMAP_ENTRY_NR - 1 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: index (%d) for remap table is invalid !\n",
-                __func__, index);
+                "IO-APIC index (%d) for remap table is invalid\n",
+                index);
         return -EFAULT;
     }
 
@@ -255,8 +255,8 @@ static int remap_entry_to_ioapic_rte(
     if ( iremap_entry->val == 0 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: index (%d) get an empty entry!\n",
-                __func__, index);
+                "IO-APIC index (%d) has an empty entry\n",
+                index);
         unmap_vtd_domain_page(iremap_entries);
         spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
         return -EFAULT;
@@ -301,9 +301,8 @@ static int ioapic_rte_to_remap_entry(str
     if ( index > IREMAP_ENTRY_NR - 1 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: intremap index (%d) is larger than"
-                " the maximum index (%d)!\n",
-                __func__, index, IREMAP_ENTRY_NR - 1);
+                "IO-APIC intremap index (%d) larger than maximum index (%d)\n",
+                index, IREMAP_ENTRY_NR - 1);
         spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
         return -EFAULT;
     }
@@ -500,8 +499,8 @@ static int remap_entry_to_msi_msg(
     if ( index >= IREMAP_ENTRY_NR )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: index (%d) for remap table is invalid !\n",
-                __func__, index);
+                "MSI index (%d) for remap table is invalid\n",
+                index);
         return -EFAULT;
     }
 
@@ -513,8 +512,8 @@ static int remap_entry_to_msi_msg(
     if ( iremap_entry->val == 0 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: index (%d) get an empty entry!\n",
-                __func__, index);
+                "MSI index (%d) has an empty entry\n",
+                index);
         unmap_vtd_domain_page(iremap_entries);
         spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
         return -EFAULT;
@@ -585,9 +584,8 @@ static int msi_msg_to_remap_entry(
     if ( index > IREMAP_ENTRY_NR - 1 )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: intremap index (%d) is larger than"
-                " the maximum index (%d)!\n",
-                __func__, index, IREMAP_ENTRY_NR - 1);
+                "MSI intremap index (%d) larger than maximum index (%d)!\n",
+                index, IREMAP_ENTRY_NR - 1);
         for ( i = 0; i < nr; ++i )
             msi_desc[i].remap_index = -1;
         spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
@@ -689,9 +687,8 @@ int __init intel_setup_hpet_msi(struct m
     if ( msi_desc->remap_index >= IREMAP_ENTRY_NR )
     {
         dprintk(XENLOG_ERR VTDPREFIX,
-                "%s: intremap index (%d) is larger than"
-                " the maximum index (%d)!\n",
-                __func__, msi_desc->remap_index, IREMAP_ENTRY_NR - 1);
+                "HPET intremap index (%d) larger than maximum index (%d)!\n",
+                msi_desc->remap_index, IREMAP_ENTRY_NR - 1);
         msi_desc->remap_index = -1;
         rc = -ENXIO;
     }
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -129,11 +129,11 @@ static int context_get_domain_id(struct
 
         dom_index = context_domain_id(*context);
 
-        if ( dom_index < nr_dom && iommu->domid_map)
+        if ( dom_index < nr_dom && iommu->domid_map )
             domid = iommu->domid_map[dom_index];
         else
-            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds nr_dom %lu or iommu has no domid_map\n",
-                    __func__, dom_index, nr_dom);
+            dprintk(XENLOG_DEBUG VTDPREFIX, "dom_index %lu exceeds nr_dom %lu or iommu has no domid_map\n",
+                    dom_index, nr_dom);
     }
     return domid;
 }

[-- Attachment #3: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] VT-d: drop pointless uses of __func__
  2016-08-24  7:54 [PATCH] VT-d: drop pointless uses of __func__ Jan Beulich
@ 2016-08-24 20:30 ` Konrad Rzeszutek Wilk
  2016-08-25  1:05 ` Tian, Kevin
  2016-08-25  1:08 ` Wu, Feng
  2 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-08-24 20:30 UTC (permalink / raw)
  To: Jan Beulich; +Cc: xen-devel, Kevin Tian, Feng Wu

On Wed, Aug 24, 2016 at 01:54:08AM -0600, Jan Beulich wrote:
> Debugging message text already includes file name and line number, so
> also logging function names is redundant.

And you also fixed one style guide violation :-)
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] VT-d: drop pointless uses of __func__
  2016-08-24  7:54 [PATCH] VT-d: drop pointless uses of __func__ Jan Beulich
  2016-08-24 20:30 ` Konrad Rzeszutek Wilk
@ 2016-08-25  1:05 ` Tian, Kevin
  2016-08-25  1:08 ` Wu, Feng
  2 siblings, 0 replies; 6+ messages in thread
From: Tian, Kevin @ 2016-08-25  1:05 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: Wu, Feng

> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: Wednesday, August 24, 2016 3:54 PM
> 
> Debugging message text already includes file name and line number, so
> also logging function names is redundant.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 

Acked-by: Kevin Tian <kevin.tian@intel.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] VT-d: drop pointless uses of __func__
  2016-08-24  7:54 [PATCH] VT-d: drop pointless uses of __func__ Jan Beulich
  2016-08-24 20:30 ` Konrad Rzeszutek Wilk
  2016-08-25  1:05 ` Tian, Kevin
@ 2016-08-25  1:08 ` Wu, Feng
  2016-08-25  6:44   ` Jan Beulich
  2 siblings, 1 reply; 6+ messages in thread
From: Wu, Feng @ 2016-08-25  1:08 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: Tian, Kevin, Wu, Feng



> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: Wednesday, August 24, 2016 3:54 PM
> To: xen-devel <xen-devel@lists.xenproject.org>
> Cc: Wu, Feng <feng.wu@intel.com>; Tian, Kevin <kevin.tian@intel.com>
> Subject: [PATCH] VT-d: drop pointless uses of __func__
> 
> Debugging message text already includes file name and line number, so
> also logging function names is redundant.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -242,8 +242,8 @@ static int remap_entry_to_ioapic_rte(
>      if ( index < 0 || index > IREMAP_ENTRY_NR - 1 )
>      {
>          dprintk(XENLOG_ERR VTDPREFIX,
> -                "%s: index (%d) for remap table is invalid !\n",
> -                __func__, index);
> +                "IO-APIC index (%d) for remap table is invalid\n",
> +                index);
>          return -EFAULT;
>      }
> 
> @@ -255,8 +255,8 @@ static int remap_entry_to_ioapic_rte(
>      if ( iremap_entry->val == 0 )
>      {
>          dprintk(XENLOG_ERR VTDPREFIX,
> -                "%s: index (%d) get an empty entry!\n",
> -                __func__, index);
> +                "IO-APIC index (%d) has an empty entry\n",
> +                index);
>          unmap_vtd_domain_page(iremap_entries);
>          spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
>          return -EFAULT;
> @@ -301,9 +301,8 @@ static int ioapic_rte_to_remap_entry(str
>      if ( index > IREMAP_ENTRY_NR - 1 )
>      {
>          dprintk(XENLOG_ERR VTDPREFIX,
> -                "%s: intremap index (%d) is larger than"
> -                " the maximum index (%d)!\n",
> -                __func__, index, IREMAP_ENTRY_NR - 1);
> +                "IO-APIC intremap index (%d) larger than maximum index (%d)\n",
> +                index, IREMAP_ENTRY_NR - 1);
>          spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
>          return -EFAULT;
>      }
> @@ -500,8 +499,8 @@ static int remap_entry_to_msi_msg(
>      if ( index >= IREMAP_ENTRY_NR )
>      {
>          dprintk(XENLOG_ERR VTDPREFIX,
> -                "%s: index (%d) for remap table is invalid !\n",
> -                __func__, index);
> +                "MSI index (%d) for remap table is invalid\n",
> +                index);
>          return -EFAULT;
>      }
> 
> @@ -513,8 +512,8 @@ static int remap_entry_to_msi_msg(
>      if ( iremap_entry->val == 0 )
>      {
>          dprintk(XENLOG_ERR VTDPREFIX,
> -                "%s: index (%d) get an empty entry!\n",
> -                __func__, index);
> +                "MSI index (%d) has an empty entry\n",
> +                index);
>          unmap_vtd_domain_page(iremap_entries);
>          spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
>          return -EFAULT;
> @@ -585,9 +584,8 @@ static int msi_msg_to_remap_entry(
>      if ( index > IREMAP_ENTRY_NR - 1 )
>      {
>          dprintk(XENLOG_ERR VTDPREFIX,
> -                "%s: intremap index (%d) is larger than"
> -                " the maximum index (%d)!\n",
> -                __func__, index, IREMAP_ENTRY_NR - 1);
> +                "MSI intremap index (%d) larger than maximum index (%d)!\n",
> +                index, IREMAP_ENTRY_NR - 1);
>          for ( i = 0; i < nr; ++i )
>              msi_desc[i].remap_index = -1;
>          spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
> @@ -689,9 +687,8 @@ int __init intel_setup_hpet_msi(struct m
>      if ( msi_desc->remap_index >= IREMAP_ENTRY_NR )
>      {
>          dprintk(XENLOG_ERR VTDPREFIX,
> -                "%s: intremap index (%d) is larger than"
> -                " the maximum index (%d)!\n",
> -                __func__, msi_desc->remap_index, IREMAP_ENTRY_NR - 1);
> +                "HPET intremap index (%d) larger than maximum index (%d)!\n",
> +                msi_desc->remap_index, IREMAP_ENTRY_NR - 1);
>          msi_desc->remap_index = -1;
>          rc = -ENXIO;
>      }
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -129,11 +129,11 @@ static int context_get_domain_id(struct
> 
>          dom_index = context_domain_id(*context);
> 
> -        if ( dom_index < nr_dom && iommu->domid_map)
> +        if ( dom_index < nr_dom && iommu->domid_map )
>              domid = iommu->domid_map[dom_index];
>          else
> -            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds
> nr_dom %lu or iommu has no domid_map\n",
> -                    __func__, dom_index, nr_dom);
> +            dprintk(XENLOG_DEBUG VTDPREFIX, "dom_index %lu exceeds
> nr_dom %lu or iommu has no domid_map\n",

This line exceeds the 80 characters limitation, do we have better way to handle this?

Thanks,
Feng

> +                    dom_index, nr_dom);
>      }
>      return domid;
>  }
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] VT-d: drop pointless uses of __func__
  2016-08-25  1:08 ` Wu, Feng
@ 2016-08-25  6:44   ` Jan Beulich
  2016-08-25  7:52     ` Wu, Feng
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2016-08-25  6:44 UTC (permalink / raw)
  To: Feng Wu; +Cc: xen-devel, Kevin Tian

>>> On 25.08.16 at 03:08, <feng.wu@intel.com> wrote:
>> From: Jan Beulich [mailto:JBeulich@suse.com]
>> Subject: [PATCH] VT-d: drop pointless uses of __func__
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -129,11 +129,11 @@ static int context_get_domain_id(struct
>> 
>>          dom_index = context_domain_id(*context);
>> 
>> -        if ( dom_index < nr_dom && iommu->domid_map)
>> +        if ( dom_index < nr_dom && iommu->domid_map )
>>              domid = iommu->domid_map[dom_index];
>>          else
>> -            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds
>> nr_dom %lu or iommu has no domid_map\n",
>> -                    __func__, dom_index, nr_dom);
>> +            dprintk(XENLOG_DEBUG VTDPREFIX, "dom_index %lu exceeds
>> nr_dom %lu or iommu has no domid_map\n",
> 
> This line exceeds the 80 characters limitation, do we have better way to 
> handle this?

Indeed; I had noticed this too (after sending) and intend to break
it like this:

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -129,11 +129,12 @@ static int context_get_domain_id(struct
 
         dom_index = context_domain_id(*context);
 
-        if ( dom_index < nr_dom && iommu->domid_map)
+        if ( dom_index < nr_dom && iommu->domid_map )
             domid = iommu->domid_map[dom_index];
         else
-            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds nr_dom %lu or iommu has no domid_map\n",
-                    __func__, dom_index, nr_dom);
+            dprintk(XENLOG_DEBUG VTDPREFIX,
+                    "dom_index %lu exceeds nr_dom %lu or iommu has no domid_map\n",
+                    dom_index, nr_dom);
     }
     return domid;
 }

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] VT-d: drop pointless uses of __func__
  2016-08-25  6:44   ` Jan Beulich
@ 2016-08-25  7:52     ` Wu, Feng
  0 siblings, 0 replies; 6+ messages in thread
From: Wu, Feng @ 2016-08-25  7:52 UTC (permalink / raw)
  To: Jan Beulich; +Cc: xen-devel, Tian, Kevin, Wu, Feng



> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: Thursday, August 25, 2016 2:45 PM
> To: Wu, Feng <feng.wu@intel.com>
> Cc: Tian, Kevin <kevin.tian@intel.com>; xen-devel <xen-
> devel@lists.xenproject.org>
> Subject: RE: [PATCH] VT-d: drop pointless uses of __func__
> 
> >>> On 25.08.16 at 03:08, <feng.wu@intel.com> wrote:
> >> From: Jan Beulich [mailto:JBeulich@suse.com]
> >> Subject: [PATCH] VT-d: drop pointless uses of __func__
> >> --- a/xen/drivers/passthrough/vtd/iommu.c
> >> +++ b/xen/drivers/passthrough/vtd/iommu.c
> >> @@ -129,11 +129,11 @@ static int context_get_domain_id(struct
> >>
> >>          dom_index = context_domain_id(*context);
> >>
> >> -        if ( dom_index < nr_dom && iommu->domid_map)
> >> +        if ( dom_index < nr_dom && iommu->domid_map )
> >>              domid = iommu->domid_map[dom_index];
> >>          else
> >> -            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds
> >> nr_dom %lu or iommu has no domid_map\n",
> >> -                    __func__, dom_index, nr_dom);
> >> +            dprintk(XENLOG_DEBUG VTDPREFIX, "dom_index %lu exceeds
> >> nr_dom %lu or iommu has no domid_map\n",
> >
> > This line exceeds the 80 characters limitation, do we have better way to
> > handle this?
> 
> Indeed; I had noticed this too (after sending) and intend to break
> it like this:
> 
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -129,11 +129,12 @@ static int context_get_domain_id(struct
> 
>          dom_index = context_domain_id(*context);
> 
> -        if ( dom_index < nr_dom && iommu->domid_map)
> +        if ( dom_index < nr_dom && iommu->domid_map )
>              domid = iommu->domid_map[dom_index];
>          else
> -            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds
> nr_dom %lu or iommu has no domid_map\n",
> -                    __func__, dom_index, nr_dom);
> +            dprintk(XENLOG_DEBUG VTDPREFIX,
> +                    "dom_index %lu exceeds nr_dom %lu or iommu has no
> domid_map\n",
> +                    dom_index, nr_dom);

Looks good to me.

Reviewed-by Feng Wu <feng.wu@intel.com>

Thanks,
Feng

>      }
>      return domid;
>  }
> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-08-25  7:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-24  7:54 [PATCH] VT-d: drop pointless uses of __func__ Jan Beulich
2016-08-24 20:30 ` Konrad Rzeszutek Wilk
2016-08-25  1:05 ` Tian, Kevin
2016-08-25  1:08 ` Wu, Feng
2016-08-25  6:44   ` Jan Beulich
2016-08-25  7:52     ` Wu, Feng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.