Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT

From: "Kyle J. McKay" <mackyle@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	msysgit@googlegroups.com, "Torsten Bögershausen" <tboegi@web.de>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT
Date: Fri, 16 Jan 2015 10:38:39 -0800	[thread overview]
Message-ID: <E986F3A9-0FFD-4653-8B1C-67C79FFB607B@gmail.com> (raw)
In-Reply-To: <20150116091648.GA2450@peff.net>

On Jan 16, 2015, at 01:16, Jeff King wrote:

> Subject: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT
[...]
> We implement NOT_ROOT by checking `id -u`, which is in POSIX
> and seems to be available even on MSYS.  Note that we cannot
> just call this "ROOT" and ask for "!ROOT". The possible
> outcomes are:
>
>  1. we know we are root
>
>  2. we know we are not root
>
>  3. we could not tell, because `id` was not available
>
> We should conservatively treat (3) as "does not have the
> prerequisite", which means that a naive negation would not
> work.
[...]
> +
> +test_lazy_prereq NOT_ROOT '
> +	uid=$(id -u) &&
> +	test "$uid" != 0
> +'

That looks good to me and worked as expected when I tried it.

-Kyle

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.