Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT

From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Jeff King <peff@peff.net>,  "Kyle J. McKay" <mackyle@gmail.com>,
	 msysgit@googlegroups.com,
	 Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT
Date: Thu, 22 Jan 2015 14:07:26 -0800	[thread overview]
Message-ID: <xmqqlhkusc4h.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54C170E9.4010401@web.de> ("Torsten =?utf-8?Q?B=C3=B6gershaus?= =?utf-8?Q?en=22's?= message of "Thu, 22 Jan 2015 22:51:37 +0100")

Torsten Bögershausen <tboegi@web.de> writes:

> If I run that sequence manually:
> chmod 755 .
> touch x
> chmod a-w .
> rm x
> touch y
>
> x is gone, (but shoudn't according to POSIX)
> y is not created, "access denied"

Good (or is that Sad?).

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1039,7 +1039,17 @@ test_lazy_prereq NOT_ROOT '
>  # When the tests are run as root, permission tests will report that
>  # things are writable when they shouldn't be.
>  test_lazy_prereq SANITY '
> -       test_have_prereq POSIXPERM,NOT_ROOT
> +       mkdir ds &&
> +       touch ds/x &&
> +       chmod -w ds &&
> +       if rm ds/x
> +       then
> +               chmod +w ds
> +               false
> +       else
> +               chmod +w ds
> +               true
> +       fi
>  '

It looks like a better approach overall.

Because we cannot know where $(pwd) is when lazy prereq is evaluated
(it typically is at the root of the trash hierarchy, but not always)
and we would not want to add, leave or remove random files in the
working tree that are not expected by the tests proper (e.g. a test
that counts untracked paths are not expecting ds/ to be there), your
actual "fix" may need to be a bit more careful, though.

Thanks.

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.