From: "Shilimkar, Santosh" <santosh.shilimkar@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org> Subject: RE: [PATCH 1/4] omap: Clean the serial port defines Date: Sun, 17 Jan 2010 01:03:18 +0530 [thread overview] Message-ID: <EAF47CD23C76F840A9E7FCE10091EFAB02C06F906A@dbde02.ent.ti.com> (raw) In-Reply-To: <20100116192538.GK10318@atomide.com> > -----Original Message----- > From: Tony Lindgren [mailto:tony@atomide.com] > Sent: Sunday, January 17, 2010 12:56 AM > To: Shilimkar, Santosh > Cc: linux-arm-kernel@lists.infradead.org; linux-omap@vger.kernel.org > Subject: Re: [PATCH 1/4] omap: Clean the serial port defines > > * Shilimkar, Santosh <santosh.shilimkar@ti.com> [100115 23:46]: > > Thanks for the nice cleanup. > > Thanks for testing :) > > > <snip> > > > --- a/arch/arm/plat-omap/include/plat/common.h > > > +++ b/arch/arm/plat-omap/include/plat/common.h > > > @@ -47,6 +47,10 @@ struct omap_globals { > > > void __iomem *prm; /* Power and Reset Management */ > > > void __iomem *cm; /* Clock Management */ > > > void __iomem *cm2; > > > + unsigned long uart1_phys; > > > + unsigned long uart2_phys; > > > + unsigned long uart3_phys; > > > + unsigned long uart4_phys; > > Considering they are register base address, can > > these be declared as "void __iomem" instead of "unsigned long" > > These are physical addresses instead of virtual addresses. > They get ioremapped in mach-omap[12]/serial.c. So they should > not be void __iomem * in omap_globals. Yep. I see your point. > BTW, we should eventually change everything in omap_globals > to be physical addresses. We did some work for OMAP4 to move most of the things to ioremap istead of those hardcoded macros. Let me know when you want to do this clean up. We can do this together. Regards Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Shilimkar, Santosh) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/4] omap: Clean the serial port defines Date: Sun, 17 Jan 2010 01:03:18 +0530 [thread overview] Message-ID: <EAF47CD23C76F840A9E7FCE10091EFAB02C06F906A@dbde02.ent.ti.com> (raw) In-Reply-To: <20100116192538.GK10318@atomide.com> > -----Original Message----- > From: Tony Lindgren [mailto:tony at atomide.com] > Sent: Sunday, January 17, 2010 12:56 AM > To: Shilimkar, Santosh > Cc: linux-arm-kernel at lists.infradead.org; linux-omap at vger.kernel.org > Subject: Re: [PATCH 1/4] omap: Clean the serial port defines > > * Shilimkar, Santosh <santosh.shilimkar@ti.com> [100115 23:46]: > > Thanks for the nice cleanup. > > Thanks for testing :) > > > <snip> > > > --- a/arch/arm/plat-omap/include/plat/common.h > > > +++ b/arch/arm/plat-omap/include/plat/common.h > > > @@ -47,6 +47,10 @@ struct omap_globals { > > > void __iomem *prm; /* Power and Reset Management */ > > > void __iomem *cm; /* Clock Management */ > > > void __iomem *cm2; > > > + unsigned long uart1_phys; > > > + unsigned long uart2_phys; > > > + unsigned long uart3_phys; > > > + unsigned long uart4_phys; > > Considering they are register base address, can > > these be declared as "void __iomem" instead of "unsigned long" > > These are physical addresses instead of virtual addresses. > They get ioremapped in mach-omap[12]/serial.c. So they should > not be void __iomem * in omap_globals. Yep. I see your point. > BTW, we should eventually change everything in omap_globals > to be physical addresses. We did some work for OMAP4 to move most of the things to ioremap istead of those hardcoded macros. Let me know when you want to do this clean up. We can do this together. Regards Santosh
next prev parent reply other threads:[~2010-01-16 19:33 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-16 1:35 [PATCH 0/4] omap multiboot improvments for merge window after 2.6.34 Tony Lindgren 2010-01-16 1:35 ` Tony Lindgren 2010-01-16 1:35 ` [PATCH 1/4] omap: Clean the serial port defines Tony Lindgren 2010-01-16 1:35 ` Tony Lindgren 2010-01-16 7:48 ` Shilimkar, Santosh 2010-01-16 7:48 ` Shilimkar, Santosh 2010-01-16 19:25 ` Tony Lindgren 2010-01-16 19:25 ` Tony Lindgren 2010-01-16 19:33 ` Shilimkar, Santosh [this message] 2010-01-16 19:33 ` Shilimkar, Santosh 2010-01-16 20:03 ` Tony Lindgren 2010-01-16 20:03 ` Tony Lindgren 2010-01-19 0:39 ` Pandita, Vikram 2010-01-19 0:39 ` Pandita, Vikram 2010-01-20 23:10 ` Tony Lindgren 2010-01-20 23:10 ` Tony Lindgren 2010-01-16 1:35 ` [PATCH 2/4] omap: Make uncompress code and DEBUG_LL code generic Tony Lindgren 2010-01-16 1:35 ` Tony Lindgren 2010-01-16 9:35 ` Russell King - ARM Linux 2010-01-16 9:35 ` Russell King - ARM Linux 2010-01-16 19:18 ` Tony Lindgren 2010-01-16 19:18 ` Tony Lindgren 2010-01-16 19:33 ` Russell King - ARM Linux 2010-01-16 19:33 ` Russell King - ARM Linux 2010-01-16 20:00 ` Tony Lindgren 2010-01-16 20:00 ` Tony Lindgren 2010-01-19 1:50 ` Pandita, Vikram 2010-01-19 1:50 ` Pandita, Vikram 2010-01-22 3:07 ` [PATCH 2/4] omap: Make uncompress code and DEBUG_LL code generic, v2 Tony Lindgren 2010-01-22 3:07 ` Tony Lindgren 2010-01-22 14:48 ` Pandita, Vikram 2010-01-22 14:48 ` Pandita, Vikram 2010-01-22 20:55 ` Tony Lindgren 2010-01-22 20:55 ` Tony Lindgren 2010-01-22 20:58 ` Pandita, Vikram 2010-01-22 20:58 ` Pandita, Vikram 2010-01-22 21:10 ` Tony Lindgren 2010-01-22 21:10 ` Tony Lindgren 2010-01-22 23:10 ` Pandita, Vikram 2010-01-22 23:10 ` Pandita, Vikram 2010-01-23 17:13 ` Tony Lindgren 2010-01-23 17:13 ` Tony Lindgren 2010-01-21 19:03 ` [PATCH 2/4] omap: Make uncompress code and DEBUG_LL code generic Tony Lindgren 2010-01-21 19:03 ` Tony Lindgren 2010-01-16 11:04 ` Shilimkar, Santosh 2010-01-16 11:04 ` Shilimkar, Santosh 2010-01-16 19:20 ` Tony Lindgren 2010-01-16 19:20 ` Tony Lindgren 2010-01-16 19:34 ` Shilimkar, Santosh 2010-01-16 19:34 ` Shilimkar, Santosh 2010-01-19 1:26 ` Pandita, Vikram 2010-01-19 1:26 ` Pandita, Vikram 2010-01-19 17:19 ` Kevin Hilman 2010-01-19 17:19 ` Kevin Hilman 2010-01-26 17:22 ` Tony Lindgren 2010-01-26 17:22 ` Tony Lindgren 2010-01-16 1:35 ` [PATCH 3/4] omap: Remove old DEBUG_LL serial port options Tony Lindgren 2010-01-16 1:35 ` Tony Lindgren 2010-01-16 1:35 ` [PATCH 4/4] omap: Make get_irqnr_and_base common for mach-omap2 multiboot Tony Lindgren 2010-01-16 1:35 ` Tony Lindgren 2010-01-16 11:24 ` Shilimkar, Santosh 2010-01-16 11:24 ` Shilimkar, Santosh 2010-01-16 11:55 ` Russell King - ARM Linux 2010-01-16 11:55 ` Russell King - ARM Linux 2010-01-16 19:12 ` Tony Lindgren 2010-01-16 19:12 ` Tony Lindgren 2010-01-22 20:39 ` [PATCH 4/4] omap: Make get_irqnr_and_base common for mach-omap2 multiboot, v2 Tony Lindgren 2010-01-22 20:39 ` Tony Lindgren 2010-01-22 20:56 ` Russell King - ARM Linux 2010-01-22 20:56 ` Russell King - ARM Linux 2010-01-22 21:09 ` Tony Lindgren 2010-01-22 21:09 ` Tony Lindgren 2010-01-22 21:16 ` Tony Lindgren 2010-01-22 21:16 ` Tony Lindgren 2010-01-16 20:15 ` [PATCH 0/4] omap multiboot improvments for merge window after 2.6.34 Tony Lindgren 2010-01-16 20:15 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=EAF47CD23C76F840A9E7FCE10091EFAB02C06F906A@dbde02.ent.ti.com \ --to=santosh.shilimkar@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.