All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] Fix omap_type() function
@ 2010-07-10  7:08 Vikram Pandita
  2010-07-10  7:08 ` [PATCH 1/3] omap: sram: fix is_sram_locked check Vikram Pandita
  2010-07-10  7:31 ` [PATCH 0/3] Fix omap_type() function Shilimkar, Santosh
  0 siblings, 2 replies; 9+ messages in thread
From: Vikram Pandita @ 2010-07-10  7:08 UTC (permalink / raw)
  To: linux-omap; +Cc: Vikram Pandita

Aim was to get omap_type() function work on omap4.
In doing so, fixing an issue with is_sram_locked() function.

Patches tested/verified on omap4 sdp.
Patches based of latest linus commit: e467e10

Vikram Pandita (3):
  omap: sram: fix is_sram_locked check
  omap4: fix omap_type() function
  omap4: SRAM start and size change for EMU/HS devices

 arch/arm/plat-omap/include/plat/omap44xx.h |    2 +-
 arch/arm/plat-omap/sram.c                  |   28 ++++++++++++++--------------
 2 files changed, 15 insertions(+), 15 deletions(-)


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/3] omap: sram: fix is_sram_locked check
  2010-07-10  7:08 [PATCH 0/3] Fix omap_type() function Vikram Pandita
@ 2010-07-10  7:08 ` Vikram Pandita
  2010-07-10  7:08   ` [PATCH 2/3] omap4: fix omap_type() function Vikram Pandita
  2010-07-10  7:27   ` [PATCH 1/3] omap: sram: fix is_sram_locked check Shilimkar, Santosh
  2010-07-10  7:31 ` [PATCH 0/3] Fix omap_type() function Shilimkar, Santosh
  1 sibling, 2 replies; 9+ messages in thread
From: Vikram Pandita @ 2010-07-10  7:08 UTC (permalink / raw)
  To: linux-omap; +Cc: Vikram Pandita

For OMAP24xx/34xx/44xx: omap_type() returns the correct type:
 OMAP2_DEVICE_TYPE_TEST
 OMAP2_DEVICE_TYPE_EMU
 OMAP2_DEVICE_TYPE_SEC
 OMAP2_DEVICE_TYPE_GP
 OMAP2_DEVICE_TYPE_BAD

In current implementation there are two problems:
Problem 1:
For 34xx, the current if check will never return true.

Problem 2:
For 24xx the correct type check should be with omap_type() function
Verified by checking the TRM 24xx for CONTROL_STATUS register bits

Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
---
 arch/arm/plat-omap/sram.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index 226b2e8..2eb5a27 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -93,16 +93,11 @@ extern unsigned long omapfb_reserve_sram(unsigned long sram_pstart,
  */
 static int is_sram_locked(void)
 {
-	int type = 0;
-
 	if (cpu_is_omap44xx())
 		/* Not yet supported */
 		return 0;
 
-	if (cpu_is_omap242x())
-		type = omap_rev() & OMAP2_DEVICETYPE_MASK;
-
-	if (type == GP_DEVICE) {
+	if (OMAP2_DEVICE_TYPE_GP == omap_type()) {
 		/* RAMFW: R/W access to all initiators for all qualifier sets */
 		if (cpu_is_omap242x()) {
 			__raw_writel(0xFF, OMAP24XX_VA_REQINFOPERM0); /* all q-vects */
-- 
1.6.6.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/3] omap4: fix omap_type() function
  2010-07-10  7:08 ` [PATCH 1/3] omap: sram: fix is_sram_locked check Vikram Pandita
@ 2010-07-10  7:08   ` Vikram Pandita
  2010-07-10  7:08     ` [PATCH 3/3] omap4: SRAM start and size change for EMU/HS devices Vikram Pandita
  2010-07-10  7:23     ` [PATCH 2/3] omap4: fix omap_type() function Shilimkar, Santosh
  2010-07-10  7:27   ` [PATCH 1/3] omap: sram: fix is_sram_locked check Shilimkar, Santosh
  1 sibling, 2 replies; 9+ messages in thread
From: Vikram Pandita @ 2010-07-10  7:08 UTC (permalink / raw)
  To: linux-omap; +Cc: Vikram Pandita

Following patch added the omap_type() functionality for omap4
	737daa03: omap4: Fix omap_type() for omap4

However the omap_type() function would not work as:
1) the base address for CONTROL_STATUS register is wrongly mapped

2) "Not yet supported" check for omap4 needs to be removed

Verified on OMAP4 SDP board

Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
---
 arch/arm/plat-omap/include/plat/omap44xx.h |    2 +-
 arch/arm/plat-omap/sram.c                  |    4 ----
 2 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h b/arch/arm/plat-omap/include/plat/omap44xx.h
index 8b3f12f..2075856 100644
--- a/arch/arm/plat-omap/include/plat/omap44xx.h
+++ b/arch/arm/plat-omap/include/plat/omap44xx.h
@@ -33,7 +33,7 @@
 #define OMAP4430_PRCM_MPU_BASE		0x48243000
 #define OMAP44XX_GPMC_BASE		0x50000000
 #define OMAP443X_SCM_BASE		0x4a002000
-#define OMAP443X_CTRL_BASE		0x4a100000
+#define OMAP443X_CTRL_BASE		0x4a002000
 #define OMAP44XX_IC_BASE		0x48200000
 #define OMAP44XX_IVA_INTC_BASE		0x40000000
 #define IRQ_SIR_IRQ			0x0040
diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index 2eb5a27..112b807 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -93,10 +93,6 @@ extern unsigned long omapfb_reserve_sram(unsigned long sram_pstart,
  */
 static int is_sram_locked(void)
 {
-	if (cpu_is_omap44xx())
-		/* Not yet supported */
-		return 0;
-
 	if (OMAP2_DEVICE_TYPE_GP == omap_type()) {
 		/* RAMFW: R/W access to all initiators for all qualifier sets */
 		if (cpu_is_omap242x()) {
-- 
1.6.6.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/3] omap4: SRAM start and size change for EMU/HS devices
  2010-07-10  7:08   ` [PATCH 2/3] omap4: fix omap_type() function Vikram Pandita
@ 2010-07-10  7:08     ` Vikram Pandita
  2010-07-10  7:25       ` Shilimkar, Santosh
  2010-07-10  7:23     ` [PATCH 2/3] omap4: fix omap_type() function Shilimkar, Santosh
  1 sibling, 1 reply; 9+ messages in thread
From: Vikram Pandita @ 2010-07-10  7:08 UTC (permalink / raw)
  To: linux-omap; +Cc: Vikram Pandita

On OMAP4 the SRAM configuration is:
GP Device:
        Start Address: 0x4030 0000
        Size: 0xE000 (56KB)

EMU/HS Device:
        Start Address: 0x4030 4000
        Size: 0xA000 (40KB)

Implement this mapping in the sram file

Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
---
 arch/arm/plat-omap/sram.c |   17 +++++++++++++----
 1 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index 112b807..3c7c9a6 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -53,7 +53,7 @@
 #define OMAP4_SRAM_PUB_PA	(OMAP4_SRAM_PA + 0x4000)
 #define OMAP4_SRAM_PUB_VA	(OMAP4_SRAM_VA + 0x4000)
 
-#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
+#if defined(CONFIG_ARCH_OMAP2PLUS)
 #define SRAM_BOOTLOADER_SZ	0x00
 #else
 #define SRAM_BOOTLOADER_SZ	0x80
@@ -134,9 +134,18 @@ void __init omap_detect_sram(void)
 					omap_sram_size = 0x8000; /* 32K */
 				}
 			} else if (cpu_is_omap44xx()) {
-				omap_sram_base = OMAP4_SRAM_PUB_VA;
-				omap_sram_start = OMAP4_SRAM_PUB_PA;
-				omap_sram_size = 0xa000; /* 40K */
+				if ((omap_type() == OMAP2_DEVICE_TYPE_EMU) ||
+				    (omap_type() == OMAP2_DEVICE_TYPE_SEC)) {
+					/* 40K For Public SRAM */
+					omap_sram_base = OMAP4_SRAM_PUB_VA;
+					omap_sram_start = OMAP4_SRAM_PUB_PA;
+					omap_sram_size = 0xA000;
+				} else {
+					/* 56 KB SRAM on GP device */
+					omap_sram_base = OMAP4_SRAM_VA;
+					omap_sram_start = OMAP4_SRAM_PA;
+					omap_sram_size = 0xE000;
+				}
 			} else {
 				omap_sram_base = OMAP2_SRAM_PUB_VA;
 				omap_sram_start = OMAP2_SRAM_PUB_PA;
-- 
1.6.6.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* RE: [PATCH 2/3] omap4: fix omap_type() function
  2010-07-10  7:08   ` [PATCH 2/3] omap4: fix omap_type() function Vikram Pandita
  2010-07-10  7:08     ` [PATCH 3/3] omap4: SRAM start and size change for EMU/HS devices Vikram Pandita
@ 2010-07-10  7:23     ` Shilimkar, Santosh
  1 sibling, 0 replies; 9+ messages in thread
From: Shilimkar, Santosh @ 2010-07-10  7:23 UTC (permalink / raw)
  To: Pandita, Vikram, linux-omap

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Pandita, Vikram
> Sent: Saturday, July 10, 2010 12:39 PM
> To: linux-omap@vger.kernel.org
> Cc: Pandita, Vikram
> Subject: [PATCH 2/3] omap4: fix omap_type() function
> 
> Following patch added the omap_type() functionality for omap4
> 	737daa03: omap4: Fix omap_type() for omap4
> 
> However the omap_type() function would not work as:
> 1) the base address for CONTROL_STATUS register is wrongly mapped
> 
As I already told you off the list, the address is not wrong. OMAP4 
has different bases for CORE and WAKEUP control modules.
Your patch will break the PBIAS of MMC straight a way.

NAK.

I have reported this issue to Tony when the mux framework 
was getting developed.

> 2) "Not yet supported" check for omap4 needs to be removed
> 
> Verified on OMAP4 SDP board
> 
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
>  arch/arm/plat-omap/include/plat/omap44xx.h |    2 +-
>  arch/arm/plat-omap/sram.c                  |    4 ----
>  2 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h b/arch/arm/plat-
> omap/include/plat/omap44xx.h
> index 8b3f12f..2075856 100644
> --- a/arch/arm/plat-omap/include/plat/omap44xx.h
> +++ b/arch/arm/plat-omap/include/plat/omap44xx.h
> @@ -33,7 +33,7 @@
>  #define OMAP4430_PRCM_MPU_BASE		0x48243000
>  #define OMAP44XX_GPMC_BASE		0x50000000
>  #define OMAP443X_SCM_BASE		0x4a002000
> -#define OMAP443X_CTRL_BASE		0x4a100000
> +#define OMAP443X_CTRL_BASE		0x4a002000
>  #define OMAP44XX_IC_BASE		0x48200000
>  #define OMAP44XX_IVA_INTC_BASE		0x40000000
>  #define IRQ_SIR_IRQ			0x0040
> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> index 2eb5a27..112b807 100644
> --- a/arch/arm/plat-omap/sram.c
> +++ b/arch/arm/plat-omap/sram.c
> @@ -93,10 +93,6 @@ extern unsigned long omapfb_reserve_sram(unsigned long
> sram_pstart,
>   */
>  static int is_sram_locked(void)
>  {
> -	if (cpu_is_omap44xx())
> -		/* Not yet supported */
> -		return 0;
> -
>  	if (OMAP2_DEVICE_TYPE_GP == omap_type()) {
>  		/* RAMFW: R/W access to all initiators for all qualifier sets
> */
>  		if (cpu_is_omap242x()) {
> --
> 1.6.6.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 3/3] omap4: SRAM start and size change for EMU/HS devices
  2010-07-10  7:08     ` [PATCH 3/3] omap4: SRAM start and size change for EMU/HS devices Vikram Pandita
@ 2010-07-10  7:25       ` Shilimkar, Santosh
  0 siblings, 0 replies; 9+ messages in thread
From: Shilimkar, Santosh @ 2010-07-10  7:25 UTC (permalink / raw)
  To: linux-omap; +Cc: Pandita, Vikram



> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Vikram Pandita
> Sent: Saturday, July 10, 2010 12:39 PM
> To: linux-omap@vger.kernel.org
> Cc: Pandita, Vikram
> Subject: [PATCH 3/3] omap4: SRAM start and size change for EMU/HS devices
> 
> On OMAP4 the SRAM configuration is:
> GP Device:
>         Start Address: 0x4030 0000
>         Size: 0xE000 (56KB)
> 
> EMU/HS Device:
>         Start Address: 0x4030 4000
>         Size: 0xA000 (40KB)
> 
> Implement this mapping in the sram file
> 
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
>  arch/arm/plat-omap/sram.c |   17 +++++++++++++----
>  1 files changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> index 112b807..3c7c9a6 100644
> --- a/arch/arm/plat-omap/sram.c
> +++ b/arch/arm/plat-omap/sram.c
> @@ -53,7 +53,7 @@
>  #define OMAP4_SRAM_PUB_PA	(OMAP4_SRAM_PA + 0x4000)
>  #define OMAP4_SRAM_PUB_VA	(OMAP4_SRAM_VA + 0x4000)
> 
> -#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
> +#if defined(CONFIG_ARCH_OMAP2PLUS)
Only this line needs to be added in this patch
>  #define SRAM_BOOTLOADER_SZ	0x00
>  #else
>  #define SRAM_BOOTLOADER_SZ	0x80
> @@ -134,9 +134,18 @@ void __init omap_detect_sram(void)
>  					omap_sram_size = 0x8000; /* 32K */
>  				}
>  			} else if (cpu_is_omap44xx()) {
> -				omap_sram_base = OMAP4_SRAM_PUB_VA;
> -				omap_sram_start = OMAP4_SRAM_PUB_PA;
> -				omap_sram_size = 0xa000; /* 40K */
> +				if ((omap_type() == OMAP2_DEVICE_TYPE_EMU) ||
> +				    (omap_type() == OMAP2_DEVICE_TYPE_SEC)) {
> +					/* 40K For Public SRAM */
> +					omap_sram_base = OMAP4_SRAM_PUB_VA;
> +					omap_sram_start = OMAP4_SRAM_PUB_PA;
> +					omap_sram_size = 0xA000;
> +				} else {
> +					/* 56 KB SRAM on GP device */
> +					omap_sram_base = OMAP4_SRAM_VA;
> +					omap_sram_start = OMAP4_SRAM_PA;
> +					omap_sram_size = 0xE000;

Not necessary. If the "is_sram_locked" retunrs the correct retun value then this already handled.

Just look below the else part which handles the GP and if already has EMU size.
> +				}
>  			} else {
>  				omap_sram_base = OMAP2_SRAM_PUB_VA;
>  				omap_sram_start = OMAP2_SRAM_PUB_PA;
> --
> 1.6.6.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 1/3] omap: sram: fix is_sram_locked check
  2010-07-10  7:08 ` [PATCH 1/3] omap: sram: fix is_sram_locked check Vikram Pandita
  2010-07-10  7:08   ` [PATCH 2/3] omap4: fix omap_type() function Vikram Pandita
@ 2010-07-10  7:27   ` Shilimkar, Santosh
  1 sibling, 0 replies; 9+ messages in thread
From: Shilimkar, Santosh @ 2010-07-10  7:27 UTC (permalink / raw)
  To: Pandita, Vikram, linux-omap

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Pandita, Vikram
> Sent: Saturday, July 10, 2010 12:39 PM
> To: linux-omap@vger.kernel.org
> Cc: Pandita, Vikram
> Subject: [PATCH 1/3] omap: sram: fix is_sram_locked check
> 
> For OMAP24xx/34xx/44xx: omap_type() returns the correct type:
>  OMAP2_DEVICE_TYPE_TEST
>  OMAP2_DEVICE_TYPE_EMU
>  OMAP2_DEVICE_TYPE_SEC
>  OMAP2_DEVICE_TYPE_GP
>  OMAP2_DEVICE_TYPE_BAD
> 
> In current implementation there are two problems:
> Problem 1:
> For 34xx, the current if check will never return true.
> 
> Problem 2:
> For 24xx the correct type check should be with omap_type() function
> Verified by checking the TRM 24xx for CONTROL_STATUS register bits
> 
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
>  arch/arm/plat-omap/sram.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> index 226b2e8..2eb5a27 100644
> --- a/arch/arm/plat-omap/sram.c
> +++ b/arch/arm/plat-omap/sram.c
> @@ -93,16 +93,11 @@ extern unsigned long omapfb_reserve_sram(unsigned long
> sram_pstart,
>   */
>  static int is_sram_locked(void)
>  {
> -	int type = 0;
> -
>  	if (cpu_is_omap44xx())
>  		/* Not yet supported */
>  		return 0;
> 
> -	if (cpu_is_omap242x())
> -		type = omap_rev() & OMAP2_DEVICETYPE_MASK;
> -
> -	if (type == GP_DEVICE) {
> +	if (OMAP2_DEVICE_TYPE_GP == omap_type()) {
>  		/* RAMFW: R/W access to all initiators for all qualifier sets
> */
>  		if (cpu_is_omap242x()) {
>  			__raw_writel(0xFF, OMAP24XX_VA_REQINFOPERM0); /* all q-
> vects */
This one looks fine to me.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 0/3] Fix omap_type() function
  2010-07-10  7:08 [PATCH 0/3] Fix omap_type() function Vikram Pandita
  2010-07-10  7:08 ` [PATCH 1/3] omap: sram: fix is_sram_locked check Vikram Pandita
@ 2010-07-10  7:31 ` Shilimkar, Santosh
  2010-07-10 13:59   ` Pandita, Vikram
  1 sibling, 1 reply; 9+ messages in thread
From: Shilimkar, Santosh @ 2010-07-10  7:31 UTC (permalink / raw)
  To: Pandita, Vikram, linux-omap

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Pandita, Vikram
> Sent: Saturday, July 10, 2010 12:39 PM
> To: linux-omap@vger.kernel.org
> Cc: Pandita, Vikram
> Subject: [PATCH 0/3] Fix omap_type() function
> 
> Aim was to get omap_type() function work on omap4.
> In doing so, fixing an issue with is_sram_locked() function.
> 
> Patches tested/verified on omap4 sdp.
> Patches based of latest linus commit: e467e10
> 
> Vikram Pandita (3):
>   omap: sram: fix is_sram_locked check
>   omap4: fix omap_type() function
>   omap4: SRAM start and size change for EMU/HS devices
> 
>  arch/arm/plat-omap/include/plat/omap44xx.h |    2 +-
>  arch/arm/plat-omap/sram.c                  |   28 ++++++++++++++---------
In summary only fixing " is_sram_locked()" and adding the OMAP_2PLUS is enough.

The control module needs to be fixed in right way because with different bases in wakeup and core control modules makes
the current omap_control_read/write break on OMAP4. This is similar problem
what we have on powerdomain base offsets and needs a proper handling.

Fixing one base will break other register acceses

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 0/3] Fix omap_type() function
  2010-07-10  7:31 ` [PATCH 0/3] Fix omap_type() function Shilimkar, Santosh
@ 2010-07-10 13:59   ` Pandita, Vikram
  0 siblings, 0 replies; 9+ messages in thread
From: Pandita, Vikram @ 2010-07-10 13:59 UTC (permalink / raw)
  To: Shilimkar, Santosh, linux-omap



>-----Original Message-----
>From: Shilimkar, Santosh
>Sent: Saturday, July 10, 2010 2:32 AM
>To: Pandita, Vikram; linux-omap@vger.kernel.org
>Subject: RE: [PATCH 0/3] Fix omap_type() function
>
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> owner@vger.kernel.org] On Behalf Of Pandita, Vikram
>> Sent: Saturday, July 10, 2010 12:39 PM
>> To: linux-omap@vger.kernel.org
>> Cc: Pandita, Vikram
>> Subject: [PATCH 0/3] Fix omap_type() function
>>
>> Aim was to get omap_type() function work on omap4.
>> In doing so, fixing an issue with is_sram_locked() function.
>>
>> Patches tested/verified on omap4 sdp.
>> Patches based of latest linus commit: e467e10
>>
>> Vikram Pandita (3):
>>   omap: sram: fix is_sram_locked check
>>   omap4: fix omap_type() function
>>   omap4: SRAM start and size change for EMU/HS devices
>>
>>  arch/arm/plat-omap/include/plat/omap44xx.h |    2 +-
>>  arch/arm/plat-omap/sram.c                  |   28 ++++++++++++++--------
>-
>In summary only fixing " is_sram_locked()" and adding the OMAP_2PLUS is
>enough.

All Valid comments. Thanks for the review.

>
>The control module needs to be fixed in right way because with different
>bases in wakeup and core control modules makes
>the current omap_control_read/write break on OMAP4. This is similar problem
>what we have on powerdomain base offsets and needs a proper handling.
>
>Fixing one base will break other register acceses

Yes I can now see how my patch 2 has broken the MMC part in: omap4_hsmmc1_before_set_reg(...)

Will post a saner V2 with:
Patch 1 -> your ACK

Patch 2 -> 
	will fix omap_type() in right way
	by not using omap_ctrl_readl() instead using right offset

Patch 3 -> just add OMAP_2PLUS change



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2010-07-10 13:59 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-10  7:08 [PATCH 0/3] Fix omap_type() function Vikram Pandita
2010-07-10  7:08 ` [PATCH 1/3] omap: sram: fix is_sram_locked check Vikram Pandita
2010-07-10  7:08   ` [PATCH 2/3] omap4: fix omap_type() function Vikram Pandita
2010-07-10  7:08     ` [PATCH 3/3] omap4: SRAM start and size change for EMU/HS devices Vikram Pandita
2010-07-10  7:25       ` Shilimkar, Santosh
2010-07-10  7:23     ` [PATCH 2/3] omap4: fix omap_type() function Shilimkar, Santosh
2010-07-10  7:27   ` [PATCH 1/3] omap: sram: fix is_sram_locked check Shilimkar, Santosh
2010-07-10  7:31 ` [PATCH 0/3] Fix omap_type() function Shilimkar, Santosh
2010-07-10 13:59   ` Pandita, Vikram

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.