* [PATCH]x86: Remove redundant clear for cpu_online_map.
@ 2010-03-30 5:41 Zhang, Xiantao
0 siblings, 0 replies; only message in thread
From: Zhang, Xiantao @ 2010-03-30 5:41 UTC (permalink / raw)
To: Keir Fraser; +Cc: Jiang, Yunhong, xen-devel
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
As Yunhong indicated, the second clear for cpu_online_map should be redundant, remove it.
x86: Remove redundant clear for cpu_online_map.
Remove it, maybe caused by accident diff operation.
Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
diff -r b60379dad533 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c Fri Feb 05 13:57:20 2010 +0000
+++ b/xen/arch/x86/smpboot.c Tue Mar 30 11:33:37 2010 +0800
@@ -1304,10 +1304,9 @@ int __cpu_disable(void)
remove_siblinginfo(cpu);
+ /* It's now safe to remove this processor from the online map */
cpu_clear(cpu, cpu_online_map);
fixup_irqs();
- /* It's now safe to remove this processor from the online map */
- cpu_clear(cpu, cpu_online_map);
cpu_disable_scheduler()
Xiantao
[-- Attachment #2: remove-redundant-clear-cpu-online-map.patch --]
[-- Type: application/octet-stream, Size: 650 bytes --]
x86: Remove redundant clear for cpu_online_map.
Remove it, maybe caused by accident diff operation.
Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
diff -r b60379dad533 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c Fri Feb 05 13:57:20 2010 +0000
+++ b/xen/arch/x86/smpboot.c Tue Mar 30 11:33:37 2010 +0800
@@ -1304,10 +1304,9 @@ int __cpu_disable(void)
remove_siblinginfo(cpu);
+ /* It's now safe to remove this processor from the online map */
cpu_clear(cpu, cpu_online_map);
fixup_irqs();
- /* It's now safe to remove this processor from the online map */
- cpu_clear(cpu, cpu_online_map);
cpu_disable_scheduler();
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-30 5:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-30 5:41 [PATCH]x86: Remove redundant clear for cpu_online_map Zhang, Xiantao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.