From: "Thibaut VARÈNE" <hacks+kernel@slashdirt.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kalle Valo" <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, "Petr Štetiar" <ynezz@true.cz>,
"Clemens Hopfer" <openwrt@wireloss.net>
Subject: Re: [PATCH] ath9k: fix QCA9561 PA bias
Date: Sun, 17 Apr 2022 16:46:43 +0200 [thread overview]
Message-ID: <EC4F8380-4725-441D-B3FF-8CD7048F2236@slashdirt.org> (raw)
In-Reply-To: <91c58969-c60e-2f41-00ac-737786d435ae@nbd.name>
> Le 16 avr. 2022 à 20:39, Felix Fietkau <nbd@nbd.name> a écrit :
> The patch looks wrong to me. I'm pretty sure that AR_CH0_TOP2 is the correct register, the definition has an explicit check for 9561 as well.
> I believe this patch works by accident because it avoids writing a wrong value to that register.
> The value written to that register is wrong, because while the mask definition AR_CH0_TOP2_XPABIASLVL uses a different value for 9561, the shift definition AR_CH0_TOP2_XPABIASLVL_S is hardcoded to 12, which is wrong for 9561.
> Please try adjusting it to this:
> #define AR_CH0_TOP2_XPABIASLVL_S (AR_SREV_9561(ah) ? 9 : 12)
This works, thanks. I’ll submit a v2 now.
Thibaut
next prev parent reply other threads:[~2022-04-17 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 10:44 [PATCH] ath9k: fix QCA9561 PA bias Thibaut VARÈNE
2022-04-16 18:39 ` Felix Fietkau
2022-04-17 14:46 ` Thibaut VARÈNE [this message]
2022-04-17 14:51 ` [PATCH v2] ath9k: fix QCA9561 PA bias level Thibaut VARÈNE
2022-04-17 17:02 ` Felix Fietkau
2022-04-17 19:00 ` Toke Høiland-Jørgensen
2022-04-23 9:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EC4F8380-4725-441D-B3FF-8CD7048F2236@slashdirt.org \
--to=hacks+kernel@slashdirt.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=openwrt@wireloss.net \
--cc=toke@toke.dk \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.