* [Fuego] [PATCH] OpenSSL: change the compile and log compare args
@ 2017-12-04 6:12 Liu Wenlong
2017-12-13 23:59 ` Bird, Timothy
0 siblings, 1 reply; 4+ messages in thread
From: Liu Wenlong @ 2017-12-04 6:12 UTC (permalink / raw)
To: fuego
What have been changed:
1. changed the compile args and fixed some build fail issue
e.g. failed to configure the compile env as below:
CROSS_COMPILE= aarch64-agl-linux-
CC= $(CROSS_COMPILE)aarch64-agl-linux-gcc -march=armv8-a --sysroot=/opt/poky-agl/m3ulcb/sysroots/aarch64-agl-linux
2. changed the found times of "pass|ok|skip" pattern.
Signed-off-by: Liu Wenlong <liuwl.fnst@cn.fujitsu.com>
---
engine/tests/Functional.OpenSSL/fuego_test.sh | 4 +-
.../tests/Functional.OpenSSL/openssl-0.9.8j_n.log | 86 ----------
.../tests/Functional.OpenSSL/openssl-0.9.8j_p.log | 176 ---------------------
.../tests/Functional.OpenSSL/openssl-1.0.0t_p.log | 169 ++++++++++++++++++++
engine/tests/OpenSSL/openssl.sh | 6 +-
5 files changed, 175 insertions(+), 266 deletions(-)
delete mode 100644 engine/tests/Functional.OpenSSL/openssl-0.9.8j_n.log
delete mode 100644 engine/tests/Functional.OpenSSL/openssl-0.9.8j_p.log
create mode 100644 engine/tests/Functional.OpenSSL/openssl-1.0.0t_p.log
diff --git a/engine/tests/Functional.OpenSSL/fuego_test.sh b/engine/tests/Functional.OpenSSL/fuego_test.sh
index f8f35d3..74ea914 100755
--- a/engine/tests/Functional.OpenSSL/fuego_test.sh
+++ b/engine/tests/Functional.OpenSSL/fuego_test.sh
@@ -8,10 +8,8 @@ function test_deploy {
function test_processing {
P_CRIT="passed|ok"
- N_CRIT="skip"
- log_compare "$TESTDIR" "176" "${P_CRIT}" "p"
- log_compare "$TESTDIR" "86" "${N_CRIT}" "n"
+ log_compare "$TESTDIR" "169" "${P_CRIT}" "p"
}
function test_run {
diff --git a/engine/tests/Functional.OpenSSL/openssl-0.9.8j_n.log b/engine/tests/Functional.OpenSSL/openssl-0.9.8j_n.log
deleted file mode 100644
index 8eb6d2c..0000000
--- a/engine/tests/Functional.OpenSSL/openssl-0.9.8j_n.log
+++ /dev/null
@@ -1,86 +0,0 @@
-Cipher disabled, skipping CAMELLIA-128-ECB
-Cipher disabled, skipping CAMELLIA-192-ECB
-Cipher disabled, skipping CAMELLIA-256-ECB
-Cipher disabled, skipping CAMELLIA-128-ECB
-Cipher disabled, skipping CAMELLIA-192-ECB
-Cipher disabled, skipping CAMELLIA-256-ECB
-Cipher disabled, skipping CAMELLIA-128-ECB
-Cipher disabled, skipping CAMELLIA-128-ECB
-Cipher disabled, skipping CAMELLIA-128-ECB
-Cipher disabled, skipping CAMELLIA-128-ECB
-Cipher disabled, skipping CAMELLIA-192-ECB
-Cipher disabled, skipping CAMELLIA-192-ECB
-Cipher disabled, skipping CAMELLIA-192-ECB
-Cipher disabled, skipping CAMELLIA-192-ECB
-Cipher disabled, skipping CAMELLIA-256-ECB
-Cipher disabled, skipping CAMELLIA-256-ECB
-Cipher disabled, skipping CAMELLIA-256-ECB
-Cipher disabled, skipping CAMELLIA-256-ECB
-Cipher disabled, skipping CAMELLIA-128-CBC
-Cipher disabled, skipping CAMELLIA-128-CBC
-Cipher disabled, skipping CAMELLIA-128-CBC
-Cipher disabled, skipping CAMELLIA-128-CBC
-Cipher disabled, skipping CAMELLIA-192-CBC
-Cipher disabled, skipping CAMELLIA-192-CBC
-Cipher disabled, skipping CAMELLIA-192-CBC
-Cipher disabled, skipping CAMELLIA-192-CBC
-Cipher disabled, skipping CAMELLIA-256-CBC
-Cipher disabled, skipping CAMELLIA-256-CBC
-Cipher disabled, skipping CAMELLIA-256-CBC
-Cipher disabled, skipping CAMELLIA-256-CBC
-Cipher disabled, skipping CAMELLIA-128-CFB
-Cipher disabled, skipping CAMELLIA-128-CFB
-Cipher disabled, skipping CAMELLIA-128-CFB
-Cipher disabled, skipping CAMELLIA-128-CFB
-Cipher disabled, skipping CAMELLIA-128-CFB
-Cipher disabled, skipping CAMELLIA-128-CFB
-Cipher disabled, skipping CAMELLIA-128-CFB
-Cipher disabled, skipping CAMELLIA-128-CFB
-Cipher disabled, skipping CAMELLIA-192-CFB
-Cipher disabled, skipping CAMELLIA-192-CFB
-Cipher disabled, skipping CAMELLIA-192-CFB
-Cipher disabled, skipping CAMELLIA-192-CFB
-Cipher disabled, skipping CAMELLIA-192-CFB
-Cipher disabled, skipping CAMELLIA-192-CFB
-Cipher disabled, skipping CAMELLIA-192-CFB
-Cipher disabled, skipping CAMELLIA-192-CFB
-Cipher disabled, skipping CAMELLIA-256-CFB
-Cipher disabled, skipping CAMELLIA-256-CFB
-Cipher disabled, skipping CAMELLIA-256-CFB
-Cipher disabled, skipping CAMELLIA-256-CFB
-Cipher disabled, skipping CAMELLIA-256-CFB
-Cipher disabled, skipping CAMELLIA-256-CFB
-Cipher disabled, skipping CAMELLIA-256-CFB
-Cipher disabled, skipping CAMELLIA-256-CFB
-Cipher disabled, skipping CAMELLIA-128-OFB
-Cipher disabled, skipping CAMELLIA-128-OFB
-Cipher disabled, skipping CAMELLIA-128-OFB
-Cipher disabled, skipping CAMELLIA-128-OFB
-Cipher disabled, skipping CAMELLIA-128-OFB
-Cipher disabled, skipping CAMELLIA-128-OFB
-Cipher disabled, skipping CAMELLIA-128-OFB
-Cipher disabled, skipping CAMELLIA-128-OFB
-Cipher disabled, skipping CAMELLIA-192-OFB
-Cipher disabled, skipping CAMELLIA-192-OFB
-Cipher disabled, skipping CAMELLIA-192-OFB
-Cipher disabled, skipping CAMELLIA-192-OFB
-Cipher disabled, skipping CAMELLIA-192-OFB
-Cipher disabled, skipping CAMELLIA-192-OFB
-Cipher disabled, skipping CAMELLIA-192-OFB
-Cipher disabled, skipping CAMELLIA-192-OFB
-Cipher disabled, skipping CAMELLIA-256-OFB
-Cipher disabled, skipping CAMELLIA-256-OFB
-Cipher disabled, skipping CAMELLIA-256-OFB
-Cipher disabled, skipping CAMELLIA-256-OFB
-Cipher disabled, skipping CAMELLIA-256-OFB
-Cipher disabled, skipping CAMELLIA-256-OFB
-Cipher disabled, skipping CAMELLIA-256-OFB
-Cipher disabled, skipping CAMELLIA-256-OFB
-Cipher disabled, skipping SEED-ECB
-Cipher disabled, skipping SEED-ECB
-Cipher disabled, skipping SEED-ECB
-Cipher disabled, skipping SEED-ECB
-Cipher disabled, skipping SEED-ECB
-Cipher disabled, skipping SEED-ECB
-Cipher disabled, skipping SEED-ECB
-Cipher disabled, skipping SEED-ECB
diff --git a/engine/tests/Functional.OpenSSL/openssl-0.9.8j_p.log b/engine/tests/Functional.OpenSSL/openssl-0.9.8j_p.log
deleted file mode 100644
index 8ee90f6..0000000
--- a/engine/tests/Functional.OpenSSL/openssl-0.9.8j_p.log
+++ /dev/null
@@ -1,176 +0,0 @@
-ecb cast5 ok
-This test will take some time....123456789ABCDEF ok
-Testing key generation with NIST Prime-Curve P-192 .... ok
-Testing key generation with NIST Prime-Curve P-224 .... ok
-Testing key generation with NIST Prime-Curve P-256 .... ok
-Testing key generation with NIST Prime-Curve P-384 .... ok
-Testing key generation with NIST Prime-Curve P-521 .... ok
-Testing key generation with NIST Binary-Curve K-163 .... ok
-Testing key generation with NIST Binary-Curve B-163 .... ok
-Testing key generation with NIST Binary-Curve K-233 .... ok
-Testing key generation with NIST Binary-Curve B-233 .... ok
-Testing key generation with NIST Binary-Curve K-283 .... ok
-Testing key generation with NIST Binary-Curve B-283 .... ok
-Testing key generation with NIST Binary-Curve K-409 .... ok
-Testing key generation with NIST Binary-Curve B-409 .... ok
-Testing key generation with NIST Binary-Curve K-571 .... ok
-Testing key generation with NIST Binary-Curve B-571 .... ok
-testing prime192v1: .... ok
-testing prime239v1: .... ok
-testing c2tnb191v1: .... ok
-testing c2tnb239v1: .... ok
-secp160k1: ....... ok
-secp160r1: ....... ok
-secp160r2: ....... ok
-secp192k1: ....... ok
-secp224k1: ....... ok
-secp224r1: ....... ok
-secp256k1: ....... ok
-secp384r1: ....... ok
-secp521r1: ....... ok
-prime192v1: ....... ok
-prime192v2: ....... ok
-prime192v3: ....... ok
-prime239v1: ....... ok
-prime239v2: ....... ok
-prime239v3: ....... ok
-prime256v1: ....... ok
-sect163k1: ....... ok
-sect163r1: ....... ok
-sect163r2: ....... ok
-sect193r1: ....... ok
-sect193r2: ....... ok
-sect233k1: ....... ok
-sect233r1: ....... ok
-sect239k1: ....... ok
-sect283k1: ....... ok
-sect283r1: ....... ok
-sect409k1: ....... ok
-sect409r1: ....... ok
-sect571k1: ....... ok
-sect571r1: ....... ok
-c2pnb163v1: ....... ok
-c2pnb163v2: ....... ok
-c2pnb163v3: ....... ok
-c2pnb176v1: ....... ok
-c2tnb191v1: ....... ok
-c2tnb191v2: ....... ok
-c2tnb191v3: ....... ok
-c2pnb208w1: ....... ok
-c2tnb239v1: ....... ok
-c2tnb239v2: ....... ok
-c2tnb239v3: ....... ok
-c2pnb272w1: ....... ok
-c2pnb304w1: ....... ok
-c2tnb359v1: ....... ok
-c2pnb368w1: ....... ok
-c2tnb431r1: ....... ok
-wap-wsg-idm-ecid-wtls3: ....... ok
-wap-wsg-idm-ecid-wtls5: ....... ok
-wap-wsg-idm-ecid-wtls7: ....... ok
-wap-wsg-idm-ecid-wtls9: ....... ok
-wap-wsg-idm-ecid-wtls10: ....... ok
-wap-wsg-idm-ecid-wtls11: ....... ok
-wap-wsg-idm-ecid-wtls12: ....... ok
-ECDSA test passed
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-combined multiplication ..... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-verify degree ... ok
-verify group order .... ok
-combined multiplication ..... ok
-testing internal curves: ................................................................... ok
-test 0 ok
-test 1 ok
-test 2 ok
-test 3 ok
-ecb idea ok
-cbc idea ok
-cfb64 idea ok
-test 1 ok
-test 2 ok
-test 3 ok
-test 4 ok
-test 5 ok
-test 6 ok
-test 7 ok
-test 1 ok
-test 2 ok
-test 3 ok
-test 4 ok
-test 5 ok
-test 6 ok
-test 7 ok
-test 1 ok
-test 2 ok
-test 3 ok
-test 4 ok
-test 5 ok
-test 6 ok
-test 7 ok
-ecb RC2 ok
-test 0 ok
-test 1 ok
-test 2 ok
-test 3 ok
-test 4 ok
-test 5 ok
-bulk test ok
-test 1 ok
-test 2 ok
-test 3 ok
-test 4 ok
-test 5 ok
-test 6 ok
-test 7 ok
-test 8 ok
-PKCS #1 v1.5 encryption/decryption ok
-OAEP encryption/decryption ok
-PKCS #1 v1.5 encryption/decryption ok
-OAEP encryption/decryption ok
-PKCS #1 v1.5 encryption/decryption ok
-OAEP encryption/decryption ok
-PKCS #1 v1.5 encryption/decryption ok
-OAEP encryption/decryption ok
-PKCS #1 v1.5 encryption/decryption ok
-OAEP encryption/decryption ok
-PKCS #1 v1.5 encryption/decryption ok
-OAEP encryption/decryption ok
-test 1 ok
-test 2 ok
-test 3 ok
-Testing SHA-256 ... passed.
-Testing SHA-224 ... passed.
-Testing SHA-512 ... passed.
-Testing SHA-384 ... passed.
-test 1 ok
-test 2 ok
-test 3 ok
diff --git a/engine/tests/Functional.OpenSSL/openssl-1.0.0t_p.log b/engine/tests/Functional.OpenSSL/openssl-1.0.0t_p.log
new file mode 100644
index 0000000..5f1b82e
--- /dev/null
+++ b/engine/tests/Functional.OpenSSL/openssl-1.0.0t_p.log
@@ -0,0 +1,169 @@
+ecb cast5 ok
+This test will take some time....123456789ABCDEF ok
+Testing key generation with NIST Prime-Curve P-192 .... ok
+Testing key generation with NIST Prime-Curve P-224 .... ok
+Testing key generation with NIST Prime-Curve P-256 .... ok
+Testing key generation with NIST Prime-Curve P-384 .... ok
+Testing key generation with NIST Prime-Curve P-521 .... ok
+Testing key generation with NIST Binary-Curve K-163 .... ok
+Testing key generation with NIST Binary-Curve B-163 .... ok
+Testing key generation with NIST Binary-Curve K-233 .... ok
+Testing key generation with NIST Binary-Curve B-233 .... ok
+Testing key generation with NIST Binary-Curve K-283 .... ok
+Testing key generation with NIST Binary-Curve B-283 .... ok
+Testing key generation with NIST Binary-Curve K-409 .... ok
+Testing key generation with NIST Binary-Curve B-409 .... ok
+Testing key generation with NIST Binary-Curve K-571 .... ok
+Testing key generation with NIST Binary-Curve B-571 .... ok
+testing prime192v1: .... ok
+testing prime239v1: .... ok
+testing c2tnb191v1: .... ok
+testing c2tnb239v1: .... ok
+secp160k1: ........ ok
+secp160r1: ........ ok
+secp160r2: ........ ok
+secp192k1: ........ ok
+secp224k1: ........ ok
+secp224r1: ........ ok
+secp256k1: ........ ok
+secp384r1: ........ ok
+secp521r1: ........ ok
+prime192v1: ........ ok
+prime192v2: ........ ok
+prime192v3: ........ ok
+prime239v1: ........ ok
+prime239v2: ........ ok
+prime239v3: ........ ok
+prime256v1: ........ ok
+sect163k1: ........ ok
+sect163r1: ........ ok
+sect163r2: ........ ok
+sect193r1: ........ ok
+sect193r2: ........ ok
+sect233k1: ........ ok
+sect233r1: ........ ok
+sect239k1: ........ ok
+sect283k1: ........ ok
+sect283r1: ........ ok
+sect409k1: ........ ok
+sect409r1: ........ ok
+sect571k1: ........ ok
+sect571r1: ........ ok
+c2pnb163v1: ........ ok
+c2pnb163v2: ........ ok
+c2pnb163v3: ........ ok
+c2pnb176v1: ........ ok
+c2tnb191v1: ........ ok
+c2tnb191v2: ........ ok
+c2tnb191v3: ........ ok
+c2pnb208w1: ........ ok
+c2tnb239v1: ........ ok
+c2tnb239v2: ........ ok
+c2tnb239v3: ........ ok
+c2pnb272w1: ........ ok
+c2pnb304w1: ........ ok
+c2tnb359v1: ........ ok
+c2pnb368w1: ........ ok
+c2tnb431r1: ........ ok
+wap-wsg-idm-ecid-wtls3: ........ ok
+wap-wsg-idm-ecid-wtls5: ........ ok
+wap-wsg-idm-ecid-wtls7: ........ ok
+wap-wsg-idm-ecid-wtls9: ........ ok
+wap-wsg-idm-ecid-wtls10: ........ ok
+wap-wsg-idm-ecid-wtls11: ........ ok
+wap-wsg-idm-ecid-wtls12: ........ ok
+ECDSA test passed
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+combined multiplication ..... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+verify degree ... ok
+verify group order .... ok
+combined multiplication ..... ok
+testing internal curves: ................................................................... ok
+test 0 ok
+test 1 ok
+test 2 ok
+test 3 ok
+ecb idea ok
+cbc idea ok
+cfb64 idea ok
+test 1 ok
+test 2 ok
+test 3 ok
+test 4 ok
+test 5 ok
+test 6 ok
+test 7 ok
+test 1 ok
+test 2 ok
+test 3 ok
+test 4 ok
+test 5 ok
+test 6 ok
+test 7 ok
+ecb RC2 ok
+test 0 ok
+test 1 ok
+test 2 ok
+test 3 ok
+test 4 ok
+test 5 ok
+bulk test ok
+test 1 ok
+test 2 ok
+test 3 ok
+test 4 ok
+test 5 ok
+test 6 ok
+test 7 ok
+test 8 ok
+PKCS #1 v1.5 encryption/decryption ok
+OAEP encryption/decryption ok
+PKCS #1 v1.5 encryption/decryption ok
+OAEP encryption/decryption ok
+PKCS #1 v1.5 encryption/decryption ok
+OAEP encryption/decryption ok
+PKCS #1 v1.5 encryption/decryption ok
+OAEP encryption/decryption ok
+PKCS #1 v1.5 encryption/decryption ok
+OAEP encryption/decryption ok
+PKCS #1 v1.5 encryption/decryption ok
+OAEP encryption/decryption ok
+test 1 ok
+test 2 ok
+test 3 ok
+Testing SHA-256 ... passed.
+Testing SHA-224 ... passed.
+Testing SHA-512 ... passed.
+Testing SHA-384 ... passed.
+test 1 ok
+test 2 ok
+test 3 ok
diff --git a/engine/tests/OpenSSL/openssl.sh b/engine/tests/OpenSSL/openssl.sh
index ec062c7..e1b7237 100755
--- a/engine/tests/OpenSSL/openssl.sh
+++ b/engine/tests/OpenSSL/openssl.sh
@@ -8,6 +8,11 @@ function test_pre_check {
function test_build {
SUFFIX=" --sysroot=${SDKROOT}"
+ ./Configure shared zlib-dynamic os/compiler:arm-none-linux-gnueabi-
+ if [ -n "${CROSS_COMPILE}" ]; then
+ sed -i -e "s#(CROSS_COMPILE).*gcc#(CROSS_COMPILE)gcc#" Makefile
+ fi
+
sed -i -e "s#CC= cc#CC= ${CC}#g" -e "s#AR=ar#AR= ${AR}#g" Makefile
sed -i -e "s#CFLAGS= #CFLAGS= ${SUFFIX}#g" Makefile
sed -i -e "s#ARD=ar#ARD= ${AR}#g" -e "s#RANLIB= /usr/bin/ranlib#RANLIB= ${RANLIB}#g" -e "s#CFLAG= #CFLAG= ${SUFFIX} #g" Makefile
@@ -50,5 +55,4 @@ function test_build {
../util/shlib_wrap.sh ./sha512t
../util/shlib_wrap.sh ./shatest
../util/shlib_wrap.sh ./ssltest' > run-tests.sh
- rm test/fips_aes_data
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Fuego] [PATCH] OpenSSL: change the compile and log compare args
2017-12-04 6:12 [Fuego] [PATCH] OpenSSL: change the compile and log compare args Liu Wenlong
@ 2017-12-13 23:59 ` Bird, Timothy
2017-12-14 8:21 ` Liu, Wenlong
0 siblings, 1 reply; 4+ messages in thread
From: Bird, Timothy @ 2017-12-13 23:59 UTC (permalink / raw)
To: Liu Wenlong, fuego
> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Liu Wenlong
> Sent: Sunday, December 03, 2017 10:12 PM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH] OpenSSL: change the compile and log compare args
>
> What have been changed:
> 1. changed the compile args and fixed some build fail issue
> e.g. failed to configure the compile env as below:
> CROSS_COMPILE= aarch64-agl-linux-
> CC= $(CROSS_COMPILE)aarch64-agl-linux-gcc -march=armv8-a --
> sysroot=/opt/poky-agl/m3ulcb/sysroots/aarch64-agl-linux
> 2. changed the found times of "pass|ok|skip" pattern.
>
> Signed-off-by: Liu Wenlong <liuwl.fnst@cn.fujitsu.com>
.. [ lots of patch omitted]....
> diff --git a/engine/tests/OpenSSL/openssl.sh
> b/engine/tests/OpenSSL/openssl.sh
> index ec062c7..e1b7237 100755
> --- a/engine/tests/OpenSSL/openssl.sh
> +++ b/engine/tests/OpenSSL/openssl.sh
> @@ -8,6 +8,11 @@ function test_pre_check {
> function test_build {
> SUFFIX=" --sysroot=${SDKROOT}"
>
> + ./Configure shared zlib-dynamic os/compiler:arm-none-linux-gnueabi-
I don't see how this would work for non-ARM builds.
Can you please explain this change?
Does openssl now require running ./Configure?
> + if [ -n "${CROSS_COMPILE}" ]; then
> + sed -i -e "s#(CROSS_COMPILE).*gcc#(CROSS_COMPILE)gcc#" Makefile
> + fi
Can you please explain this change as well?
I don't see any instances of the pattern "CROSS_COMPILE.*gcc" in the openssl-1.0.0t Makefile.
-- Tim
> +
> sed -i -e "s#CC= cc#CC= ${CC}#g" -e "s#AR=ar#AR= ${AR}#g" Makefile
> sed -i -e "s#CFLAGS= #CFLAGS= ${SUFFIX}#g" Makefile
> sed -i -e "s#ARD=ar#ARD= ${AR}#g" -e "s#RANLIB=
> /usr/bin/ranlib#RANLIB= ${RANLIB}#g" -e "s#CFLAG= #CFLAG= ${SUFFIX} #g"
> Makefile
> @@ -50,5 +55,4 @@ function test_build {
> ../util/shlib_wrap.sh ./sha512t
> ../util/shlib_wrap.sh ./shatest
> ../util/shlib_wrap.sh ./ssltest' > run-tests.sh
> - rm test/fips_aes_data
> }
> --
> 2.7.4
>
>
>
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Fuego] [PATCH] OpenSSL: change the compile and log compare args
2017-12-13 23:59 ` Bird, Timothy
@ 2017-12-14 8:21 ` Liu, Wenlong
2017-12-15 2:35 ` Bird, Timothy
0 siblings, 1 reply; 4+ messages in thread
From: Liu, Wenlong @ 2017-12-14 8:21 UTC (permalink / raw)
To: Bird, Timothy, fuego
> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird@sony.com]
> Sent: Thursday, December 14, 2017 7:59 AM
> To: Liu, Wenlong/刘 文龙; fuego@lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH] OpenSSL: change the compile and log compare
> args
>
> > -----Original Message-----
> > From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> > bounces@lists.linuxfoundation.org] On Behalf Of Liu Wenlong
> > Sent: Sunday, December 03, 2017 10:12 PM
> > To: fuego@lists.linuxfoundation.org
> > Subject: [Fuego] [PATCH] OpenSSL: change the compile and log compare
> > args
> >
> > What have been changed:
> > 1. changed the compile args and fixed some build fail issue
> > e.g. failed to configure the compile env as below:
> > CROSS_COMPILE= aarch64-agl-linux-
> > CC= $(CROSS_COMPILE)aarch64-agl-linux-gcc -march=armv8-a --
> > sysroot=/opt/poky-agl/m3ulcb/sysroots/aarch64-agl-linux
> > 2. changed the found times of "pass|ok|skip" pattern.
> >
> > Signed-off-by: Liu Wenlong <liuwl.fnst@cn.fujitsu.com>
> .. [ lots of patch omitted]....
>
> > diff --git a/engine/tests/OpenSSL/openssl.sh
> > b/engine/tests/OpenSSL/openssl.sh index ec062c7..e1b7237 100755
> > --- a/engine/tests/OpenSSL/openssl.sh
> > +++ b/engine/tests/OpenSSL/openssl.sh
> > @@ -8,6 +8,11 @@ function test_pre_check { function test_build {
> > SUFFIX=" --sysroot=${SDKROOT}"
> >
> > + ./Configure shared zlib-dynamic
> > + os/compiler:arm-none-linux-gnueabi-
> I don't see how this would work for non-ARM builds.
> Can you please explain this change?
>
> Does openssl now require running ./Configure?
According to the installation guidance, if we are cross-compiling for another platform,
we should use "./Configure" to configure OpenSSL manually.
"os/compiler" seems to be useless for our cross-compile, but it must be specified.
I have already tested it on the arm64 and x86_64 platform. (Maybe need more test with other platform and toolchain)
> > + if [ -n "${CROSS_COMPILE}" ]; then
> > + sed -i -e "s#(CROSS_COMPILE).*gcc#(CROSS_COMPILE)gcc#"
> Makefile
> > + fi
> Can you please explain this change as well?
> I don't see any instances of the pattern "CROSS_COMPILE.*gcc" in the
> openssl-1.0.0t Makefile.
Yes, as is said in the commit message, there will be the following situation in the Makefile.
...
CROSS_COMPILE= aarch64-agl-linux-
CC= $(CROSS_COMPILE)aarch64-agl-linux-gcc -march=armv8-a --sysroot=/opt/poky-agl/m3ulcb/sysroots/aarch64-agl-linux
...
Then, CC will be "CC=aarch64-agl-linux-aarch64-agl-linux-gcc ...", which is not correct.
> -- Tim
>
>
> > +
> > sed -i -e "s#CC= cc#CC= ${CC}#g" -e "s#AR=ar#AR= ${AR}#g" Makefile
> > sed -i -e "s#CFLAGS= #CFLAGS= ${SUFFIX}#g" Makefile
> > sed -i -e "s#ARD=ar#ARD= ${AR}#g" -e "s#RANLIB=
> > /usr/bin/ranlib#RANLIB= ${RANLIB}#g" -e "s#CFLAG= #CFLAG= ${SUFFIX} #g"
> > Makefile
> > @@ -50,5 +55,4 @@ function test_build {
> > ../util/shlib_wrap.sh ./sha512t
> > ../util/shlib_wrap.sh ./shatest
> > ../util/shlib_wrap.sh ./ssltest' > run-tests.sh
> > - rm test/fips_aes_data
> > }
> > --
> > 2.7.4
> >
> >
> >
> > _______________________________________________
> > Fuego mailing list
> > Fuego@lists.linuxfoundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/fuego
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Fuego] [PATCH] OpenSSL: change the compile and log compare args
2017-12-14 8:21 ` Liu, Wenlong
@ 2017-12-15 2:35 ` Bird, Timothy
0 siblings, 0 replies; 4+ messages in thread
From: Bird, Timothy @ 2017-12-15 2:35 UTC (permalink / raw)
To: Liu, Wenlong, fuego
See comments below.
> -----Original Message-----
> From: Liu, Wenlong [mailto:liuwl.fnst@cn.fujitsu.com]
> Sent: Thursday, December 14, 2017 12:21 AM
> To: Bird, Timothy <Tim.Bird@sony.com>; fuego@lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH] OpenSSL: change the compile and log compare
> args
>
> > -----Original Message-----
> > From: Bird, Timothy [mailto:Tim.Bird@sony.com]
> > Sent: Thursday, December 14, 2017 7:59 AM
> > To: Liu, Wenlong/刘 文龙; fuego@lists.linuxfoundation.org
> > Subject: RE: [Fuego] [PATCH] OpenSSL: change the compile and log
> compare
> > args
> >
> > > -----Original Message-----
> > > From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> > > bounces@lists.linuxfoundation.org] On Behalf Of Liu Wenlong
> > > Sent: Sunday, December 03, 2017 10:12 PM
> > > To: fuego@lists.linuxfoundation.org
> > > Subject: [Fuego] [PATCH] OpenSSL: change the compile and log compare
> > > args
> > >
> > > What have been changed:
> > > 1. changed the compile args and fixed some build fail issue
> > > e.g. failed to configure the compile env as below:
> > > CROSS_COMPILE= aarch64-agl-linux-
> > > CC= $(CROSS_COMPILE)aarch64-agl-linux-gcc -march=armv8-a --
> > > sysroot=/opt/poky-agl/m3ulcb/sysroots/aarch64-agl-linux
> > > 2. changed the found times of "pass|ok|skip" pattern.
> > >
> > > Signed-off-by: Liu Wenlong <liuwl.fnst@cn.fujitsu.com>
> > .. [ lots of patch omitted]....
> >
> > > diff --git a/engine/tests/OpenSSL/openssl.sh
> > > b/engine/tests/OpenSSL/openssl.sh index ec062c7..e1b7237 100755
> > > --- a/engine/tests/OpenSSL/openssl.sh
> > > +++ b/engine/tests/OpenSSL/openssl.sh
> > > @@ -8,6 +8,11 @@ function test_pre_check { function test_build {
> > > SUFFIX=" --sysroot=${SDKROOT}"
> > >
> > > + ./Configure shared zlib-dynamic
> > > + os/compiler:arm-none-linux-gnueabi-
> > I don't see how this would work for non-ARM builds.
> > Can you please explain this change?
> >
> > Does openssl now require running ./Configure?
>
> According to the installation guidance, if we are cross-compiling for another
> platform,
> we should use "./Configure" to configure OpenSSL manually.
>
> "os/compiler" seems to be useless for our cross-compile, but it must be
> specified.
> I have already tested it on the arm64 and x86_64 platform. (Maybe need
> more test with other platform and toolchain)
>
> > > + if [ -n "${CROSS_COMPILE}" ]; then
> > > + sed -i -e "s#(CROSS_COMPILE).*gcc#(CROSS_COMPILE)gcc#"
> > Makefile
> > > + fi
> > Can you please explain this change as well?
> > I don't see any instances of the pattern "CROSS_COMPILE.*gcc" in the
> > openssl-1.0.0t Makefile.
>
> Yes, as is said in the commit message, there will be the following situation in
> the Makefile.
> ...
> CROSS_COMPILE= aarch64-agl-linux-
> CC= $(CROSS_COMPILE)aarch64-agl-linux-gcc -march=armv8-a --
> sysroot=/opt/poky-agl/m3ulcb/sysroots/aarch64-agl-linux
> ...
>
> Then, CC will be "CC=aarch64-agl-linux-aarch64-agl-linux-gcc ...", which is not
> correct.
OK - I accepted most of this. I was also able to get my x86_64 and aarch64 platforms
working. I still have problems on my emdebian_armhf platform, but I think that's
a different issue. I did refactor the changes in openssl.sh a bit (but not much).
This is applied and pushed in my master branch.
Sorry - but while moving stuff around, somehow I lost the pn logs.
Can you please re-send them as a separate patch or pull request?
Thanks,
-- Tim
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-15 2:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-04 6:12 [Fuego] [PATCH] OpenSSL: change the compile and log compare args Liu Wenlong
2017-12-13 23:59 ` Bird, Timothy
2017-12-14 8:21 ` Liu, Wenlong
2017-12-15 2:35 ` Bird, Timothy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.