[Fuego] [PATCH] iperf3: show png performance graph even on failure

[Fuego] [PATCH] iperf3: show png performance graph even on failure

[Daniel Sangorrin]

When the failure is caused by a strict criteria it may
be interesting to actually see the performance graph.

If the reason for failure is different and the png could
not be created the link may not work at all.

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 engine/tests/Benchmark.iperf3/spec.json | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/engine/tests/Benchmark.iperf3/spec.json b/engine/tests/Benchmark.iperf3/spec.json
index 95d02c2..29a1700 100644
--- a/engine/tests/Benchmark.iperf3/spec.json
+++ b/engine/tests/Benchmark.iperf3/spec.json
@@ -3,15 +3,18 @@
     "specs": {
         "default": {
             "client_params": "-O 4 -t 64",
-            "extra_success_links": {"png": "iperf3.png"}
+            "extra_success_links": {"png": "iperf3.png"},
+            "extra_fail_links": {"png": "iperf3.png"}
         },
         "zerocopy": {
             "client_params": "-O 4 -t 64 -Z",
-            "extra_success_links": {"png": "iperf3.png"}
+            "extra_success_links": {"png": "iperf3.png"},
+            "extra_fail_links": {"png": "iperf3.png"}
         },
         "udp": {
             "client_params": "-t 60 -u -b 400M",
-            "extra_success_links": {"png": "iperf3.png"}
+            "extra_success_links": {"png": "iperf3.png"},
+            "extra_fail_links": {"png": "iperf3.png"}
         }
     }
 }
-- 
2.7.4

Re: [Fuego] [PATCH] iperf3: show png performance graph even on failure

[Tim.Bird]

Looks good. Applied.

Thanks,
 -- Tim

> -----Original Message-----
> From: Daniel Sangorrin
> 
> When the failure is caused by a strict criteria it may
> be interesting to actually see the performance graph.
> 
> If the reason for failure is different and the png could
> not be created the link may not work at all.
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  engine/tests/Benchmark.iperf3/spec.json | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/engine/tests/Benchmark.iperf3/spec.json
> b/engine/tests/Benchmark.iperf3/spec.json
> index 95d02c2..29a1700 100644
> --- a/engine/tests/Benchmark.iperf3/spec.json
> +++ b/engine/tests/Benchmark.iperf3/spec.json
> @@ -3,15 +3,18 @@
>      "specs": {
>          "default": {
>              "client_params": "-O 4 -t 64",
> -            "extra_success_links": {"png": "iperf3.png"}
> +            "extra_success_links": {"png": "iperf3.png"},
> +            "extra_fail_links": {"png": "iperf3.png"}
>          },
>          "zerocopy": {
>              "client_params": "-O 4 -t 64 -Z",
> -            "extra_success_links": {"png": "iperf3.png"}
> +            "extra_success_links": {"png": "iperf3.png"},
> +            "extra_fail_links": {"png": "iperf3.png"}
>          },
>          "udp": {
>              "client_params": "-t 60 -u -b 400M",
> -            "extra_success_links": {"png": "iperf3.png"}
> +            "extra_success_links": {"png": "iperf3.png"},
> +            "extra_fail_links": {"png": "iperf3.png"}
>          }
>      }
>  }
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego