[Fuego] kernel_build dependencies

[Fuego] kernel_build dependencies

[Daniel Sangorrin]

Hi Tim,

This is a patch for the Docker side. I have added the dependencies
on the test.yaml already, and I added is_on_sdk to fuego_test.sh so
you may prefer not to accept this patch.

[PATCH] Dockerfile: sdk dependencies for building a x86_64 kernel

Thanks,
Daniel

[Fuego] [PATCH] Dockerfile: sdk dependencies for building a x86_64 kernel

[Daniel Sangorrin]

Note, I have added the dependencies to the kernel_build test's
test.yaml. In the future, it would be nice to install them
directly from ftc. At the moment that is not possible so I add
them here, but I'm also adding is_on_sdk checks to the test
so even if this patch is not accepted the user should be
able to understand the error log.

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 Dockerfile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Dockerfile b/Dockerfile
index 4dcf505..2c0b17e 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -31,7 +31,8 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get -yV install \
 	inotify-tools g++ bzip2 bc libaio-dev gettext pkg-config libglib2.0-dev \
 	time python-pip python-xmltodict at minicom lzop bsdmainutils u-boot-tools \
 	mc netcat lava-tool openssh-server python-parsedatetime \
-	libsdl1.2-dev libcairo2-dev libxmu-dev libxmuu-dev iperf3
+	libsdl1.2-dev libcairo2-dev libxmu-dev libxmuu-dev iperf3 \
+	bison flex libelf-dev libssl-dev
 
 RUN pip install python-jenkins==0.4.14
 RUN pip install filelock
-- 
2.7.4

Re: [Fuego] kernel_build dependencies

[Tim.Bird]

> -----Original Message-----
> From: Daniel Sangorrin on  Tuesday, March 27, 2018 1:55 AM
> This is a patch for the Docker side. I have added the dependencies
> on the test.yaml already, and I added is_on_sdk to fuego_test.sh so
> you may prefer not to accept this patch.

No - I'm happy to take this patch.  I think we should make a special exception for
the kernel, in terms of supporting all tools needed to build it being included
in the base Fuego distribution.  Also, these tools are not architecture
or board-specific (they're not related to the PLATFORM (ie toolchain),
so they are OK to load generally.

> 
> [PATCH] Dockerfile: sdk dependencies for building a x86_64 kernel

Thanks!
 -- Tim

Re: [Fuego] [PATCH] Dockerfile: sdk dependencies for building a x86_64 kernel

[Tim.Bird]

> -----Original Message-----
> From: Daniel Sangorrin on Tuesday, March 27, 2018 1:55 AM
> Note, I have added the dependencies to the kernel_build test's
> test.yaml. In the future, it would be nice to install them
> directly from ftc. At the moment that is not possible so I add
> them here, but I'm also adding is_on_sdk checks to the test
> so even if this patch is not accepted the user should be
> able to understand the error log.
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  Dockerfile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Dockerfile b/Dockerfile
> index 4dcf505..2c0b17e 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -31,7 +31,8 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get
> update && apt-get -yV install \
>  	inotify-tools g++ bzip2 bc libaio-dev gettext pkg-config libglib2.0-dev
> \
>  	time python-pip python-xmltodict at minicom lzop bsdmainutils u-
> boot-tools \
>  	mc netcat lava-tool openssh-server python-parsedatetime \
> -	libsdl1.2-dev libcairo2-dev libxmu-dev libxmuu-dev iperf3
> +	libsdl1.2-dev libcairo2-dev libxmu-dev libxmuu-dev iperf3 \
> +	bison flex libelf-dev libssl-dev


I think it's appropriate to have these in the base Fuego distribution.

Applied and pushed.

Thanks!
 -- Tim