[Fuego] [PATCH] Add gzip and gunzip to the test list which using command tr.

[Fuego] [PATCH] Add gzip and gunzip to the test list which using command tr.

[Wang Mingyu]

Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com>
---
 engine/tests/Functional.busybox/fuego_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/tests/Functional.busybox/fuego_test.sh b/engine/tests/Functional.busybox/fuego_test.sh
index 861cf24..e2597ac 100755
--- a/engine/tests/Functional.busybox/fuego_test.sh
+++ b/engine/tests/Functional.busybox/fuego_test.sh
@@ -44,7 +44,7 @@ function test_pre_check {
     echo "Tests skipped depending on the availability of a command on the target"
     touch ${LOGDIR}/skiplist.txt
     skip_if_command_unavailable expect "busybox_ash.sh"
-    skip_if_command_unavailable tr "busybox_chgrp1.sh busybox_chgrp2.sh busybox_chmod1.sh busybox_chmod2.sh busybox_chown1.sh busybox_chown2.sh"
+    skip_if_command_unavailable tr "busybox_chgrp1.sh busybox_chgrp2.sh busybox_chmod1.sh busybox_chmod2.sh busybox_chown1.sh busybox_chown2.sh busybox_gunzip.sh busybox_gzip.sh"
     skip_if_not_root "busybox_chroot.sh"
 }
 
-- 
1.8.3.1

Re: [Fuego] [PATCH] Add gzip and gunzip to the test list which using command tr.

[Tim.Bird]

Looking at the scripts for gzip and gunzip, I think you should remove
the usage of 'tr' in those scripts, rather than add the dependency and
this check here.

Please see my comments on the other patch
 -- Tim


> -----Original Message-----
> From: Wang Mingyu
> 
> Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com>
> ---
>  engine/tests/Functional.busybox/fuego_test.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/engine/tests/Functional.busybox/fuego_test.sh
> b/engine/tests/Functional.busybox/fuego_test.sh
> index 861cf24..e2597ac 100755
> --- a/engine/tests/Functional.busybox/fuego_test.sh
> +++ b/engine/tests/Functional.busybox/fuego_test.sh
> @@ -44,7 +44,7 @@ function test_pre_check {
>      echo "Tests skipped depending on the availability of a command on the
> target"
>      touch ${LOGDIR}/skiplist.txt
>      skip_if_command_unavailable expect "busybox_ash.sh"
> -    skip_if_command_unavailable tr "busybox_chgrp1.sh busybox_chgrp2.sh
> busybox_chmod1.sh busybox_chmod2.sh busybox_chown1.sh
> busybox_chown2.sh"
> +    skip_if_command_unavailable tr "busybox_chgrp1.sh busybox_chgrp2.sh
> busybox_chmod1.sh busybox_chmod2.sh busybox_chown1.sh
> busybox_chown2.sh busybox_gunzip.sh busybox_gzip.sh"
>      skip_if_not_root "busybox_chroot.sh"
>  }
> 
> --
> 1.8.3.1
> 
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego