[Fuego] [PATCH 1/5] signaltest:add a warning for rt

[Fuego] [PATCH 1/5] signaltest:add a warning for rt

[Zhong Lu]

Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
---
 engine/tests/Benchmark.signaltest/fuego_test.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/engine/tests/Benchmark.signaltest/fuego_test.sh b/engine/tests/Benchmark.signaltest/fuego_test.sh
index 3b288f9..54e08b1 100755
--- a/engine/tests/Benchmark.signaltest/fuego_test.sh
+++ b/engine/tests/Benchmark.signaltest/fuego_test.sh
@@ -4,6 +4,12 @@ NEED_ROOT=1
 
 function test_pre_check {
     assert_define BENCHMARK_SIGNALTEST_PARAMS
+    if check_kconfig "CONFIG_RT_GROUP_SCHED=y"; then
+        echo "WARNING: CONFIG_RT_GROUP_SCHED enabled in your kernel. Please check the RT"
+        echo "settings as following if this test failed with 'Unable to change scheduling policy'."
+        echo "- If the user does not need the RT groups functionality, disable CONFIG_RT_GROUP_SCHED and compile the kernel again, or 'sysctl -w kernel.sched_rt_runtime_us=-1'"
+        echo "- If the user does want to use RT groups functionality, you may want to assign the ssh daemon service a realtime budget by specifyihg the cpu.rt_runtime_us attribute"
+    fi
 }
 
 function test_build {
-- 
2.7.4

[Fuego] [PATCH 2/5] signaltest: add min_latency graph

[Zhong Lu]

details:Test case 'min_latency' is defined and value is checked, but there is no graph.
Add graph of 'min_latency'.

Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
---
 engine/tests/Benchmark.signaltest/chart_config.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/engine/tests/Benchmark.signaltest/chart_config.json b/engine/tests/Benchmark.signaltest/chart_config.json
index cdaf6a2..aa73167 100644
--- a/engine/tests/Benchmark.signaltest/chart_config.json
+++ b/engine/tests/Benchmark.signaltest/chart_config.json
@@ -1,5 +1,6 @@
 {
 	"chart_type": "measure_plot",
 	"measures": ["default.latencies.max_latency",
+        "default.latencies.min_latency",
         "default.latencies.avg_latency"]
 }
-- 
2.7.4

[Fuego] [PATCH 3/5] signaltest:change original upstream branch

[Zhong Lu]

details:The original upstream branch 'unstable/devel/v1.1.1' doesn't exist, which makes test_build fail.
Use exist upstream branch.

Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
---
 engine/tests/Benchmark.signaltest/spec.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/tests/Benchmark.signaltest/spec.json b/engine/tests/Benchmark.signaltest/spec.json
index 3169533..3105a7d 100644
--- a/engine/tests/Benchmark.signaltest/spec.json
+++ b/engine/tests/Benchmark.signaltest/spec.json
@@ -7,7 +7,7 @@
         "latest": {
             "PER_JOB_BUILD": "true",
             "gitrepo": "https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git",
-            "gitref": "unstable/devel/v1.1.1",
+            "gitref": "unstable/devel/latest",
             "PARAMS": "-t 2 -m -l 10000 -p 60 -q"
         }
     }
-- 
2.7.4

[Fuego] [PATCH 4/5] dd:fix with testname in spec

[Zhong Lu]

details: modify testname from Benchmark.bb to Benchmark.dd

Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
---
 engine/tests/Benchmark.dd/spec.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/tests/Benchmark.dd/spec.json b/engine/tests/Benchmark.dd/spec.json
index 1cb0a1e..00dcbca 100644
--- a/engine/tests/Benchmark.dd/spec.json
+++ b/engine/tests/Benchmark.dd/spec.json
@@ -1,5 +1,5 @@
 {
-    "testName": "Benchmark.bb",
+    "testName": "Benchmark.dd",
     "specs": {
         "default": {}
     }
-- 
2.7.4

[Fuego] [PATCH 5/5] cyclictest:add min_latency graph

[Zhong Lu]

details:details:Test case 'min_latency' is defined and value is checked, but there is no graph.
Add graph of 'min_latency'.

Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
---
 engine/tests/Benchmark.cyclictest/chart_config.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/engine/tests/Benchmark.cyclictest/chart_config.json b/engine/tests/Benchmark.cyclictest/chart_config.json
index cdaf6a2..aa73167 100644
--- a/engine/tests/Benchmark.cyclictest/chart_config.json
+++ b/engine/tests/Benchmark.cyclictest/chart_config.json
@@ -1,5 +1,6 @@
 {
 	"chart_type": "measure_plot",
 	"measures": ["default.latencies.max_latency",
+        "default.latencies.min_latency",
         "default.latencies.avg_latency"]
 }
-- 
2.7.4

Re: [Fuego] [PATCH 5/5] cyclictest:add min_latency graph

[Tim.Bird]

Zhong Lu,

I applied all 5 patches in this series, but I do have a question about this one
and patch 2/5.  Both of these add min_latency values to the charts for their
respective tests.

Can you please let me know why this is something you would like to see charted?
I'm not sure it provides any value to the end user (tester), and it will tend to clutter
up the graph.   I don't know if the min_latency is ever very useful, unless it is very high
which would show something really, really wrong with the realtime scheduling on
the board.

I have already applied the patches (along with similar ones from Liu Gang).  So
it's not critical.  But if you have some more information about your use of this
measurement I would appreciate hearing about it.

Thanks,
 -- Tim


> -----Original Message-----
> From: Zhong Lu
> 
> details:details:Test case 'min_latency' is defined and value is checked, but
> there is no graph.
> Add graph of 'min_latency'.
> 
> Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
> ---
>  engine/tests/Benchmark.cyclictest/chart_config.json | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/engine/tests/Benchmark.cyclictest/chart_config.json
> b/engine/tests/Benchmark.cyclictest/chart_config.json
> index cdaf6a2..aa73167 100644
> --- a/engine/tests/Benchmark.cyclictest/chart_config.json
> +++ b/engine/tests/Benchmark.cyclictest/chart_config.json
> @@ -1,5 +1,6 @@
>  {
>  	"chart_type": "measure_plot",
>  	"measures": ["default.latencies.max_latency",
> +        "default.latencies.min_latency",
>          "default.latencies.avg_latency"]
>  }
> --
> 2.7.4