* [PATCH] net/virtio-user: fix missing driver name
@ 2017-01-18 11:44 Jianfeng Tan
2017-01-18 11:52 ` [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 7+ messages in thread
From: Jianfeng Tan @ 2017-01-18 11:44 UTC (permalink / raw)
To: dev; +Cc: yuanhan.liu, Jianfeng Tan, stable
API rte_eth_dev_info_get() fills driver name according to drv_name
of rte_eth_dev_data. But we have not fill such info in virtio_user.
We do not use the same one with virtio device as some applications
might depend on driver name to differetiate kinds of devices, such
as VPP.
Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
CC: stable@dpdk.org
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
drivers/net/virtio/virtio_user_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index c877968..110f6a9 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
hw->use_simple_rxtx = 0;
hw->virtio_user_dev = dev;
data->dev_private = hw;
+ data->drv_name = "virtio_user PMD";
data->numa_node = SOCKET_ID_ANY;
data->kdrv = RTE_KDRV_NONE;
data->dev_flags = RTE_ETH_DEV_DETACHABLE;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
2017-01-18 11:44 [PATCH] net/virtio-user: fix missing driver name Jianfeng Tan
@ 2017-01-18 11:52 ` Ferruh Yigit
2017-01-18 13:49 ` Tan, Jianfeng
0 siblings, 1 reply; 7+ messages in thread
From: Ferruh Yigit @ 2017-01-18 11:52 UTC (permalink / raw)
To: Jianfeng Tan, dev; +Cc: yuanhan.liu, stable
On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> API rte_eth_dev_info_get() fills driver name according to drv_name
> of rte_eth_dev_data. But we have not fill such info in virtio_user.
>
> We do not use the same one with virtio device as some applications
> might depend on driver name to differetiate kinds of devices, such
> as VPP.
>
> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> CC: stable@dpdk.org
>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
> drivers/net/virtio/virtio_user_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> index c877968..110f6a9 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> hw->use_simple_rxtx = 0;
> hw->virtio_user_dev = dev;
> data->dev_private = hw;
> + data->drv_name = "virtio_user PMD";
How driver naming done changed in next-net.
Please check any other virtual driver in next-net for sample.
> data->numa_node = SOCKET_ID_ANY;
> data->kdrv = RTE_KDRV_NONE;
> data->dev_flags = RTE_ETH_DEV_DETACHABLE;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
2017-01-18 11:52 ` [dpdk-stable] " Ferruh Yigit
@ 2017-01-18 13:49 ` Tan, Jianfeng
2017-01-18 15:54 ` Ferruh Yigit
0 siblings, 1 reply; 7+ messages in thread
From: Tan, Jianfeng @ 2017-01-18 13:49 UTC (permalink / raw)
To: Yigit, Ferruh, dev; +Cc: Liu, Yuanhan, stable
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 18, 2017 7:53 PM
> To: Tan, Jianfeng; dev@dpdk.org
> Cc: Liu, Yuanhan; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
>
> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> > API rte_eth_dev_info_get() fills driver name according to drv_name
> > of rte_eth_dev_data. But we have not fill such info in virtio_user.
> >
> > We do not use the same one with virtio device as some applications
> > might depend on driver name to differetiate kinds of devices, such
> > as VPP.
> >
> > Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> > ---
> > drivers/net/virtio/virtio_user_ethdev.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> b/drivers/net/virtio/virtio_user_ethdev.c
> > index c877968..110f6a9 100644
> > --- a/drivers/net/virtio/virtio_user_ethdev.c
> > +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> > hw->use_simple_rxtx = 0;
> > hw->virtio_user_dev = dev;
> > data->dev_private = hw;
> > + data->drv_name = "virtio_user PMD";
>
> How driver naming done changed in next-net.
> Please check any other virtual driver in next-net for sample.
Thank you for the info. And it seems that it's already fixed by that patch.
Self NACK.
Thanks,
Jianfeng
>
> > data->numa_node = SOCKET_ID_ANY;
> > data->kdrv = RTE_KDRV_NONE;
> > data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
2017-01-18 13:49 ` Tan, Jianfeng
@ 2017-01-18 15:54 ` Ferruh Yigit
2017-01-19 1:16 ` Tan, Jianfeng
0 siblings, 1 reply; 7+ messages in thread
From: Ferruh Yigit @ 2017-01-18 15:54 UTC (permalink / raw)
To: Tan, Jianfeng, dev; +Cc: Liu, Yuanhan, stable
On 1/18/2017 1:49 PM, Tan, Jianfeng wrote:
> Hi Ferruh,
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, January 18, 2017 7:53 PM
>> To: Tan, Jianfeng; dev@dpdk.org
>> Cc: Liu, Yuanhan; stable@dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
>>
>> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
>>> API rte_eth_dev_info_get() fills driver name according to drv_name
>>> of rte_eth_dev_data. But we have not fill such info in virtio_user.
>>>
>>> We do not use the same one with virtio device as some applications
>>> might depend on driver name to differetiate kinds of devices, such
>>> as VPP.
>>>
>>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
>>> CC: stable@dpdk.org
>>>
>>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>>> ---
>>> drivers/net/virtio/virtio_user_ethdev.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
>> b/drivers/net/virtio/virtio_user_ethdev.c
>>> index c877968..110f6a9 100644
>>> --- a/drivers/net/virtio/virtio_user_ethdev.c
>>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
>>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
>>> hw->use_simple_rxtx = 0;
>>> hw->virtio_user_dev = dev;
>>> data->dev_private = hw;
>>> + data->drv_name = "virtio_user PMD";
>>
>> How driver naming done changed in next-net.
>> Please check any other virtual driver in next-net for sample.
>
> Thank you for the info. And it seems that it's already fixed by that patch.
That patch modified during merge, can you please confirm the latest
version in the repo?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
2017-01-18 15:54 ` Ferruh Yigit
@ 2017-01-19 1:16 ` Tan, Jianfeng
2017-01-19 8:16 ` Yuanhan Liu
0 siblings, 1 reply; 7+ messages in thread
From: Tan, Jianfeng @ 2017-01-19 1:16 UTC (permalink / raw)
To: Yigit, Ferruh, dev; +Cc: Liu, Yuanhan, stable
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 18, 2017 11:55 PM
> To: Tan, Jianfeng; dev@dpdk.org
> Cc: Liu, Yuanhan; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
>
> On 1/18/2017 1:49 PM, Tan, Jianfeng wrote:
> > Hi Ferruh,
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh
> >> Sent: Wednesday, January 18, 2017 7:53 PM
> >> To: Tan, Jianfeng; dev@dpdk.org
> >> Cc: Liu, Yuanhan; stable@dpdk.org
> >> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver
> name
> >>
> >> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> >>> API rte_eth_dev_info_get() fills driver name according to drv_name
> >>> of rte_eth_dev_data. But we have not fill such info in virtio_user.
> >>>
> >>> We do not use the same one with virtio device as some applications
> >>> might depend on driver name to differetiate kinds of devices, such
> >>> as VPP.
> >>>
> >>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> >>> CC: stable@dpdk.org
> >>>
> >>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> >>> ---
> >>> drivers/net/virtio/virtio_user_ethdev.c | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> >> b/drivers/net/virtio/virtio_user_ethdev.c
> >>> index c877968..110f6a9 100644
> >>> --- a/drivers/net/virtio/virtio_user_ethdev.c
> >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> >>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> >>> hw->use_simple_rxtx = 0;
> >>> hw->virtio_user_dev = dev;
> >>> data->dev_private = hw;
> >>> + data->drv_name = "virtio_user PMD";
> >>
> >> How driver naming done changed in next-net.
> >> Please check any other virtual driver in next-net for sample.
> >
> > Thank you for the info. And it seems that it's already fixed by that patch.
>
> That patch modified during merge, can you please confirm the latest
> version in the repo?
Just checked latest master repo, this problem has been fixed by commit 73db5badb04 ("net: align ethdev and eal driver names"). Thanks to David Marchand.
Yuanhan, do you think this patch can be applied to the stable repo?
Thanks,
Jianfeng
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
2017-01-19 1:16 ` Tan, Jianfeng
@ 2017-01-19 8:16 ` Yuanhan Liu
2017-01-19 8:23 ` Tan, Jianfeng
0 siblings, 1 reply; 7+ messages in thread
From: Yuanhan Liu @ 2017-01-19 8:16 UTC (permalink / raw)
To: Tan, Jianfeng; +Cc: Yigit, Ferruh, dev, stable
On Thu, Jan 19, 2017 at 09:16:58AM +0800, Tan, Jianfeng wrote:
> > >> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> > >>> API rte_eth_dev_info_get() fills driver name according to drv_name
> > >>> of rte_eth_dev_data. But we have not fill such info in virtio_user.
> > >>>
> > >>> We do not use the same one with virtio device as some applications
> > >>> might depend on driver name to differetiate kinds of devices, such
> > >>> as VPP.
> > >>>
> > >>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> > >>> CC: stable@dpdk.org
> > >>>
> > >>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> > >>> ---
> > >>> drivers/net/virtio/virtio_user_ethdev.c | 1 +
> > >>> 1 file changed, 1 insertion(+)
> > >>>
> > >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> > >> b/drivers/net/virtio/virtio_user_ethdev.c
> > >>> index c877968..110f6a9 100644
> > >>> --- a/drivers/net/virtio/virtio_user_ethdev.c
> > >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > >>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> > >>> hw->use_simple_rxtx = 0;
> > >>> hw->virtio_user_dev = dev;
> > >>> data->dev_private = hw;
> > >>> + data->drv_name = "virtio_user PMD";
> > >>
> > >> How driver naming done changed in next-net.
> > >> Please check any other virtual driver in next-net for sample.
> > >
> > > Thank you for the info. And it seems that it's already fixed by that patch.
> >
> > That patch modified during merge, can you please confirm the latest
> > version in the repo?
>
> Just checked latest master repo, this problem has been fixed by commit 73db5badb04 ("net: align ethdev and eal driver names"). Thanks to David Marchand.
>
> Yuanhan, do you think this patch can be applied to the stable repo?
I think I would partially backport that commit to a stable release: just
pick the virtio changes, with a brand new commit log, stating the issue
need to be fixed and it's a partial backport from 73db5badb04 ("net: align
ethdev and eal driver names").
Okay to you?
--yliu
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
2017-01-19 8:16 ` Yuanhan Liu
@ 2017-01-19 8:23 ` Tan, Jianfeng
0 siblings, 0 replies; 7+ messages in thread
From: Tan, Jianfeng @ 2017-01-19 8:23 UTC (permalink / raw)
To: Yuanhan Liu; +Cc: Yigit, Ferruh, dev, stable
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Thursday, January 19, 2017 4:16 PM
> To: Tan, Jianfeng
> Cc: Yigit, Ferruh; dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
>
> On Thu, Jan 19, 2017 at 09:16:58AM +0800, Tan, Jianfeng wrote:
> > > >> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> > > >>> API rte_eth_dev_info_get() fills driver name according to drv_name
> > > >>> of rte_eth_dev_data. But we have not fill such info in virtio_user.
> > > >>>
> > > >>> We do not use the same one with virtio device as some applications
> > > >>> might depend on driver name to differetiate kinds of devices, such
> > > >>> as VPP.
> > > >>>
> > > >>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> > > >>> CC: stable@dpdk.org
> > > >>>
> > > >>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> > > >>> ---
> > > >>> drivers/net/virtio/virtio_user_ethdev.c | 1 +
> > > >>> 1 file changed, 1 insertion(+)
> > > >>>
> > > >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> > > >> b/drivers/net/virtio/virtio_user_ethdev.c
> > > >>> index c877968..110f6a9 100644
> > > >>> --- a/drivers/net/virtio/virtio_user_ethdev.c
> > > >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > > >>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> > > >>> hw->use_simple_rxtx = 0;
> > > >>> hw->virtio_user_dev = dev;
> > > >>> data->dev_private = hw;
> > > >>> + data->drv_name = "virtio_user PMD";
> > > >>
> > > >> How driver naming done changed in next-net.
> > > >> Please check any other virtual driver in next-net for sample.
> > > >
> > > > Thank you for the info. And it seems that it's already fixed by that patch.
> > >
> > > That patch modified during merge, can you please confirm the latest
> > > version in the repo?
> >
> > Just checked latest master repo, this problem has been fixed by commit
> 73db5badb04 ("net: align ethdev and eal driver names"). Thanks to David
> Marchand.
> >
> > Yuanhan, do you think this patch can be applied to the stable repo?
>
> I think I would partially backport that commit to a stable release: just
> pick the virtio changes, with a brand new commit log, stating the issue
> need to be fixed and it's a partial backport from 73db5badb04 ("net: align
> ethdev and eal driver names").
>
> Okay to you?
That will be great. Actually, I'm wondering if possible to make your work easier by just adding another very simple fix only to stable branch.
Thanks,
Jianfeng
>
> --yliu
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-19 8:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-18 11:44 [PATCH] net/virtio-user: fix missing driver name Jianfeng Tan
2017-01-18 11:52 ` [dpdk-stable] " Ferruh Yigit
2017-01-18 13:49 ` Tan, Jianfeng
2017-01-18 15:54 ` Ferruh Yigit
2017-01-19 1:16 ` Tan, Jianfeng
2017-01-19 8:16 ` Yuanhan Liu
2017-01-19 8:23 ` Tan, Jianfeng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.