vhost user MTU and promisc mode

vhost user MTU and promisc mode

[Tan, Jianfeng]

Hi Maxime,

Have seen that you submit a feature in QEMU, commit c5f048d8fb69 ("vhost-user: Add MTU protocol feature and op").

Appreciate your insights on:
(1) Do you have plan to enable it in DPDK vhost user?
(2) How about another similar feature, promisc mode enable/disable?

Thanks,
Jianfeng

Re: vhost user MTU and promisc mode

[Maxime Coquelin]

Hi Jianfeng,

On 02/06/2017 07:39 AM, Tan, Jianfeng wrote:
> Hi Maxime,
>
>
>
> Have seen that you submit a feature in QEMU, commit c5f048d8fb69
> (“vhost-user: Add MTU protocol feature and op”).
>
>
>
> Appreciate your insights on:
>
> (1) Do you have plan to enable it in DPDK vhost user?
Yes, I plan to propose this for v17.05 release.
For vhost-user backend, the op is to notify the backend with the MTU
value set in QEMU, so that it can ensure packets sent won't be bigger.

>
> (2) How about another similar feature, promisc mode enable/disable?
This is ont something we have considered yet.
Are you willing to work on it?

Thanks,
Maxime

>
>
> Thanks,
>
> Jianfeng
>

Re: vhost user MTU and promisc mode

[Tan, Jianfeng]

> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Monday, February 6, 2017 6:20 PM
> To: Tan, Jianfeng
> Cc: mst@redhat.com; Liu, Yuanhan; dev@dpdk.org
> Subject: Re: vhost user MTU and promisc mode
> 
> Hi Jianfeng,
> 
> On 02/06/2017 07:39 AM, Tan, Jianfeng wrote:
> > Hi Maxime,
> >
> >
> >
> > Have seen that you submit a feature in QEMU, commit c5f048d8fb69
> > ("vhost-user: Add MTU protocol feature and op").
> >
> >
> >
> > Appreciate your insights on:
> >
> > (1) Do you have plan to enable it in DPDK vhost user?
> Yes, I plan to propose this for v17.05 release.
> For vhost-user backend, the op is to notify the backend with the MTU
> value set in QEMU, so that it can ensure packets sent won't be bigger.

Great to know that.

> 
> >
> > (2) How about another similar feature, promisc mode enable/disable?
> This is ont something we have considered yet.
> Are you willing to work on it?

Yes, we are considering it. But it should be firstly upsteamed into QEMU.

Thanks,
Jianfeng

> 
> Thanks,
> Maxime
> 
> >
> >
> > Thanks,
> >
> > Jianfeng
> >

Re: vhost user MTU and promisc mode

[Michael S. Tsirkin]

On Tue, Feb 07, 2017 at 04:27:16PM +0000, Tan, Jianfeng wrote:
> 
> 
> > -----Original Message-----
> > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > Sent: Monday, February 6, 2017 6:20 PM
> > To: Tan, Jianfeng
> > Cc: mst@redhat.com; Liu, Yuanhan; dev@dpdk.org
> > Subject: Re: vhost user MTU and promisc mode
> > 
> > Hi Jianfeng,
> > 
> > On 02/06/2017 07:39 AM, Tan, Jianfeng wrote:
> > > Hi Maxime,
> > >
> > >
> > >
> > > Have seen that you submit a feature in QEMU, commit c5f048d8fb69
> > > ("vhost-user: Add MTU protocol feature and op").
> > >
> > >
> > >
> > > Appreciate your insights on:
> > >
> > > (1) Do you have plan to enable it in DPDK vhost user?
> > Yes, I plan to propose this for v17.05 release.
> > For vhost-user backend, the op is to notify the backend with the MTU
> > value set in QEMU, so that it can ensure packets sent won't be bigger.
> 
> Great to know that.
> 
> > 
> > >
> > > (2) How about another similar feature, promisc mode enable/disable?
> > This is ont something we have considered yet.
> > Are you willing to work on it?
> 
> Yes, we are considering it. But it should be firstly upsteamed into QEMU.
> 
> Thanks,
> Jianfeng

You also need to copy virtio tc list if you will suggest
interface changes. TC is responsible for documenting it.

> > 
> > Thanks,
> > Maxime
> > 
> > >
> > >
> > > Thanks,
> > >
> > > Jianfeng
> > >

Re: vhost user MTU and promisc mode

[Tan, Jianfeng]

> -----Original Message-----
> From: Michael S. Tsirkin [mailto:mst@redhat.com]
> Sent: Wednesday, February 8, 2017 12:33 AM
> To: Tan, Jianfeng
> Cc: Maxime Coquelin; Liu, Yuanhan; dev@dpdk.org
> Subject: Re: vhost user MTU and promisc mode
> 
> On Tue, Feb 07, 2017 at 04:27:16PM +0000, Tan, Jianfeng wrote:
> >
> >
> > > -----Original Message-----
> > > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > > Sent: Monday, February 6, 2017 6:20 PM
> > > To: Tan, Jianfeng
> > > Cc: mst@redhat.com; Liu, Yuanhan; dev@dpdk.org
> > > Subject: Re: vhost user MTU and promisc mode
> > >
> > > Hi Jianfeng,
> > >
> > > On 02/06/2017 07:39 AM, Tan, Jianfeng wrote:
> > > > Hi Maxime,
> > > >
> > > >
> > > >
> > > > Have seen that you submit a feature in QEMU, commit c5f048d8fb69
> > > > ("vhost-user: Add MTU protocol feature and op").
> > > >
> > > >
> > > >
> > > > Appreciate your insights on:
> > > >
> > > > (1) Do you have plan to enable it in DPDK vhost user?
> > > Yes, I plan to propose this for v17.05 release.
> > > For vhost-user backend, the op is to notify the backend with the MTU
> > > value set in QEMU, so that it can ensure packets sent won't be bigger.
> >
> > Great to know that.
> >
> > >
> > > >
> > > > (2) How about another similar feature, promisc mode enable/disable?
> > > This is ont something we have considered yet.
> > > Are you willing to work on it?
> >
> > Yes, we are considering it. But it should be firstly upsteamed into QEMU.
> >
> > Thanks,
> > Jianfeng
> 
> You also need to copy virtio tc list if you will suggest
> interface changes. TC is responsible for documenting it.

Thank you Michael for reminding! We will do that in a separated thread.

Thanks,
Jianfeng

> 
> > >
> > > Thanks,
> > > Maxime
> > >
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Jianfeng
> > > >