Re: [Xen-devel] [PATCH v3] Add TRACKING.IMPORTS to xen.git to more easily manage imported files that need to be kept in sync with an upstream

[Lars Kurth <lars.kurth@citrix.com>]

On 27/05/2019, 10:41, "Jan Beulich" <JBeulich@suse.com> wrote:

    >>> On 24.05.19 at 19:44, <lars.kurth@citrix.com> wrote:
    > Following the recent discussion, we had on IRC and the action I had in 
    > the March community call, this file provides a file format that 
    > enables writing an automated test to check whether files are out of sync. 
    > 
    > An example, what file content may look like is embedded below
    > repo: linux-torvalds git 
    > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
    > file: xen/drivers/passthrough/arm/smmu.c linux-torvalds 
    > linux/drivers/iommu/arm-smmu.c b77cf11f094136
    > 
    > Once the file format is agree, I will write a test or script.
    > 
    > I also need some more correct test data, aka entries in the file from
    > committers looking after the following files
    > [Jan]
    > xen/arch/x86/cpu/mwait-idle.c 
    > [Stefano, Julien - this has to be finalized]
    > xen/drivers/passthrough/arm/smmu.c
    > xen/arch/arm/vgic/*
    > xen/include/asm-arm/div64.h
    > xen/drivers/char/meson-uart.c
    > xen/arch/arm/arm32/lib/*
    > xen/arch/arm/arm64/lib/*
    > xen/arch/arm/arm64/cache.S
    > xen/arch/arm/arm64/bpi.S
    > xen/include/asm-arm/system.h
    > xen/arch/arm/arm64/insn.c
    > [Others?]
    > xen/common/rbtree.c
    > 
    > Note that in some cases Linux has diverged and some Linux files have disappeared. 
    > Julien also raised the point, that in some cases only a subset of code from 
    > Linux Xen files was applied or that only some functions get moved across to 
    > Xen.
    > 
    > I believe that is entirely OK. The workflow would be in most cases that:
    > - We use a Linux (source) commit as a benchmark and record the commit ID
    > - If there is a change in Linux the test will fail
    > - The committer looks at the diff and either
    >   - Decides to ignore it and bumps the commit ID in this file
    >   - Decides the change is needed, integrates it into Xen and then 
    >     bumps the commit ID in this file
    
    With this ...
    
    > Changes since v1
    > * Require a colon after repo:, file:, ... keywords
    > * Replace manual:|auto: with file: as there auto: use-case was invalid
    > * Added more verbose description of format
    > 
    > Changes since v2
    > * Changed some formatting
    > * Removed examples
    > * Removed references to https
    
    ... move past the first --- separator ...
    
    > Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
    
    Acked-by: Jan Beulich <jbeulich@suse.com>
    
Are any extra ACKs needed?  
Also, I would be willing to write a script which helps checking the file, but it does require some test data (aka Jan, Julien and Stefano) to populate the file
Regards
Lars
    

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel