From: "Jan Beulich" <JBeulich@suse.com> To: Lars Kurth <lars.kurth@citrix.com> Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>, committers@xenproject.org, xen-devel <xen-devel@lists.xenproject.org> Subject: Re: [PATCH v3] Add TRACKING.IMPORTS to xen.git to more easily manage imported files that need to be kept in sync with an upstream Date: Mon, 27 May 2019 03:40:51 -0600 [thread overview] Message-ID: <5CEBB0A30200007800232BBE@prv1-mh.provo.novell.com> (raw) In-Reply-To: <6250372b05e95412cfd0f8e6f558f2376c4f3d94.1558719481.git.lars.kurth@citrix.com> >>> On 24.05.19 at 19:44, <lars.kurth@citrix.com> wrote: > Following the recent discussion, we had on IRC and the action I had in > the March community call, this file provides a file format that > enables writing an automated test to check whether files are out of sync. > > An example, what file content may look like is embedded below > repo: linux-torvalds git > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > file: xen/drivers/passthrough/arm/smmu.c linux-torvalds > linux/drivers/iommu/arm-smmu.c b77cf11f094136 > > Once the file format is agree, I will write a test or script. > > I also need some more correct test data, aka entries in the file from > committers looking after the following files > [Jan] > xen/arch/x86/cpu/mwait-idle.c > [Stefano, Julien - this has to be finalized] > xen/drivers/passthrough/arm/smmu.c > xen/arch/arm/vgic/* > xen/include/asm-arm/div64.h > xen/drivers/char/meson-uart.c > xen/arch/arm/arm32/lib/* > xen/arch/arm/arm64/lib/* > xen/arch/arm/arm64/cache.S > xen/arch/arm/arm64/bpi.S > xen/include/asm-arm/system.h > xen/arch/arm/arm64/insn.c > [Others?] > xen/common/rbtree.c > > Note that in some cases Linux has diverged and some Linux files have disappeared. > Julien also raised the point, that in some cases only a subset of code from > Linux Xen files was applied or that only some functions get moved across to > Xen. > > I believe that is entirely OK. The workflow would be in most cases that: > - We use a Linux (source) commit as a benchmark and record the commit ID > - If there is a change in Linux the test will fail > - The committer looks at the diff and either > - Decides to ignore it and bumps the commit ID in this file > - Decides the change is needed, integrates it into Xen and then > bumps the commit ID in this file With this ... > Changes since v1 > * Require a colon after repo:, file:, ... keywords > * Replace manual:|auto: with file: as there auto: use-case was invalid > * Added more verbose description of format > > Changes since v2 > * Changed some formatting > * Removed examples > * Removed references to https ... move past the first --- separator ... > Signed-off-by: Lars Kurth <lars.kurth@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com> To: "Lars Kurth" <lars.kurth@citrix.com> Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>, committers@xenproject.org, xen-devel <xen-devel@lists.xenproject.org> Subject: Re: [Xen-devel] [PATCH v3] Add TRACKING.IMPORTS to xen.git to more easily manage imported files that need to be kept in sync with an upstream Date: Mon, 27 May 2019 03:40:51 -0600 [thread overview] Message-ID: <5CEBB0A30200007800232BBE@prv1-mh.provo.novell.com> (raw) Message-ID: <20190527094051.b_gZ9aT5-mfUOz_FgLDjd351ekxpKbUlYt-LoF4igEA@z> (raw) In-Reply-To: <6250372b05e95412cfd0f8e6f558f2376c4f3d94.1558719481.git.lars.kurth@citrix.com> >>> On 24.05.19 at 19:44, <lars.kurth@citrix.com> wrote: > Following the recent discussion, we had on IRC and the action I had in > the March community call, this file provides a file format that > enables writing an automated test to check whether files are out of sync. > > An example, what file content may look like is embedded below > repo: linux-torvalds git > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > file: xen/drivers/passthrough/arm/smmu.c linux-torvalds > linux/drivers/iommu/arm-smmu.c b77cf11f094136 > > Once the file format is agree, I will write a test or script. > > I also need some more correct test data, aka entries in the file from > committers looking after the following files > [Jan] > xen/arch/x86/cpu/mwait-idle.c > [Stefano, Julien - this has to be finalized] > xen/drivers/passthrough/arm/smmu.c > xen/arch/arm/vgic/* > xen/include/asm-arm/div64.h > xen/drivers/char/meson-uart.c > xen/arch/arm/arm32/lib/* > xen/arch/arm/arm64/lib/* > xen/arch/arm/arm64/cache.S > xen/arch/arm/arm64/bpi.S > xen/include/asm-arm/system.h > xen/arch/arm/arm64/insn.c > [Others?] > xen/common/rbtree.c > > Note that in some cases Linux has diverged and some Linux files have disappeared. > Julien also raised the point, that in some cases only a subset of code from > Linux Xen files was applied or that only some functions get moved across to > Xen. > > I believe that is entirely OK. The workflow would be in most cases that: > - We use a Linux (source) commit as a benchmark and record the commit ID > - If there is a change in Linux the test will fail > - The committer looks at the diff and either > - Decides to ignore it and bumps the commit ID in this file > - Decides the change is needed, integrates it into Xen and then > bumps the commit ID in this file With this ... > Changes since v1 > * Require a colon after repo:, file:, ... keywords > * Replace manual:|auto: with file: as there auto: use-case was invalid > * Added more verbose description of format > > Changes since v2 > * Changed some formatting > * Removed examples > * Removed references to https ... move past the first --- separator ... > Signed-off-by: Lars Kurth <lars.kurth@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-27 9:41 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-24 17:44 [PATCH v3] Add TRACKING.IMPORTS to xen.git to more easily manage imported files that need to be kept in sync with an upstream Lars Kurth 2019-05-24 17:44 ` [Xen-devel] " Lars Kurth 2019-05-27 9:40 ` Jan Beulich [this message] 2019-05-27 9:40 ` Jan Beulich 2019-06-20 14:18 ` Lars Kurth 2019-06-21 6:14 ` Jan Beulich 2019-06-21 12:07 ` Lars Kurth
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5CEBB0A30200007800232BBE@prv1-mh.provo.novell.com \ --to=jbeulich@suse.com \ --cc=George.Dunlap@eu.citrix.com \ --cc=Ian.Jackson@eu.citrix.com \ --cc=andrew.cooper3@citrix.com \ --cc=committers@xenproject.org \ --cc=julien.grall@arm.com \ --cc=konrad.wilk@oracle.com \ --cc=lars.kurth@citrix.com \ --cc=sstabellini@kernel.org \ --cc=tim@xen.org \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.