All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Fix PACKAGE_EXTRA_ARCHS
@ 2011-07-28 14:18 Paul Eggleton
  2011-07-28 14:18 ` [PATCH 1/1] bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default Paul Eggleton
  2011-08-01 17:06 ` [PATCH 0/1] Fix PACKAGE_EXTRA_ARCHS Saul Wold
  0 siblings, 2 replies; 4+ messages in thread
From: Paul Eggleton @ 2011-07-28 14:18 UTC (permalink / raw)
  To: openembedded-core

Here's a fix as discussed for the PACKAGE_EXTRA_ARCHS issue since the
tune file changes. It may not be the proper fix but it does at least it
makes the value of this variable correct again.

The following changes since commit 1fe892ab6876c405599c79657221a8b4675b6ecf:

  Update TERMCMD message to align with previous change (2011-07-27 17:43:27 +0100)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib paule/core-pkgarch-fix
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/core-pkgarch-fix

Paul Eggleton (1):
  bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default

 meta/conf/bitbake.conf |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

-- 
1.7.4.1




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default
  2011-07-28 14:18 [PATCH 0/1] Fix PACKAGE_EXTRA_ARCHS Paul Eggleton
@ 2011-07-28 14:18 ` Paul Eggleton
  2011-07-28 14:28   ` Kumar Gala
  2011-08-01 17:06 ` [PATCH 0/1] Fix PACKAGE_EXTRA_ARCHS Saul Wold
  1 sibling, 1 reply; 4+ messages in thread
From: Paul Eggleton @ 2011-07-28 14:18 UTC (permalink / raw)
  To: openembedded-core

Because of the way BitBake handles ??= under certain circumstances, this
default setting ends up stepping all over the real setting from the arch
include file. Since virtually all arch include files or tune files define
a real value for this we shouldn't need to have a default (or it needs to
be done in a different way).

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/conf/bitbake.conf |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 6e109ec..9c80f11 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -84,7 +84,6 @@ HOST_EXEEXT = ""
 TUNE_ARCH ??= "INVALID"
 TUNE_CCARGS ??= ""
 TUNE_FEATURES ??= "${TUNE_FEATURES_tune-${DEFAULTTUNE}}"
-PACKAGE_EXTRA_ARCHS_tune-${DEFAULTTUNE} ??= "${TARGET_ARCH}"
 LIBCEXTENSION ??= ""
 ABIEXTENSION ??= ""
 
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default
  2011-07-28 14:18 ` [PATCH 1/1] bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default Paul Eggleton
@ 2011-07-28 14:28   ` Kumar Gala
  0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2011-07-28 14:28 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer


On Jul 28, 2011, at 9:18 AM, Paul Eggleton wrote:

> Because of the way BitBake handles ??= under certain circumstances, this
> default setting ends up stepping all over the real setting from the arch
> include file. Since virtually all arch include files or tune files define
> a real value for this we shouldn't need to have a default (or it needs to
> be done in a different way).
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> meta/conf/bitbake.conf |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)

Acked-by: Kumar Gala <galak@kernel.crashing.org>

- k



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/1] Fix PACKAGE_EXTRA_ARCHS
  2011-07-28 14:18 [PATCH 0/1] Fix PACKAGE_EXTRA_ARCHS Paul Eggleton
  2011-07-28 14:18 ` [PATCH 1/1] bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default Paul Eggleton
@ 2011-08-01 17:06 ` Saul Wold
  1 sibling, 0 replies; 4+ messages in thread
From: Saul Wold @ 2011-08-01 17:06 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer; +Cc: Paul Eggleton

On 07/28/2011 07:18 AM, Paul Eggleton wrote:
> Here's a fix as discussed for the PACKAGE_EXTRA_ARCHS issue since the
> tune file changes. It may not be the proper fix but it does at least it
> makes the value of this variable correct again.
>
> The following changes since commit 1fe892ab6876c405599c79657221a8b4675b6ecf:
>
>    Update TERMCMD message to align with previous change (2011-07-27 17:43:27 +0100)
>
> are available in the git repository at:
>    git://git.openembedded.org/openembedded-core-contrib paule/core-pkgarch-fix
>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/core-pkgarch-fix
>
> Paul Eggleton (1):
>    bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default
>
>   meta/conf/bitbake.conf |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
Pulled into OE-Core
Thanks
	Sau!



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-08-01 17:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-28 14:18 [PATCH 0/1] Fix PACKAGE_EXTRA_ARCHS Paul Eggleton
2011-07-28 14:18 ` [PATCH 1/1] bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default Paul Eggleton
2011-07-28 14:28   ` Kumar Gala
2011-08-01 17:06 ` [PATCH 0/1] Fix PACKAGE_EXTRA_ARCHS Saul Wold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.