All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] linux-ti33x-psp 3.1: add dto patch to fix problems with various sd cards
@ 2012-01-26 17:38 Koen Kooi
  2012-01-26 18:01 ` Tom Rini
  0 siblings, 1 reply; 5+ messages in thread
From: Koen Kooi @ 2012-01-26 17:38 UTC (permalink / raw)
  To: meta-ti

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 ...Set-dto-to-max-value-of-14-to-avoid-SD-Ca.patch |   34 ++++++++++++++++++++
 recipes-kernel/linux/linux-ti33x-psp_3.1.bb        |    3 +-
 2 files changed, 36 insertions(+), 1 deletions(-)
 create mode 100644 recipes-kernel/linux/linux-ti33x-psp-3.1/0038-omap_hsmmc-Set-dto-to-max-value-of-14-to-avoid-SD-Ca.patch

diff --git a/recipes-kernel/linux/linux-ti33x-psp-3.1/0038-omap_hsmmc-Set-dto-to-max-value-of-14-to-avoid-SD-Ca.patch b/recipes-kernel/linux/linux-ti33x-psp-3.1/0038-omap_hsmmc-Set-dto-to-max-value-of-14-to-avoid-SD-Ca.patch
new file mode 100644
index 0000000..4fe037e
--- /dev/null
+++ b/recipes-kernel/linux/linux-ti33x-psp-3.1/0038-omap_hsmmc-Set-dto-to-max-value-of-14-to-avoid-SD-Ca.patch
@@ -0,0 +1,34 @@
+From d12058d27dddf60b36f5b2142ee999e55bddfff6 Mon Sep 17 00:00:00 2001
+From: Steve Sakoman <steve@sakoman.com>
+Date: Mon, 18 Jul 2011 23:13:41 -0500
+Subject: [PATCH 38/38] omap_hsmmc: Set dto to max value of 14 to avoid SD
+ Card timeouts
+
+This fixes MMC errors due to timeouts on certain SD Cards following suggestions
+to set dto to 14 by Jason Kridner and Steven Kipisz
+
+Details of the issue:
+http://talk.maemo.org/showthread.php?p=1000707#post1000707
+
+This fix was originally proposed by Sukumar Ghoral of TI.
+---
+ drivers/mmc/host/omap_hsmmc.c |    3 +++
+ 1 files changed, 3 insertions(+), 0 deletions(-)
+
+diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
+index 35505bd..0be77ec 100644
+--- a/drivers/mmc/host/omap_hsmmc.c
++++ b/drivers/mmc/host/omap_hsmmc.c
+@@ -1574,6 +1574,9 @@ static void set_data_timeout(struct omap_hsmmc_host *host,
+ 			dto = 14;
+ 	}
+ 
++	/* Set dto to max value of 14 to avoid SD Card timeouts */
++	dto = 14;
++
+ 	reg &= ~DTO_MASK;
+ 	reg |= dto << DTO_SHIFT;
+ 	OMAP_HSMMC_WRITE(host->base, SYSCTL, reg);
+-- 
+1.7.7.5
+
diff --git a/recipes-kernel/linux/linux-ti33x-psp_3.1.bb b/recipes-kernel/linux/linux-ti33x-psp_3.1.bb
index 84e5c3b..591731c 100644
--- a/recipes-kernel/linux/linux-ti33x-psp_3.1.bb
+++ b/recipes-kernel/linux/linux-ti33x-psp_3.1.bb
@@ -11,7 +11,7 @@ MULTI_CONFIG_BASE_SUFFIX = ""
 
 BRANCH = "v3.1-meta-ti-r1r+gitr1d84d8853fa30cf3db2571a5aec572accca4e29d"
 SRCREV = "1d84d8853fa30cf3db2571a5aec572accca4e29d"
-MACHINE_KERNEL_PR_append = "k+gitr${SRCREV}"
+MACHINE_KERNEL_PR_append = "l+gitr${SRCREV}"
 
 COMPATIBLE_MACHINE = "(ti33x)"
 
@@ -62,6 +62,7 @@ PATCHES_OVER_PSP = " \
 	file://0035-beaglebone-add-structs-for-DVI-cape-LEDs.patch\
 	file://0036-beaglebone-update-LCD-cape-partnumber.patch \
     file://0037-beaglebone-compare-complete-partnumber-not-the-first.patch \
+	file://0038-omap_hsmmc-Set-dto-to-max-value-of-14-to-avoid-SD-Ca.patch \
 	"
 
 SRC_URI += "${@base_contains('DISTRO_FEATURES', 'tipspkernel', "", "${PATCHES_OVER_PSP}", d)}"
-- 
1.7.2.5



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] linux-ti33x-psp 3.1: add dto patch to fix problems with various sd cards
  2012-01-26 17:38 [PATCH] linux-ti33x-psp 3.1: add dto patch to fix problems with various sd cards Koen Kooi
@ 2012-01-26 18:01 ` Tom Rini
  2012-01-26 18:12   ` Koen Kooi
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Rini @ 2012-01-26 18:01 UTC (permalink / raw)
  To: Koen Kooi; +Cc: meta-ti

On Thu, Jan 26, 2012 at 10:38 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>

I know the patch isn't yours but should we perhaps go in and make the
patch more obvious?  The function we're patching does a lot of
guesswork to find 'dto' and then we just say 'use the max'.  Why not
also go rip out that logic?

-- 
Tom


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] linux-ti33x-psp 3.1: add dto patch to fix problems with various sd cards
  2012-01-26 18:01 ` Tom Rini
@ 2012-01-26 18:12   ` Koen Kooi
  2012-01-26 20:35     ` Philip Balister
  0 siblings, 1 reply; 5+ messages in thread
From: Koen Kooi @ 2012-01-26 18:12 UTC (permalink / raw)
  To: Tom Rini; +Cc: meta-ti


Op 26 jan. 2012, om 19:01 heeft Tom Rini het volgende geschreven:

> On Thu, Jan 26, 2012 at 10:38 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> 
> I know the patch isn't yours but should we perhaps go in and make the
> patch more obvious?  The function we're patching does a lot of
> guesswork to find 'dto' and then we just say 'use the max'.  Why not
> also go rip out that logic?

I was having the same conversation with Philip Balister on IRC just now :) It seems that this patch is being used by various TI customers to magically fix things so we do need to come up with a proper solution.

regards,

Koen

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] linux-ti33x-psp 3.1: add dto patch to fix problems with various sd cards
  2012-01-26 18:12   ` Koen Kooi
@ 2012-01-26 20:35     ` Philip Balister
  2012-01-26 20:37       ` Maupin, Chase
  0 siblings, 1 reply; 5+ messages in thread
From: Philip Balister @ 2012-01-26 20:35 UTC (permalink / raw)
  To: Koen Kooi; +Cc: Ben Hilburn, meta-ti

On 01/26/2012 01:12 PM, Koen Kooi wrote:
> 
> Op 26 jan. 2012, om 19:01 heeft Tom Rini het volgende geschreven:
> 
>> On Thu, Jan 26, 2012 at 10:38 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>>
>> I know the patch isn't yours but should we perhaps go in and make the
>> patch more obvious?  The function we're patching does a lot of
>> guesswork to find 'dto' and then we just say 'use the max'.  Why not
>> also go rip out that logic?
> 
> I was having the same conversation with Philip Balister on IRC just now :) It seems that this patch is being used by various TI customers to magically fix things so we do need to come up with a proper solution.

Basically, we are pissed of with really annoying SD card failures. (This
is an understatement, the problem cost me a lot of sleep at ELCE)

Unless someone has a better solution, we should rip out the hairy
calculation and set dto to 14 al the time and send the patch upstream.
Does anyone see any reason not to do this?

Philip


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] linux-ti33x-psp 3.1: add dto patch to fix problems with various sd cards
  2012-01-26 20:35     ` Philip Balister
@ 2012-01-26 20:37       ` Maupin, Chase
  0 siblings, 0 replies; 5+ messages in thread
From: Maupin, Chase @ 2012-01-26 20:37 UTC (permalink / raw)
  To: Philip Balister, Koen Kooi; +Cc: Ben Hilburn, meta-ti

Philip,

We use the dto=14 setting in the AMSDK from TI because this calculation only seems to work 50% of the time.  So I would be find with ditching the calculation altogether.

Sincerely,
Chase Maupin
Software Applications
ARM MPU
e-mail: chase.maupin@ti.com
phone: (214) 567-2950

For support:
Forums - http://community.ti.com/forums/
Wiki - http://wiki.davincidsp.com/ 


> -----Original Message-----
> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> bounces@yoctoproject.org] On Behalf Of Philip Balister
> Sent: Thursday, January 26, 2012 2:35 PM
> To: Koen Kooi
> Cc: Ben Hilburn; meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti] [PATCH] linux-ti33x-psp 3.1: add dto patch
> to fix problems with various sd cards
> 
> On 01/26/2012 01:12 PM, Koen Kooi wrote:
> >
> > Op 26 jan. 2012, om 19:01 heeft Tom Rini het volgende geschreven:
> >
> >> On Thu, Jan 26, 2012 at 10:38 AM, Koen Kooi
> <koen@dominion.thruhere.net> wrote:
> >>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >>
> >> I know the patch isn't yours but should we perhaps go in and
> make the
> >> patch more obvious?  The function we're patching does a lot of
> >> guesswork to find 'dto' and then we just say 'use the max'.  Why
> not
> >> also go rip out that logic?
> >
> > I was having the same conversation with Philip Balister on IRC
> just now :) It seems that this patch is being used by various TI
> customers to magically fix things so we do need to come up with a
> proper solution.
> 
> Basically, we are pissed of with really annoying SD card failures.
> (This
> is an understatement, the problem cost me a lot of sleep at ELCE)
> 
> Unless someone has a better solution, we should rip out the hairy
> calculation and set dto to 14 al the time and send the patch
> upstream.
> Does anyone see any reason not to do this?
> 
> Philip
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-01-26 20:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-26 17:38 [PATCH] linux-ti33x-psp 3.1: add dto patch to fix problems with various sd cards Koen Kooi
2012-01-26 18:01 ` Tom Rini
2012-01-26 18:12   ` Koen Kooi
2012-01-26 20:35     ` Philip Balister
2012-01-26 20:37       ` Maupin, Chase

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.