All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wei, Gang" <gang.wei@intel.com>
To: Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@novell.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: "Wei, Gang" <gang.wei@intel.com>
Subject: RE: [PATCH] x86: suppress HPET broadcast initialization in the presence of ARAT
Date: Sat, 12 Feb 2011 16:46:46 +0800	[thread overview]
Message-ID: <F26D193E20BBDC42A43B611D1BDEDE71259BBC1104@shsmsx502.ccr.corp.intel.com> (raw)
In-Reply-To: <C97BE8BA.133DE%keir@xen.org>

Keir Fraser wrote on 2011-02-12:
> On 12/02/2011 07:15, "Wei, Gang" <gang.wei@intel.com> wrote:
>> Jan Beulich wrote on 2011-02-10:
>>> This follows Linux commit 39fe05e58c5e448601ce46e6b03900d5bf31c4b0,
>>> noticing that all this setup is pointless when ARAT support is
>>> there, and knowing that on SLED11's native kernel it has actually
>>> caused S3 resume issues.
>> 
>> Although this patch was already checked in, I still have to say it
>> is not necessary for Xen. Because hpet_broadcast_init() fn is only
>> called if (xen_cpuidle && !boot_cpu_has(X86_FEATURE_ARAT)) in
>> disable_pit_irq(). Of course I agree to keep it as a never used double check.
> 
> Hmm I didn't spot that. Actually it is part of a more complex series
> of checks in the caller, so I wonder whether repeating just that one
> check in the function itself really makes much sense. I'm somewhat inclibned to revert it.

Revert it would be better.

Jimmy

  reply	other threads:[~2011-02-12  8:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 13:58 [PATCH] x86: suppress HPET broadcast initialization in the presence of ARAT Jan Beulich
2011-02-12  7:15 ` Wei, Gang
2011-02-12  7:35   ` Keir Fraser
2011-02-12  8:46     ` Wei, Gang [this message]
2011-02-14  8:15     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F26D193E20BBDC42A43B611D1BDEDE71259BBC1104@shsmsx502.ccr.corp.intel.com \
    --to=gang.wei@intel.com \
    --cc=JBeulich@novell.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.