From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Kuogee Hsieh <quic_khsieh@quicinc.com>, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@linux.ie, agross@kernel.org, bjorn.andersson@linaro.org Cc: quic_sbillaka@quicinc.com, linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org, quic_khsieh@quicinc.com, quic_aravindh@quicinc.com, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm/dp: make eDP panel as the first connected connector Date: Tue, 28 Jun 2022 23:13:56 +0300 [thread overview] Message-ID: <F35C87BF-46A5-41D3-B8A5-B2AB4A24252D@linaro.org> (raw) In-Reply-To: <1656429606-2765-1-git-send-email-quic_khsieh@quicinc.com> On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote: >Some userspace presumes that the first connected connector is the main >display, where it's supposed to display e.g. the login screen. For >laptops, this should be the main panel. > >This patch call drm_helper_move_panel_connectors_to_head() after >drm_bridge_connector_init() to make sure eDP stay at head of >connected connector list. This fixes unexpected corruption happen >at eDP panel if eDP is not placed at head of connected connector >list. The change itself is a good fix anyway. (And I'd ack it.) However I would like to understand why does it fix the corruption issue. What is we have eDP and DSI, with DSI ending up before the eDP? Would we see the issue? Also could you please describe the mind of corruption you are observing? > >Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> >--- > drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c >index ce0ec3a..2d18884 100644 >--- a/drivers/gpu/drm/msm/dp/dp_drm.c >+++ b/drivers/gpu/drm/msm/dp/dp_drm.c >@@ -136,5 +136,7 @@ struct drm_connector *dp_drm_connector_init(struct msm_dp *dp_display) > > drm_connector_attach_encoder(connector, dp_display->encoder); > >+ drm_helper_move_panel_connectors_to_head(dp_display->drm_dev); >+ > return connector; > }
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Kuogee Hsieh <quic_khsieh@quicinc.com>, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@linux.ie, agross@kernel.org, bjorn.andersson@linaro.org Cc: quic_abhinavk@quicinc.com, quic_aravindh@quicinc.com, quic_khsieh@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm/dp: make eDP panel as the first connected connector Date: Tue, 28 Jun 2022 23:13:56 +0300 [thread overview] Message-ID: <F35C87BF-46A5-41D3-B8A5-B2AB4A24252D@linaro.org> (raw) In-Reply-To: <1656429606-2765-1-git-send-email-quic_khsieh@quicinc.com> On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote: >Some userspace presumes that the first connected connector is the main >display, where it's supposed to display e.g. the login screen. For >laptops, this should be the main panel. > >This patch call drm_helper_move_panel_connectors_to_head() after >drm_bridge_connector_init() to make sure eDP stay at head of >connected connector list. This fixes unexpected corruption happen >at eDP panel if eDP is not placed at head of connected connector >list. The change itself is a good fix anyway. (And I'd ack it.) However I would like to understand why does it fix the corruption issue. What is we have eDP and DSI, with DSI ending up before the eDP? Would we see the issue? Also could you please describe the mind of corruption you are observing? > >Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> >--- > drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c >index ce0ec3a..2d18884 100644 >--- a/drivers/gpu/drm/msm/dp/dp_drm.c >+++ b/drivers/gpu/drm/msm/dp/dp_drm.c >@@ -136,5 +136,7 @@ struct drm_connector *dp_drm_connector_init(struct msm_dp *dp_display) > > drm_connector_attach_encoder(connector, dp_display->encoder); > >+ drm_helper_move_panel_connectors_to_head(dp_display->drm_dev); >+ > return connector; > }
next prev parent reply other threads:[~2022-06-28 20:14 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-28 15:20 [PATCH] drm/msm/dp: make eDP panel as the first connected connector Kuogee Hsieh 2022-06-28 15:20 ` Kuogee Hsieh 2022-06-28 20:13 ` Dmitry Baryshkov [this message] 2022-06-28 20:13 ` Dmitry Baryshkov 2022-06-30 0:36 ` Doug Anderson 2022-06-30 0:36 ` Doug Anderson 2022-06-30 1:57 ` Rob Clark 2022-06-30 1:57 ` Rob Clark 2022-06-30 2:10 ` [Freedreno] " Abhinav Kumar 2022-06-30 2:10 ` Abhinav Kumar 2022-06-30 6:14 ` Dmitry Baryshkov 2022-06-30 6:14 ` Dmitry Baryshkov 2022-07-04 18:14 ` Dmitry Baryshkov 2022-07-04 18:14 ` Dmitry Baryshkov 2022-07-05 5:41 ` [Freedreno] " Abhinav Kumar 2022-07-05 5:41 ` Abhinav Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=F35C87BF-46A5-41D3-B8A5-B2AB4A24252D@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=agross@kernel.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_aravindh@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.