From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Yang, Zhiyong" <zhiyong.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v2] librte_mbuf: modify port initialization value
Date: Tue, 5 Sep 2017 05:20:35 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ABBA686@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170905051319.11223-1-zhiyong.yang@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang
> Sent: Tuesday, September 5, 2017 1:13 PM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Yigit, Ferruh; stephen@networkplumber.org; Yang,
> Zhiyong
> Subject: [dpdk-dev] [PATCH v2] librte_mbuf: modify port initialization value
>
> In order to support more than 256 virtual ports, the field "port"
> in rte_mbuf has been increased to 16 bits. The initialization/reset value of the
> field "port" should be changed from 0xff to 0xffff accordingly.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
>
> Changes in V2:
> Introduce MBUF_INVALID_PORT as a constant.
>
> lib/librte_mbuf/rte_mbuf.c | 2 +-
> lib/librte_mbuf/rte_mbuf.h | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index
> 26a62b8e1..bcf4e2fcf 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
> /* init some constant fields */
> m->pool = mp;
> m->nb_segs = 1;
> - m->port = 0xff;
> + m->port = MBUF_INVALID_PORT;
> rte_mbuf_refcnt_set(m, 1);
> m->next = NULL;
> }
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index
> eaed7eee0..e32038a73 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1087,6 +1087,8 @@ static inline void
> rte_pktmbuf_reset_headroom(struct rte_mbuf *m)
> * @param m
> * The packet mbuf to be resetted.
> */
> +#define MBUF_INVALID_PORT 0xffff
Replaced with below, or use UINT16_MAX directly?
#define MBUF_INVALID_PORT UINT16_MAX
> +
> static inline void rte_pktmbuf_reset(struct rte_mbuf *m) {
> m->next = NULL;
> @@ -1095,7 +1097,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf
> *m)
> m->vlan_tci = 0;
> m->vlan_tci_outer = 0;
> m->nb_segs = 1;
> - m->port = 0xff;
> + m->port = MBUF_INVALID_PORT;
>
> m->ol_flags = 0;
> m->packet_type = 0;
> --
> 2.13.3
next prev parent reply other threads:[~2017-09-05 5:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 6:55 [PATCH] librte_mbuf: modify the port initialization value Zhiyong Yang
2017-09-05 3:39 ` Stephen Hemminger
2017-09-05 4:28 ` Yang, Zhiyong
2017-09-05 5:13 ` [PATCH v2] librte_mbuf: modify " Zhiyong Yang
2017-09-05 5:20 ` Zhang, Helin [this message]
2017-09-06 0:42 ` Yang, Zhiyong
2017-09-05 7:28 ` Thomas Monjalon
2017-09-05 12:30 ` Yang, Zhiyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71ABBA686@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.