* [patch -next] bna: off by one
@ 2010-09-18 23:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-09-18 23:41 UTC (permalink / raw)
To: Rasesh Mody; +Cc: Debashis Dutt, David S. Miller, netdev, kernel-janitors
The mod->mbhdlr[] array has BFI_MC_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/bna/bfa_ioc.c b/drivers/net/bna/bfa_ioc.c
index caa45c2..73493de 100644
--- a/drivers/net/bna/bfa_ioc.c
+++ b/drivers/net/bna/bfa_ioc.c
@@ -1514,7 +1514,7 @@ bfa_nw_ioc_mbox_isr(struct bfa_ioc *ioc)
return;
}
- if ((mc > BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn == NULL))
+ if ((mc >= BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn == NULL))
return;
mod->mbhdlr[mc].cbfn(mod->mbhdlr[mc].cbarg, &m);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch -next] bna: off by one
@ 2010-09-18 23:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-09-18 23:41 UTC (permalink / raw)
To: Rasesh Mody; +Cc: Debashis Dutt, David S. Miller, netdev, kernel-janitors
The mod->mbhdlr[] array has BFI_MC_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/bna/bfa_ioc.c b/drivers/net/bna/bfa_ioc.c
index caa45c2..73493de 100644
--- a/drivers/net/bna/bfa_ioc.c
+++ b/drivers/net/bna/bfa_ioc.c
@@ -1514,7 +1514,7 @@ bfa_nw_ioc_mbox_isr(struct bfa_ioc *ioc)
return;
}
- if ((mc > BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn = NULL))
+ if ((mc >= BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn = NULL))
return;
mod->mbhdlr[mc].cbfn(mod->mbhdlr[mc].cbarg, &m);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [patch -next] bna: off by one
2010-09-18 23:41 ` Dan Carpenter
@ 2010-09-19 0:48 ` Debashis Dutt
-1 siblings, 0 replies; 6+ messages in thread
From: Debashis Dutt @ 2010-09-19 0:48 UTC (permalink / raw)
To: Dan Carpenter, David S. Miller; +Cc: Rasesh Mody, netdev, kernel-janitors
-----Original Message-----
From: Dan Carpenter [mailto:error27@gmail.com]
Sent: Saturday, September 18, 2010 4:42 PM
To: Rasesh Mody
Cc: Debashis Dutt; David S. Miller; netdev@vger.kernel.org; kernel-janitors@vger.kernel.org
Subject: [patch -next] bna: off by one
The mod->mbhdlr[] array has BFI_MC_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/bna/bfa_ioc.c b/drivers/net/bna/bfa_ioc.c
index caa45c2..73493de 100644
--- a/drivers/net/bna/bfa_ioc.c
+++ b/drivers/net/bna/bfa_ioc.c
@@ -1514,7 +1514,7 @@ bfa_nw_ioc_mbox_isr(struct bfa_ioc *ioc)
return;
}
- if ((mc > BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn == NULL))
+ if ((mc >= BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn == NULL))
return;
mod->mbhdlr[mc].cbfn(mod->mbhdlr[mc].cbarg, &m);
Dan,
Patch looks good.
Thanks
--Debashis
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [patch -next] bna: off by one
@ 2010-09-19 0:48 ` Debashis Dutt
0 siblings, 0 replies; 6+ messages in thread
From: Debashis Dutt @ 2010-09-19 0:48 UTC (permalink / raw)
To: Dan Carpenter, David S. Miller; +Cc: Rasesh Mody, netdev, kernel-janitors
-----Original Message-----
From: Dan Carpenter [mailto:error27@gmail.com]
Sent: Saturday, September 18, 2010 4:42 PM
To: Rasesh Mody
Cc: Debashis Dutt; David S. Miller; netdev@vger.kernel.org; kernel-janitors@vger.kernel.org
Subject: [patch -next] bna: off by one
The mod->mbhdlr[] array has BFI_MC_MAX elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/bna/bfa_ioc.c b/drivers/net/bna/bfa_ioc.c
index caa45c2..73493de 100644
--- a/drivers/net/bna/bfa_ioc.c
+++ b/drivers/net/bna/bfa_ioc.c
@@ -1514,7 +1514,7 @@ bfa_nw_ioc_mbox_isr(struct bfa_ioc *ioc)
return;
}
- if ((mc > BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn = NULL))
+ if ((mc >= BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn = NULL))
return;
mod->mbhdlr[mc].cbfn(mod->mbhdlr[mc].cbarg, &m);
Dan,
Patch looks good.
Thanks
--Debashis
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch -next] bna: off by one
2010-09-18 23:41 ` Dan Carpenter
@ 2010-09-19 18:26 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-09-19 18:26 UTC (permalink / raw)
To: error27; +Cc: rmody, ddutt, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Sun, 19 Sep 2010 01:41:44 +0200
> The mod->mbhdlr[] array has BFI_MC_MAX elements.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] bna: off by one
@ 2010-09-19 18:26 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-09-19 18:26 UTC (permalink / raw)
To: error27; +Cc: rmody, ddutt, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Sun, 19 Sep 2010 01:41:44 +0200
> The mod->mbhdlr[] array has BFI_MC_MAX elements.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-19 18:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-18 23:41 [patch -next] bna: off by one Dan Carpenter
2010-09-18 23:41 ` Dan Carpenter
2010-09-19 0:48 ` Debashis Dutt
2010-09-19 0:48 ` Debashis Dutt
2010-09-19 18:26 ` David Miller
2010-09-19 18:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.