RE: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow

["Wang, Zhi A" <zhi.a.wang@intel.com>]

Hi：
    Thanks for the patch. This problem has been fixed on staging branch with:

a8e18bfc854141621a29600a6c13e5f40c6e9f19

drm/i915/gvt: Refine shadow batch buffer

Thanks,
Zhi.

-----Original Message-----
From: Christos Gkekas [mailto:chris.gekas@gmail.com] 
Sent: Monday, October 16, 2017 1:18 AM
To: Gao, Fred <fred.gao@intel.com>; Zhenyu Wang <zhenyuw@linux.intel.com>; Wang, Zhi A <zhi.a.wang@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; David Airlie <airlied@linux.ie>; intel-gvt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Cc: Christos Gkekas <chris.gekas@gmail.com>
Subject: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow

Change the type of variable 'bb_size' from uint32_t to int to be able to hold error return values from find_bb_size(). This change seems to have been missed from previous commit 1e3197d6ad73.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
 drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 2c0ccbb..f41cbf6 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s)
 	struct intel_shadow_bb_entry *entry_obj;
 	struct intel_vgpu *vgpu = s->vgpu;
 	unsigned long gma = 0;
-	uint32_t bb_size;
+	int bb_size;
 	void *dst = NULL;
 	int ret = 0;
 
--
2.7.4