All of lore.kernel.org
 help / color / mirror / Atom feed
* [Fuego] [PATCH 07/18] repair test program build script
@ 2017-10-13 10:06 Song Cai
  2017-10-17  1:22 ` Bird, Timothy
  0 siblings, 1 reply; 5+ messages in thread
From: Song Cai @ 2017-10-13 10:06 UTC (permalink / raw)
  To: fuego

The program CppServer and CppClient depend on the header file config.h,
which is generate in thrift configure prin thrift process.
So add the step to build thrift library, generating config.h file.

Signed-off-by: Song Cai <cais.fnst@cn.fujitsu.com>
---
 engine/tests/Functional.thrift/fuego_test.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/engine/tests/Functional.thrift/fuego_test.sh b/engine/tests/Functional.thrift/fuego_test.sh
index 3b52b4a..da41535 100755
--- a/engine/tests/Functional.thrift/fuego_test.sh
+++ b/engine/tests/Functional.thrift/fuego_test.sh
@@ -1,6 +1,10 @@
 tarball=thrift-0.9.3.tar.gz
 
 function test_build {
+    cd git/build
+    cmake -DBUILD_COMPILER=OFF -DBUILD_LIBRARIES=ON -DBUILD_TESTING=OFF -DBUILD_EXAMPLES=OFF -DWITH_QT4=NO -DWITH_QT5=NO ..
+    make
+    cd -
     echo "#!/bin/bash
     tar zxf git.tar.gz
     cd git/tutorial
@@ -128,8 +132,8 @@ function test_run {
     tar zxf gen-cpp.tar.gz -C git/tutorial/;
     cd git/tutorial/cpp
     CPPFILES="../gen-cpp/shared_types.cpp ../gen-cpp/tutorial_types.cpp ../gen-cpp/tutorial_constants.cpp ../gen-cpp/Calculator.cpp ../gen-cpp/SharedService.cpp"
-    ${CXX} CppServer.cpp ${CPPFILES} -o CppServer -I../../lib/cpp/src/ -lthrift
-    ${CXX} CppClient.cpp ${CPPFILES} -o CppClient -I../../lib/cpp/src/ -lthrift
+    ${CXX} CppServer.cpp ${CPPFILES} -o CppServer -I../../lib/cpp/src/ -I../../build -L../../build/lib -lthrift
+    ${CXX} CppClient.cpp ${CPPFILES} -o CppClient -I../../lib/cpp/src/ -I../../build -L../../build/lib -lthrift
     put CppServer CppClient $BOARD_TESTDIR/fuego.$TESTDIR/
     report "cd $BOARD_TESTDIR/fuego.$TESTDIR; \
     sh -v run-tests.sh 2>&1"
-- 
2.9.3.windows.3




^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Fuego] [PATCH 07/18] repair test program build script
  2017-10-13 10:06 [Fuego] [PATCH 07/18] repair test program build script Song Cai
@ 2017-10-17  1:22 ` Bird, Timothy
  2017-10-17  1:28   ` Bird, Timothy
  0 siblings, 1 reply; 5+ messages in thread
From: Bird, Timothy @ 2017-10-17  1:22 UTC (permalink / raw)
  To: Song Cai, fuego



> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Song Cai
> Sent: Friday, October 13, 2017 3:07 AM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 07/18] repair test program build script
> 
> The program CppServer and CppClient depend on the header file config.h,
> which is generate in thrift configure prin thrift process.
> So add the step to build thrift library, generating config.h file.
> 
> Signed-off-by: Song Cai <cais.fnst@cn.fujitsu.com>
> ---
>  engine/tests/Functional.thrift/fuego_test.sh | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/engine/tests/Functional.thrift/fuego_test.sh
> b/engine/tests/Functional.thrift/fuego_test.sh
> index 3b52b4a..da41535 100755
> --- a/engine/tests/Functional.thrift/fuego_test.sh
> +++ b/engine/tests/Functional.thrift/fuego_test.sh
> @@ -1,6 +1,10 @@
>  tarball=thrift-0.9.3.tar.gz
> 
>  function test_build {
> +    cd git/build
> +    cmake -DBUILD_COMPILER=OFF -DBUILD_LIBRARIES=ON -
> DBUILD_TESTING=OFF -DBUILD_EXAMPLES=OFF -DWITH_QT4=NO -
> DWITH_QT5=NO ..
> +    make
> +    cd -
>      echo "#!/bin/bash
>      tar zxf git.tar.gz
>      cd git/tutorial
> @@ -128,8 +132,8 @@ function test_run {
>      tar zxf gen-cpp.tar.gz -C git/tutorial/;
>      cd git/tutorial/cpp
>      CPPFILES="../gen-cpp/shared_types.cpp ../gen-cpp/tutorial_types.cpp
> ../gen-cpp/tutorial_constants.cpp ../gen-cpp/Calculator.cpp ../gen-
> cpp/SharedService.cpp"
> -    ${CXX} CppServer.cpp ${CPPFILES} -o CppServer -I../../lib/cpp/src/ -lthrift
> -    ${CXX} CppClient.cpp ${CPPFILES} -o CppClient -I../../lib/cpp/src/ -lthrift
> +    ${CXX} CppServer.cpp ${CPPFILES} -o CppServer -I../../lib/cpp/src/ -
> I../../build -L../../build/lib -lthrift
> +    ${CXX} CppClient.cpp ${CPPFILES} -o CppClient -I../../lib/cpp/src/ -
> I../../build -L../../build/lib -lthrift
>      put CppServer CppClient $BOARD_TESTDIR/fuego.$TESTDIR/
>      report "cd $BOARD_TESTDIR/fuego.$TESTDIR; \
>      sh -v run-tests.sh 2>&1"
> --
> 2.9.3.windows.3

This looks OK, but I wasn't able to run the final results, as I don't
have a target with thrift on it.  It would be good to add a 
test_pre_check with is_on_target for 'thrift'.

Since it uses cmake, I added a patch in the fuego repository
to add the 'cmake' package to the docker container.  This might
be needed by other tests.

Once again, I assume that AGL includes thrift by default.

I'm applying this.

Thanks!
 -- Tim


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Fuego] [PATCH 07/18] repair test program build script
  2017-10-17  1:22 ` Bird, Timothy
@ 2017-10-17  1:28   ` Bird, Timothy
  2017-10-23  7:46     ` Liu, Wenlong
  0 siblings, 1 reply; 5+ messages in thread
From: Bird, Timothy @ 2017-10-17  1:28 UTC (permalink / raw)
  To: Bird, Timothy, Song Cai, fuego



The patch series is missing the following patches:
 PATCH 08/18
 PATCH 11/18
 PATCH 18/18

I didn't receive these by e-mail, and not in the archives on the mailing list.
See https://lists.linuxfoundation.org/pipermail/fuego/2017-October/thread.html

Did they get rejected, or did you miss sending them?

 -- Tim

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Fuego] [PATCH 07/18] repair test program build script
  2017-10-17  1:28   ` Bird, Timothy
@ 2017-10-23  7:46     ` Liu, Wenlong
  0 siblings, 0 replies; 5+ messages in thread
From: Liu, Wenlong @ 2017-10-23  7:46 UTC (permalink / raw)
  To: Bird, Timothy, Cai, Song, fuego

Hi,

> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org
> [mailto:fuego-bounces@lists.linuxfoundation.org] On Behalf Of Bird,
> Timothy
> Sent: Tuesday, October 17, 2017 9:28 AM
> To: Bird, Timothy <Tim.Bird@sony.com>; Cai, Song/蔡 嵩
> <cais.fnst@cn.fujitsu.com>; fuego@lists.linuxfoundation.org
> Subject: Re: [Fuego] [PATCH 07/18] repair test program build script
> 
> 
> 
> The patch series is missing the following patches:
>  PATCH 08/18
>  PATCH 11/18
>  PATCH 18/18
> 
> I didn't receive these by e-mail, and not in the archives on the mailing
> list.
> See
> https://lists.linuxfoundation.org/pipermail/fuego/2017-October/thread.
> html
> 
> Did they get rejected, or did you miss sending them?

Thanks for your review.
About your comments about those patches, I will try to improve and resubmit them.

It might take me some time because I also have some other things to be done.
But I'll resubmit it as soon as possible.

Best regards
Liu

>  -- Tim
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego
> 




^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Fuego] [PATCH 07/18] repair test program build script
  2017-10-13  9:45 [Fuego] [PATCH 01/18] remove extra word in command Song Cai
@ 2017-10-13  9:45 ` Song Cai
  0 siblings, 0 replies; 5+ messages in thread
From: Song Cai @ 2017-10-13  9:45 UTC (permalink / raw)
  To: fuego

The program CppServer and CppClient depend on the header file config.h,
which is generate in thrift configure prin thrift process.
So add the step to build thrift library, generating config.h file.

Signed-off-by: Song Cai <cais.fnst@cn.fujitsu.com>
---
 engine/tests/Functional.thrift/fuego_test.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/engine/tests/Functional.thrift/fuego_test.sh b/engine/tests/Functional.thrift/fuego_test.sh
index 3b52b4a..da41535 100755
--- a/engine/tests/Functional.thrift/fuego_test.sh
+++ b/engine/tests/Functional.thrift/fuego_test.sh
@@ -1,6 +1,10 @@
 tarball=thrift-0.9.3.tar.gz
 
 function test_build {
+    cd git/build
+    cmake -DBUILD_COMPILER=OFF -DBUILD_LIBRARIES=ON -DBUILD_TESTING=OFF -DBUILD_EXAMPLES=OFF -DWITH_QT4=NO -DWITH_QT5=NO ..
+    make
+    cd -
     echo "#!/bin/bash
     tar zxf git.tar.gz
     cd git/tutorial
@@ -128,8 +132,8 @@ function test_run {
     tar zxf gen-cpp.tar.gz -C git/tutorial/;
     cd git/tutorial/cpp
     CPPFILES="../gen-cpp/shared_types.cpp ../gen-cpp/tutorial_types.cpp ../gen-cpp/tutorial_constants.cpp ../gen-cpp/Calculator.cpp ../gen-cpp/SharedService.cpp"
-    ${CXX} CppServer.cpp ${CPPFILES} -o CppServer -I../../lib/cpp/src/ -lthrift
-    ${CXX} CppClient.cpp ${CPPFILES} -o CppClient -I../../lib/cpp/src/ -lthrift
+    ${CXX} CppServer.cpp ${CPPFILES} -o CppServer -I../../lib/cpp/src/ -I../../build -L../../build/lib -lthrift
+    ${CXX} CppClient.cpp ${CPPFILES} -o CppClient -I../../lib/cpp/src/ -I../../build -L../../build/lib -lthrift
     put CppServer CppClient $BOARD_TESTDIR/fuego.$TESTDIR/
     report "cd $BOARD_TESTDIR/fuego.$TESTDIR; \
     sh -v run-tests.sh 2>&1"
-- 
2.9.3.windows.3




^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-23  7:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 10:06 [Fuego] [PATCH 07/18] repair test program build script Song Cai
2017-10-17  1:22 ` Bird, Timothy
2017-10-17  1:28   ` Bird, Timothy
2017-10-23  7:46     ` Liu, Wenlong
  -- strict thread matches above, loose matches on Subject: below --
2017-10-13  9:45 [Fuego] [PATCH 01/18] remove extra word in command Song Cai
2017-10-13  9:45 ` [Fuego] [PATCH 07/18] repair test program build script Song Cai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.