[PATCH 2/2] virtio: fix build with debug enabled

[PATCH 2/2] virtio: fix build with debug enabled

[Stephen Hemminger]

Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined.
virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]

Signed-off-by: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>

--- a/lib/librte_pmd_virtio/virtio_ethdev.c	2014-06-10 15:30:23.440093214 -0700
+++ b/lib/librte_pmd_virtio/virtio_ethdev.c	2014-06-10 15:30:23.436093187 -0700
@@ -213,8 +213,6 @@ virtio_set_multiple_queues(struct rte_et
 	ctrl.hdr.cmd = VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET;
 	memcpy(ctrl.data, &nb_queues, sizeof(uint16_t));
 
-	PMD_INIT_LOG(DEBUG, "ctrl.data=%d\n", *(int *)ctrl.data);
-
 	dlen[0] = sizeof(uint16_t);
 
 	ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1);

Re: [PATCH 2/2] virtio: fix build with debug enabled

[Ouyang, Changchun]

Acked by Changchun Ouyang

-----Original Message-----
From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Stephen Hemminger
Sent: Friday, June 13, 2014 9:33 AM
To: Stephen Hemminger
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled

Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined.
virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]

Signed-off-by: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>

--- a/lib/librte_pmd_virtio/virtio_ethdev.c	2014-06-10 15:30:23.440093214 -0700
+++ b/lib/librte_pmd_virtio/virtio_ethdev.c	2014-06-10 15:30:23.436093187 -0700
@@ -213,8 +213,6 @@ virtio_set_multiple_queues(struct rte_et
 	ctrl.hdr.cmd = VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET;
 	memcpy(ctrl.data, &nb_queues, sizeof(uint16_t));
 
-	PMD_INIT_LOG(DEBUG, "ctrl.data=%d\n", *(int *)ctrl.data);
-
 	dlen[0] = sizeof(uint16_t);
 
 	ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1);

Re: [PATCH 2/2] virtio: fix build with debug enabled

[Thomas Monjalon]

2014-06-12 18:32, Stephen Hemminger:
> Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined.
> virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
> 
> Signed-off-by: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>

Acked-by: Changchun Ouyang <changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Applied for version 1.7.0.

Thanks
-- 
Thomas