All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] qla2xxx: Patches for 3.9-rc.
@ 2013-03-09 11:04 Chad Dupuis
  2013-03-09 11:04 ` [PATCH 1/4] Revert "qla2xxx: Add setting of driver version string for vendor application." Chad Dupuis
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Chad Dupuis @ 2013-03-09 11:04 UTC (permalink / raw)
  To: jbottomley; +Cc: giridhar.malavali, saurav.kashyap, andrew.vasquez, linux-scsi

Hi James,

Please apply the following patches for 3.9-rc.

Thanks,
~Saurav
 

Arun Easi (1):
  qla2xxx: Fix crash during firmware dump procedure.

Joe Carnuccio (1):
  Revert "qla2xxx: Add setting of driver version string for vendor
    application."

Saurav Kashyap (2):
  qla2xxx: Update copyright information in LICENSE.qla2xxx file.
  qla2xxx: Update the driver version to 8.04.00.13-k.

 Documentation/scsi/LICENSE.qla2xxx |    2 +-
 drivers/scsi/qla2xxx/qla_dbg.c     |    3 +-
 drivers/scsi/qla2xxx/qla_def.h     |    1 -
 drivers/scsi/qla2xxx/qla_gbl.h     |    3 --
 drivers/scsi/qla2xxx/qla_init.c    |    4 +--
 drivers/scsi/qla2xxx/qla_mbx.c     |   58 ------------------------------------
 drivers/scsi/qla2xxx/qla_version.h |    2 +-
 7 files changed, 5 insertions(+), 68 deletions(-)

-- 
1.7.7


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/4] Revert "qla2xxx: Add setting of driver version string for vendor application."
  2013-03-09 11:04 [PATCH 0/4] qla2xxx: Patches for 3.9-rc Chad Dupuis
@ 2013-03-09 11:04 ` Chad Dupuis
  2013-03-09 11:04 ` [PATCH 2/4] qla2xxx: Fix crash during firmware dump procedure Chad Dupuis
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Chad Dupuis @ 2013-03-09 11:04 UTC (permalink / raw)
  To: jbottomley; +Cc: giridhar.malavali, saurav.kashyap, andrew.vasquez, linux-scsi

From: Joe Carnuccio <joe.carnuccio@qlogic.com>

The original patch was not covering all the adapters and firmwares.

This commit reverts 3a11711ad00caebee07e262d188cea66f3473c38.

Signed-off-by: Joe Carnuccio <joe.carnuccio@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
---
 drivers/scsi/qla2xxx/qla_dbg.c  |    1 +
 drivers/scsi/qla2xxx/qla_def.h  |    1 -
 drivers/scsi/qla2xxx/qla_gbl.h  |    3 --
 drivers/scsi/qla2xxx/qla_init.c |    2 -
 drivers/scsi/qla2xxx/qla_mbx.c  |   58 ---------------------------------------
 5 files changed, 1 insertions(+), 64 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
index 1626de5..2bf0214 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -15,6 +15,7 @@
  * | Mailbox commands             |       0x115b       | 0x111a-0x111b  |
  * |                              |                    | 0x112c-0x112e  |
  * |                              |                    | 0x113a         |
+ * |                              |                    | 0x1155-0x1158  |
  * | Device Discovery             |       0x2087       | 0x2020-0x2022, |
  * |                              |                    | 0x2016         |
  * | Queue Command and IO tracing |       0x3031       | 0x3006-0x300b  |
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index c650991..65c5ff7 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -863,7 +863,6 @@ typedef struct {
 #define	MBX_1		BIT_1
 #define	MBX_0		BIT_0
 
-#define RNID_TYPE_SET_VERSION	0x9
 #define RNID_TYPE_ASIC_TEMP	0xC
 
 /*
diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h
index eb3ca21..b310fa9 100644
--- a/drivers/scsi/qla2xxx/qla_gbl.h
+++ b/drivers/scsi/qla2xxx/qla_gbl.h
@@ -358,9 +358,6 @@ extern int
 qla2x00_disable_fce_trace(scsi_qla_host_t *, uint64_t *, uint64_t *);
 
 extern int
-qla2x00_set_driver_version(scsi_qla_host_t *, char *);
-
-extern int
 qla2x00_read_sfp(scsi_qla_host_t *, dma_addr_t, uint8_t *,
 	uint16_t, uint16_t, uint16_t, uint16_t);
 
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index edf4d14..09eae54 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -619,8 +619,6 @@ qla2x00_initialize_adapter(scsi_qla_host_t *vha)
 	if (IS_QLA24XX_TYPE(ha) || IS_QLA25XX(ha))
 		qla24xx_read_fcp_prio_cfg(vha);
 
-	qla2x00_set_driver_version(vha, QLA2XXX_VERSION);
-
 	return (rval);
 }
 
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 186dd59..43345af 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -3866,64 +3866,6 @@ qla81xx_restart_mpi_firmware(scsi_qla_host_t *vha)
 	return rval;
 }
 
-int
-qla2x00_set_driver_version(scsi_qla_host_t *vha, char *version)
-{
-	int rval;
-	mbx_cmd_t mc;
-	mbx_cmd_t *mcp = &mc;
-	int len;
-	uint16_t dwlen;
-	uint8_t *str;
-	dma_addr_t str_dma;
-	struct qla_hw_data *ha = vha->hw;
-
-	if (!IS_FWI2_CAPABLE(ha) || IS_QLA82XX(ha))
-		return QLA_FUNCTION_FAILED;
-
-	ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1155,
-	    "Entered %s.\n", __func__);
-
-	str = dma_pool_alloc(ha->s_dma_pool, GFP_KERNEL, &str_dma);
-	if (!str) {
-		ql_log(ql_log_warn, vha, 0x1156,
-		    "Failed to allocate driver version param.\n");
-		return QLA_MEMORY_ALLOC_FAILED;
-	}
-
-	memcpy(str, "\x7\x3\x11\x0", 4);
-	dwlen = str[0];
-	len = dwlen * sizeof(uint32_t) - 4;
-	memset(str + 4, 0, len);
-	if (len > strlen(version))
-		len = strlen(version);
-	memcpy(str + 4, version, len);
-
-	mcp->mb[0] = MBC_SET_RNID_PARAMS;
-	mcp->mb[1] = RNID_TYPE_SET_VERSION << 8 | dwlen;
-	mcp->mb[2] = MSW(LSD(str_dma));
-	mcp->mb[3] = LSW(LSD(str_dma));
-	mcp->mb[6] = MSW(MSD(str_dma));
-	mcp->mb[7] = LSW(MSD(str_dma));
-	mcp->out_mb = MBX_7|MBX_6|MBX_3|MBX_2|MBX_1|MBX_0;
-	mcp->in_mb = MBX_0;
-	mcp->tov = MBX_TOV_SECONDS;
-	mcp->flags = 0;
-	rval = qla2x00_mailbox_command(vha, mcp);
-
-	if (rval != QLA_SUCCESS) {
-		ql_dbg(ql_dbg_mbx, vha, 0x1157,
-		    "Failed=%x mb[0]=%x.\n", rval, mcp->mb[0]);
-	} else {
-		ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1158,
-		    "Done %s.\n", __func__);
-	}
-
-	dma_pool_free(ha->s_dma_pool, str, str_dma);
-
-	return rval;
-}
-
 static int
 qla2x00_read_asic_temperature(scsi_qla_host_t *vha, uint16_t *temp)
 {
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/4] qla2xxx: Fix crash during firmware dump procedure.
  2013-03-09 11:04 [PATCH 0/4] qla2xxx: Patches for 3.9-rc Chad Dupuis
  2013-03-09 11:04 ` [PATCH 1/4] Revert "qla2xxx: Add setting of driver version string for vendor application." Chad Dupuis
@ 2013-03-09 11:04 ` Chad Dupuis
  2013-03-09 11:04 ` [PATCH 3/4] qla2xxx: Update copyright information in LICENSE.qla2xxx file Chad Dupuis
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Chad Dupuis @ 2013-03-09 11:04 UTC (permalink / raw)
  To: jbottomley; +Cc: giridhar.malavali, saurav.kashyap, andrew.vasquez, linux-scsi

From: Arun Easi <arun.easi@qlogic.com>

System crashes, in initiator mode operation, with
qla2xxx_copy_atioqueues() in stack trace when firmware dump is
attempted.

Check for atio_q_length alone does not indicate if atio_ring is
allocated, make explicit check of atio_ring to avoid the crash.

Applicable to 24XX, 25XX, 81XX & 83XX line of HBAs.

Signed-off-by: Arun Easi <arun.easi@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
---
 drivers/scsi/qla2xxx/qla_dbg.c  |    2 +-
 drivers/scsi/qla2xxx/qla_init.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
index 2bf0214..fbc305f 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -402,7 +402,7 @@ qla2xxx_copy_atioqueues(struct qla_hw_data *ha, void *ptr,
 		void *ring;
 	} aq, *aqp;
 
-	if (!ha->tgt.atio_q_length)
+	if (!ha->tgt.atio_ring)
 		return ptr;
 
 	num_queues = 1;
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 09eae54..b592033 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -1397,7 +1397,7 @@ qla2x00_alloc_fw_dump(scsi_qla_host_t *vha)
 			mq_size += ha->max_rsp_queues *
 			    (rsp->length * sizeof(response_t));
 		}
-		if (ha->tgt.atio_q_length)
+		if (ha->tgt.atio_ring)
 			mq_size += ha->tgt.atio_q_length * sizeof(request_t);
 		/* Allocate memory for Fibre Channel Event Buffer. */
 		if (!IS_QLA25XX(ha) && !IS_QLA81XX(ha) && !IS_QLA83XX(ha))
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/4] qla2xxx: Update copyright information in LICENSE.qla2xxx file.
  2013-03-09 11:04 [PATCH 0/4] qla2xxx: Patches for 3.9-rc Chad Dupuis
  2013-03-09 11:04 ` [PATCH 1/4] Revert "qla2xxx: Add setting of driver version string for vendor application." Chad Dupuis
  2013-03-09 11:04 ` [PATCH 2/4] qla2xxx: Fix crash during firmware dump procedure Chad Dupuis
@ 2013-03-09 11:04 ` Chad Dupuis
  2013-03-09 11:04 ` [PATCH 4/4] qla2xxx: Update the driver version to 8.04.00.13-k Chad Dupuis
  2013-03-22 18:57 ` [PATCH 0/4] qla2xxx: Patches for 3.9-rc Saurav Kashyap
  4 siblings, 0 replies; 6+ messages in thread
From: Chad Dupuis @ 2013-03-09 11:04 UTC (permalink / raw)
  To: jbottomley; +Cc: giridhar.malavali, saurav.kashyap, andrew.vasquez, linux-scsi

From: Saurav Kashyap <saurav.kashyap@qlogic.com>

Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
---
 Documentation/scsi/LICENSE.qla2xxx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/scsi/LICENSE.qla2xxx b/Documentation/scsi/LICENSE.qla2xxx
index 27a91cf..5020b7b 100644
--- a/Documentation/scsi/LICENSE.qla2xxx
+++ b/Documentation/scsi/LICENSE.qla2xxx
@@ -1,4 +1,4 @@
-Copyright (c) 2003-2012 QLogic Corporation
+Copyright (c) 2003-2013 QLogic Corporation
 QLogic Linux FC-FCoE Driver
 
 This program includes a device driver for Linux 3.x.
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/4] qla2xxx: Update the driver version to 8.04.00.13-k.
  2013-03-09 11:04 [PATCH 0/4] qla2xxx: Patches for 3.9-rc Chad Dupuis
                   ` (2 preceding siblings ...)
  2013-03-09 11:04 ` [PATCH 3/4] qla2xxx: Update copyright information in LICENSE.qla2xxx file Chad Dupuis
@ 2013-03-09 11:04 ` Chad Dupuis
  2013-03-22 18:57 ` [PATCH 0/4] qla2xxx: Patches for 3.9-rc Saurav Kashyap
  4 siblings, 0 replies; 6+ messages in thread
From: Chad Dupuis @ 2013-03-09 11:04 UTC (permalink / raw)
  To: jbottomley; +Cc: giridhar.malavali, saurav.kashyap, andrew.vasquez, linux-scsi

From: Saurav Kashyap <saurav.kashyap@qlogic.com>

Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
---
 drivers/scsi/qla2xxx/qla_version.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h
index 2b6e478..ec54036 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
+++ b/drivers/scsi/qla2xxx/qla_version.h
@@ -7,7 +7,7 @@
 /*
  * Driver version
  */
-#define QLA2XXX_VERSION      "8.04.00.08-k"
+#define QLA2XXX_VERSION      "8.04.00.13-k"
 
 #define QLA_DRIVER_MAJOR_VER	8
 #define QLA_DRIVER_MINOR_VER	4
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/4] qla2xxx: Patches for 3.9-rc.
  2013-03-09 11:04 [PATCH 0/4] qla2xxx: Patches for 3.9-rc Chad Dupuis
                   ` (3 preceding siblings ...)
  2013-03-09 11:04 ` [PATCH 4/4] qla2xxx: Update the driver version to 8.04.00.13-k Chad Dupuis
@ 2013-03-22 18:57 ` Saurav Kashyap
  4 siblings, 0 replies; 6+ messages in thread
From: Saurav Kashyap @ 2013-03-22 18:57 UTC (permalink / raw)
  To: Chad Dupuis, jbottomley; +Cc: Giridhar Malavali, Andrew Vasquez, linux-scsi

Hi James,
Please disregard this patch set we had submitted as the sender was wrong,
we will send the correct patch set soon.

Thanks,
~Saurav


>Hi James,
>
>Please apply the following patches for 3.9-rc.
>
>Thanks,
>~Saurav
>
>
>Arun Easi (1):
>  qla2xxx: Fix crash during firmware dump procedure.
>
>Joe Carnuccio (1):
>  Revert "qla2xxx: Add setting of driver version string for vendor
>    application."
>
>Saurav Kashyap (2):
>  qla2xxx: Update copyright information in LICENSE.qla2xxx file.
>  qla2xxx: Update the driver version to 8.04.00.13-k.
>
> Documentation/scsi/LICENSE.qla2xxx |    2 +-
> drivers/scsi/qla2xxx/qla_dbg.c     |    3 +-
> drivers/scsi/qla2xxx/qla_def.h     |    1 -
> drivers/scsi/qla2xxx/qla_gbl.h     |    3 --
> drivers/scsi/qla2xxx/qla_init.c    |    4 +--
> drivers/scsi/qla2xxx/qla_mbx.c     |   58
>------------------------------------
> drivers/scsi/qla2xxx/qla_version.h |    2 +-
> 7 files changed, 5 insertions(+), 68 deletions(-)
>
>--
>1.7.7
>


________________________________

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-03-22 18:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-09 11:04 [PATCH 0/4] qla2xxx: Patches for 3.9-rc Chad Dupuis
2013-03-09 11:04 ` [PATCH 1/4] Revert "qla2xxx: Add setting of driver version string for vendor application." Chad Dupuis
2013-03-09 11:04 ` [PATCH 2/4] qla2xxx: Fix crash during firmware dump procedure Chad Dupuis
2013-03-09 11:04 ` [PATCH 3/4] qla2xxx: Update copyright information in LICENSE.qla2xxx file Chad Dupuis
2013-03-09 11:04 ` [PATCH 4/4] qla2xxx: Update the driver version to 8.04.00.13-k Chad Dupuis
2013-03-22 18:57 ` [PATCH 0/4] qla2xxx: Patches for 3.9-rc Saurav Kashyap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.