All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saurav Kashyap <saurav.kashyap@qlogic.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	Chad Dupuis <chad.dupuis@qlogic.com>
Subject: Re: [PATCH 0/10] qla2xxx: Reduce the number of Coverity warnings
Date: Wed, 12 Jun 2013 08:03:51 +0000	[thread overview]
Message-ID: <F5D084D6342F9B479C34599BB0A03E4D35390F99@AVMB1.qlogic.org> (raw)
In-Reply-To: <51B2EADE.30500@acm.org>

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

Hi Bart,
Thanks for patchset. There are minor issue with some patches like updating
the missing msg_ids in qla_dbg.c file. I am replying to each of the patch.

Thanks,
~Saurav


>On 06/07/13 21:06, Saurav Kashyap wrote:
>> Thanks for the patches. Please share the warnings reported by Coverity,
>>so
>> that its easy for us to review the patches.
>
>Hello Saurav,
>
>The Coverity warnings that led me to developing this patch series are as
>follows:
>- For patches 1, 2, 3, 8: Logically dead code - execution cannot reach
>this statement.
>- For patch 4: Array compared against 0 (NO_EFFECT) array_null:
>Comparing an array to null is not useful: "ha->model_desc".
>- For patch 5, 6 and 9: Unused pointer value.
>- For patch 7: Overrunning struct type ct_sns_req of 1228 bytes by
>passing it to a function which accesses it at byte offset 8207.
>- For patch 10: Resource leak (RESOURCE_LEAK) leaked_storage: Variable
>"fcport" going out of scope leaks the storage it points to.
>
>Hope this helps,
>
>Bart.
>


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 4277 bytes --]

      reply	other threads:[~2013-06-12  8:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 13:01 [PATCH 0/10] qla2xxx: Reduce the number of Coverity warnings Bart Van Assche
2013-06-05 13:02 ` [PATCH 01/10] qla2xxx: Clean up qla24xx_iidma() Bart Van Assche
2013-06-12  8:05   ` Saurav Kashyap
2013-06-12 18:59     ` James Bottomley
2013-06-13  5:20       ` Saurav Kashyap
2013-06-05 13:03 ` [PATCH 02/10] qla2xxx: Clean up qla84xx_mgmt_cmd() Bart Van Assche
2013-06-12  8:06   ` Saurav Kashyap
2013-06-05 13:04 ` [PATCH 03/10] qla2xxx: Remove dead code in qla2x00_configure_hba() Bart Van Assche
2013-06-12  8:08   ` Saurav Kashyap
2013-06-05 13:05 ` [PATCH 04/10] qla2xxx: Remove two superfluous tests Bart Van Assche
2013-06-12  8:08   ` Saurav Kashyap
2013-06-05 13:06 ` [PATCH 05/10] qla2xxx: Remove a dead assignment in qla24xx_build_scsi_crc_2_iocbs() Bart Van Assche
2013-06-12  8:08   ` Saurav Kashyap
2013-06-05 13:06 ` [PATCH 06/10] qla2xxx: Remove redundant assignments Bart Van Assche
2013-06-12  8:09   ` Saurav Kashyap
2013-06-05 13:07 ` [PATCH 07/10] qla2xxx: Help Coverity with analyzing ct_sns_pkt initialization Bart Van Assche
2013-06-12  8:09   ` Saurav Kashyap
2013-06-05 13:08 ` [PATCH 08/10] qla2xxx: Fix qla2xxx_check_risc_status() Bart Van Assche
2013-06-12  8:10   ` Saurav Kashyap
2013-06-05 13:09 ` [PATCH 09/10] qla2xxx: Remove an unused variable from qla2x00_remove_one() Bart Van Assche
2013-06-12  8:10   ` Saurav Kashyap
2013-06-05 13:09 ` [PATCH 10/10] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els() Bart Van Assche
2013-06-12  8:11   ` Saurav Kashyap
2013-06-07 19:06 ` [PATCH 0/10] qla2xxx: Reduce the number of Coverity warnings Saurav Kashyap
2013-06-08  8:27   ` Bart Van Assche
2013-06-12  8:03     ` Saurav Kashyap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F5D084D6342F9B479C34599BB0A03E4D35390F99@AVMB1.qlogic.org \
    --to=saurav.kashyap@qlogic.com \
    --cc=bvanassche@acm.org \
    --cc=chad.dupuis@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.