* [PATCH 0/2] qla2xxx: Patches for 3.10-rc. @ 2013-07-12 18:47 Saurav Kashyap 2013-07-12 18:47 ` [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function Saurav Kashyap 2013-07-12 18:47 ` [PATCH 2/2] qla2xxx: Properly set the tagging for commands Saurav Kashyap 0 siblings, 2 replies; 8+ messages in thread From: Saurav Kashyap @ 2013-07-12 18:47 UTC (permalink / raw) To: jbottomley; +Cc: giridhar.malavali, saurav.kashyap, andrew.vasquez, linux-scsi Hi James, Please apply the following patches for 3.10-rc. Thanks, ~Saurav Saurav Kashyap (2): qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function. qla2xxx: Properly set the tagging for commands. drivers/scsi/qla2xxx/qla_iocb.c | 11 +++++++++-- drivers/scsi/qla2xxx/qla_mr.h | 6 ++++-- 2 files changed, 13 insertions(+), 4 deletions(-) -- 1.7.7 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function. 2013-07-12 18:47 [PATCH 0/2] qla2xxx: Patches for 3.10-rc Saurav Kashyap @ 2013-07-12 18:47 ` Saurav Kashyap 2013-07-19 14:44 ` James Bottomley 2013-07-12 18:47 ` [PATCH 2/2] qla2xxx: Properly set the tagging for commands Saurav Kashyap 1 sibling, 1 reply; 8+ messages in thread From: Saurav Kashyap @ 2013-07-12 18:47 UTC (permalink / raw) To: jbottomley; +Cc: giridhar.malavali, saurav.kashyap, andrew.vasquez, linux-scsi Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_mr.h | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.h b/drivers/scsi/qla2xxx/qla_mr.h index 1a092af..179f8e4 100644 --- a/drivers/scsi/qla2xxx/qla_mr.h +++ b/drivers/scsi/qla2xxx/qla_mr.h @@ -434,9 +434,11 @@ struct qla_mt_iocb_rqst_fx00 { __le32 dataword_extra; - __le32 req_len; + __le16 req_len; + __le16 reserved_2; - __le32 rsp_len; + __le16 rsp_len; + __le16 reserved_3; }; struct qla_mt_iocb_rsp_fx00 { -- 1.7.7 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function. 2013-07-12 18:47 ` [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function Saurav Kashyap @ 2013-07-19 14:44 ` James Bottomley 2013-07-22 5:43 ` Saurav Kashyap 0 siblings, 1 reply; 8+ messages in thread From: James Bottomley @ 2013-07-19 14:44 UTC (permalink / raw) To: Saurav Kashyap; +Cc: giridhar.malavali, andrew.vasquez, linux-scsi On Fri, 2013-07-12 at 14:47 -0400, Saurav Kashyap wrote: > Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com> > Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> This does not fix a bug ... therefore it's not really -rc fixes material. In early -rc this rule can be relaxed a bit ... but what's the reason to get this through the -rc tree? James ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function. 2013-07-19 14:44 ` James Bottomley @ 2013-07-22 5:43 ` Saurav Kashyap 0 siblings, 0 replies; 8+ messages in thread From: Saurav Kashyap @ 2013-07-22 5:43 UTC (permalink / raw) To: James Bottomley; +Cc: Giridhar Malavali, Andrew Vasquez, linux-scsi [-- Attachment #1: Type: text/plain, Size: 750 bytes --] HI James, Yes, agreed. I will resend the relevant patch set. Thanks, ~Saurav -----Original Message----- From: James Bottomley [mailto:jbottomley@parallels.com] Sent: Friday, July 19, 2013 8:14 PM To: Saurav Kashyap Cc: Giridhar Malavali; Andrew Vasquez; linux-scsi Subject: Re: [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function. On Fri, 2013-07-12 at 14:47 -0400, Saurav Kashyap wrote: > Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com> > Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> This does not fix a bug ... therefore it's not really -rc fixes material. In early -rc this rule can be relaxed a bit ... but what's the reason to get this through the -rc tree? James [-- Attachment #2: winmail.dat --] [-- Type: application/ms-tnef, Size: 4226 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] qla2xxx: Properly set the tagging for commands. 2013-07-12 18:47 [PATCH 0/2] qla2xxx: Patches for 3.10-rc Saurav Kashyap 2013-07-12 18:47 ` [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function Saurav Kashyap @ 2013-07-12 18:47 ` Saurav Kashyap 2013-07-19 9:16 ` Saurav Kashyap 1 sibling, 1 reply; 8+ messages in thread From: Saurav Kashyap @ 2013-07-12 18:47 UTC (permalink / raw) To: jbottomley; +Cc: giridhar.malavali, saurav.kashyap, andrew.vasquez, linux-scsi Reported-by: Jack Hill <jackhill@jackhill.us> Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_iocb.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 42ef481..ef0a548 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -419,6 +419,8 @@ qla2x00_start_scsi(srb_t *sp) __constant_cpu_to_le16(CF_SIMPLE_TAG); break; } + } else { + cmd_pkt->control_flags = __constant_cpu_to_le16(CF_SIMPLE_TAG); } /* Load SCSI command packet. */ @@ -1307,11 +1309,11 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct cmd_type_crc_2 *cmd_pkt, fcp_cmnd->task_attribute = TSK_ORDERED; break; default: - fcp_cmnd->task_attribute = 0; + fcp_cmnd->task_attribute = TSK_SIMPLE; break; } } else { - fcp_cmnd->task_attribute = 0; + fcp_cmnd->task_attribute = TSK_SIMPLE; } cmd_pkt->fcp_rsp_dseg_len = 0; /* Let response come in status iocb */ @@ -1525,7 +1527,12 @@ qla24xx_start_scsi(srb_t *sp) case ORDERED_QUEUE_TAG: cmd_pkt->task = TSK_ORDERED; break; + default: + cmd_pkt->task = TSK_SIMPLE; + break; } + } else { + cmd_pkt->task = TSK_SIMPLE; } /* Load SCSI command packet. */ -- 1.7.7 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] qla2xxx: Properly set the tagging for commands. 2013-07-12 18:47 ` [PATCH 2/2] qla2xxx: Properly set the tagging for commands Saurav Kashyap @ 2013-07-19 9:16 ` Saurav Kashyap 2013-07-19 15:41 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Saurav Kashyap @ 2013-07-19 9:16 UTC (permalink / raw) To: jbottomley, stable; +Cc: Giridhar Malavali, Andrew Vasquez, linux-scsi This should go to stable also, added in to list. This fixes a BZ https://bugzilla.kernel.org/show_bug.cgi?id=59601 Thanks, ~Saurav -----Original Message----- From: Saurav Kashyap [mailto:saurav.kashyap@qlogic.com] Sent: Saturday, July 13, 2013 12:18 AM To: jbottomley@parallels.com Cc: Giridhar Malavali; Saurav Kashyap; Andrew Vasquez; linux-scsi Subject: [PATCH 2/2] qla2xxx: Properly set the tagging for commands. Reported-by: Jack Hill <jackhill@jackhill.us> Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_iocb.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 42ef481..ef0a548 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -419,6 +419,8 @@ qla2x00_start_scsi(srb_t *sp) __constant_cpu_to_le16(CF_SIMPLE_TAG); break; } + } else { + cmd_pkt->control_flags = __constant_cpu_to_le16(CF_SIMPLE_TAG); } /* Load SCSI command packet. */ @@ -1307,11 +1309,11 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct cmd_type_crc_2 *cmd_pkt, fcp_cmnd->task_attribute = TSK_ORDERED; break; default: - fcp_cmnd->task_attribute = 0; + fcp_cmnd->task_attribute = TSK_SIMPLE; break; } } else { - fcp_cmnd->task_attribute = 0; + fcp_cmnd->task_attribute = TSK_SIMPLE; } cmd_pkt->fcp_rsp_dseg_len = 0; /* Let response come in status iocb */ @@ -1525,7 +1527,12 @@ qla24xx_start_scsi(srb_t *sp) case ORDERED_QUEUE_TAG: cmd_pkt->task = TSK_ORDERED; break; + default: + cmd_pkt->task = TSK_SIMPLE; + break; } + } else { + cmd_pkt->task = TSK_SIMPLE; } /* Load SCSI command packet. */ -- 1.7.7 ________________________________ This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] qla2xxx: Properly set the tagging for commands. 2013-07-19 9:16 ` Saurav Kashyap @ 2013-07-19 15:41 ` Greg KH 2013-07-22 5:43 ` Saurav Kashyap 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2013-07-19 15:41 UTC (permalink / raw) To: Saurav Kashyap Cc: jbottomley, stable, Giridhar Malavali, Andrew Vasquez, linux-scsi On Fri, Jul 19, 2013 at 09:16:51AM +0000, Saurav Kashyap wrote: > This should go to stable also, added in to list. This fixes a BZ https://bugzilla.kernel.org/show_bug.cgi?id=59601 > > Thanks, > ~Saurav > > > -----Original Message----- > From: Saurav Kashyap [mailto:saurav.kashyap@qlogic.com] > Sent: Saturday, July 13, 2013 12:18 AM > To: jbottomley@parallels.com > Cc: Giridhar Malavali; Saurav Kashyap; Andrew Vasquez; linux-scsi > Subject: [PATCH 2/2] qla2xxx: Properly set the tagging for commands. > > Reported-by: Jack Hill <jackhill@jackhill.us> > Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com> > Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> > --- > drivers/scsi/qla2xxx/qla_iocb.c | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. </formletter> ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] qla2xxx: Properly set the tagging for commands. 2013-07-19 15:41 ` Greg KH @ 2013-07-22 5:43 ` Saurav Kashyap 0 siblings, 0 replies; 8+ messages in thread From: Saurav Kashyap @ 2013-07-22 5:43 UTC (permalink / raw) To: Greg KH; +Cc: jbottomley, stable, Giridhar Malavali, Andrew Vasquez, linux-scsi HI Greg, Thanks, I will resend the relevant patch in proper way. Thanks, ~Saurav -----Original Message----- From: Greg KH [mailto:gregkh@linuxfoundation.org] Sent: Friday, July 19, 2013 9:11 PM To: Saurav Kashyap Cc: jbottomley@parallels.com; stable@vger.kernel.org; Giridhar Malavali; Andrew Vasquez; linux-scsi Subject: Re: [PATCH 2/2] qla2xxx: Properly set the tagging for commands. On Fri, Jul 19, 2013 at 09:16:51AM +0000, Saurav Kashyap wrote: > This should go to stable also, added in to list. This fixes a BZ > https://bugzilla.kernel.org/show_bug.cgi?id=59601 > > Thanks, > ~Saurav > > > -----Original Message----- > From: Saurav Kashyap [mailto:saurav.kashyap@qlogic.com] > Sent: Saturday, July 13, 2013 12:18 AM > To: jbottomley@parallels.com > Cc: Giridhar Malavali; Saurav Kashyap; Andrew Vasquez; linux-scsi > Subject: [PATCH 2/2] qla2xxx: Properly set the tagging for commands. > > Reported-by: Jack Hill <jackhill@jackhill.us> > Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com> > Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> > --- > drivers/scsi/qla2xxx/qla_iocb.c | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. </formletter> ________________________________ This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-07-22 5:43 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-07-12 18:47 [PATCH 0/2] qla2xxx: Patches for 3.10-rc Saurav Kashyap 2013-07-12 18:47 ` [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function Saurav Kashyap 2013-07-19 14:44 ` James Bottomley 2013-07-22 5:43 ` Saurav Kashyap 2013-07-12 18:47 ` [PATCH 2/2] qla2xxx: Properly set the tagging for commands Saurav Kashyap 2013-07-19 9:16 ` Saurav Kashyap 2013-07-19 15:41 ` Greg KH 2013-07-22 5:43 ` Saurav Kashyap
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.