All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: FW:  [PATCH] net/i40e: fix vlan insert code redundance
Date: Mon, 13 Feb 2017 10:09:14 +0000	[thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDD27C8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDD22E0@SHSMSX101.ccr.corp.intel.com>

Hi, Ferruh

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming
> Sent: Friday, February 10, 2017 7:21 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance
> 
> > On 2/10/2017 1:26 AM, Qiming Yang wrote:
> > > This patch removed useless tx_flags in vlan insertion.
> >
> > Overall this looks good, I wonder what was the initial intention of
> > this code, understanding it helps to figure out if there is a hidden defect.
> 
> Thank you for your remind. I'll investigate it.

I have aligned with Helin (he contribute these code), and make sure these code is useless, these code is left by history.

> 
> >
> > This code not fixes a defect, but improves the code, is there any
> > performance gain with this?
> 
> I'll do more test and give you a feedback.

According to my test, this code will not bring any obvious performance gain, and no lose also.
And as you said this is not a bug fix, should I remove the fix line and modify the commit log?

> 
> > If not, I am for deferring this to next release.
> >
> > >
> > > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > >
> > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > ---

  reply	other threads:[~2017-02-13 10:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10  1:26 [PATCH] net/i40e: fix vlan insert code redundance Qiming Yang
2017-02-10 10:25 ` Ferruh Yigit
2017-02-10 11:21   ` Yang, Qiming
2017-02-13 10:09     ` Yang, Qiming [this message]
2017-02-13 10:14       ` FW: " Ferruh Yigit
2017-02-20  5:32 ` [PATCH v2] net/i40e: remove redundant vlan insert code Qiming Yang
2017-02-20 12:55   ` Ferruh Yigit
2017-02-20  5:43 ` Qiming Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDD27C8@SHSMSX101.ccr.corp.intel.com \
    --to=qiming.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.