All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver
@ 2012-01-25 12:19 Ajay Bhargav
  2012-01-25 12:19 ` [U-Boot] [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs Ajay Bhargav
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Ajay Bhargav @ 2012-01-25 12:19 UTC (permalink / raw)
  To: u-boot

This patch adds USB host controller's UTMI PHY interface driver for
Armada100 SOCs.

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
---
 arch/arm/include/asm/arch-armada100/armada100.h |    7 ++
 drivers/usb/host/utmi-armada100.c               |   87 +++++++++++++++++++++++
 drivers/usb/host/utmi-armada100.h               |   79 ++++++++++++++++++++
 3 files changed, 173 insertions(+), 0 deletions(-)
 create mode 100644 drivers/usb/host/utmi-armada100.c
 create mode 100644 drivers/usb/host/utmi-armada100.h

diff --git a/arch/arm/include/asm/arch-armada100/armada100.h b/arch/arm/include/asm/arch-armada100/armada100.h
index 0ed3a8e..d6984dc 100644
--- a/arch/arm/include/asm/arch-armada100/armada100.h
+++ b/arch/arm/include/asm/arch-armada100/armada100.h
@@ -43,6 +43,13 @@
 #define SSP2_APBCLK		0x01
 #define SSP2_FNCLK		0x02
 
+/* USB Clock/reset control bits */
+#define USB_SPH_AXICLK_EN	0x10
+#define USB_SPH_AXI_RST		0x02
+
+/* MPMU Clocks */
+#define MPMU_EN_ALL_CLKS	0x1EFFFF
+
 /* Register Base Addresses */
 #define ARMD1_DRAM_BASE		0xB0000000
 #define ARMD1_FEC_BASE		0xC0800000
diff --git a/drivers/usb/host/utmi-armada100.c b/drivers/usb/host/utmi-armada100.c
new file mode 100644
index 0000000..b8225dd
--- /dev/null
+++ b/drivers/usb/host/utmi-armada100.c
@@ -0,0 +1,87 @@
+/*
+ * (C) Copyright 2012
+ * eInfochips Ltd. <www.einfochips.com>
+ * Written-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
+ *
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <usb.h>
+#include <asm/arch/cpu.h>
+#include <asm/arch/armada100.h>
+#include "utmi-armada100.h"
+
+static void utmi_phy_init(void)
+{
+	struct armd1usb_phy_reg *phy_regs =
+		(struct armd1usb_phy_reg *)UTMI_PHY_BASE;
+
+	setbits_le32(&phy_regs->utmi_ctrl, INPKT_DELAY_SOF | PLL_PWR_UP);
+	udelay(1000);
+	setbits_le32(&phy_regs->utmi_ctrl, PHY_PWR_UP);
+
+	clrbits_le32(&phy_regs->utmi_pll, PLL_FBDIV_MASK | PLL_REFDIV_MASK);
+	setbits_le32(&phy_regs->utmi_pll, N_DIVIDER << PLL_FBDIV | M_DIVIDER);
+
+	setbits_le32(&phy_regs->utmi_tx, PHSEL_VAL << CK60_PHSEL);
+
+	/* Calibrate pll */
+	while ((readl(&phy_regs->utmi_pll) & PLL_READY) == 0)
+		;
+
+	udelay(200);
+	setbits_le32(&phy_regs->utmi_pll, VCOCAL_START);
+	udelay(400);
+	clrbits_le32(&phy_regs->utmi_pll, VCOCAL_START);
+
+	udelay(200);
+	setbits_le32(&phy_regs->utmi_tx, RCAL_START);
+	udelay(400);
+	clrbits_le32(&phy_regs->utmi_tx, RCAL_START);
+
+	while ((readl(&phy_regs->utmi_pll) & PLL_READY) == 0)
+		;
+}
+
+/*
+ * Initialize USB host controller's UTMI Physical interface
+ */
+void utmi_init(void)
+{
+	struct armd1mpmu_registers *mpmu_regs =
+		(struct armd1mpmu_registers *)ARMD1_MPMU_BASE;
+
+	struct armd1apmu_registers *apmu_regs =
+		(struct armd1apmu_registers *)ARMD1_APMU_BASE;
+
+	/* Turn on main PMU clocks */
+	writel(MPMU_EN_ALL_CLKS, &mpmu_regs->acgr);
+
+	/* USB Clock reset */
+	writel(USB_SPH_AXICLK_EN, &apmu_regs->usbcrc);
+	writel(USB_SPH_AXICLK_EN | USB_SPH_AXI_RST, &apmu_regs->usbcrc);
+
+	/* Initialize UTMI transceiver */
+	utmi_phy_init();
+}
diff --git a/drivers/usb/host/utmi-armada100.h b/drivers/usb/host/utmi-armada100.h
new file mode 100644
index 0000000..dd0ccdb
--- /dev/null
+++ b/drivers/usb/host/utmi-armada100.h
@@ -0,0 +1,79 @@
+/*
+ * (C) Copyright 2012
+ * eInfochips Ltd. <www.einfochips.com>
+ * Written-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
+ *
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __UTMI_ARMADA100__
+#define __UTMI_ARMADA100__
+
+#define UTMI_PHY_BASE		0xD4206000
+
+/* utmi_ctrl - bits */
+#define INPKT_DELAY_SOF		(1 << 28)
+#define PLL_PWR_UP		2
+#define PHY_PWR_UP		1
+
+/* utmi_pll - bits */
+#define PLL_FBDIV_MASK		0x00000FF0
+#define PLL_FBDIV		4
+#define PLL_REFDIV_MASK		0x0000000F
+#define PLL_REFDIV		0
+#define PLL_READY		0x800000
+#define VCOCAL_START		(1 << 21)
+
+#define N_DIVIDER		0xEE
+#define M_DIVIDER		0x0B
+
+/* utmi_tx - bits */
+#define CK60_PHSEL		17
+#define PHSEL_VAL		0x4
+#define RCAL_START		(1 << 12)
+
+/*
+ * USB PHY registers
+ * Refer Datasheet Appendix A.21
+ */
+struct armd1usb_phy_reg {
+	u32 utmi_rev;	/* USB PHY Revision */
+	u32 utmi_ctrl;	/* USB PHY Control register */
+	u32 utmi_pll;	/* PLL register */
+	u32 utmi_tx;	/* Tx register */
+	u32 utmi_rx;	/* Rx register */
+	u32 utmi_ivref;	/* IVREF register */
+	u32 utmi_tst_g0;	/* Test group 0 register */
+	u32 utmi_tst_g1;	/* Test group 1 register */
+	u32 utmi_tst_g2;	/* Test group 2 register */
+	u32 utmi_tst_g3;	/* Test group 3 register */
+	u32 utmi_tst_g4;	/* Test group 4 register */
+	u32 utmi_tst_g5;	/* Test group 5 register */
+	u32 utmi_reserve;	/* Reserve Register */
+	u32 utmi_usb_int;	/* USB interuppt register */
+	u32 utmi_dbg_ctl;	/* Debug control register */
+	u32 utmi_otg_addon;	/* OTG addon register */
+};
+
+void utmi_init(void);
+
+#endif /* __UTMI_ARMADA100__ */
-- 
1.7.7.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs
  2012-01-25 12:19 [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Ajay Bhargav
@ 2012-01-25 12:19 ` Ajay Bhargav
  2012-01-26 18:01   ` Prafulla Wadaskar
  2012-01-25 12:19 ` [U-Boot] [PATCH 3/3] Armada100: gplugD: Add USB command support Ajay Bhargav
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Ajay Bhargav @ 2012-01-25 12:19 UTC (permalink / raw)
  To: u-boot

This patch adds support for USB EHCI driver for Armada100 SOCs.

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
---
 arch/arm/include/asm/arch-armada100/armada100.h |    1 +
 drivers/usb/host/Makefile                       |    1 +
 drivers/usb/host/ehci-armada100.c               |   62 +++++++++++++++++++++++
 3 files changed, 64 insertions(+), 0 deletions(-)
 create mode 100644 drivers/usb/host/ehci-armada100.c

diff --git a/arch/arm/include/asm/arch-armada100/armada100.h b/arch/arm/include/asm/arch-armada100/armada100.h
index d6984dc..26f836e 100644
--- a/arch/arm/include/asm/arch-armada100/armada100.h
+++ b/arch/arm/include/asm/arch-armada100/armada100.h
@@ -67,6 +67,7 @@
 #define ARMD1_SSP5_BASE		0xD4021000
 #define ARMD1_UART3_BASE	0xD4026000
 #define ARMD1_MPMU_BASE		0xD4050000
+#define ARMD1_USB_HOST_BASE	0xD4209000
 #define ARMD1_APMU_BASE		0xD4282800
 #define ARMD1_CPU_BASE		0xD4282C00
 
diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
index 77e217f..94e72c3 100644
--- a/drivers/usb/host/Makefile
+++ b/drivers/usb/host/Makefile
@@ -35,6 +35,7 @@ COBJS-$(CONFIG_USB_SL811HS) += sl811-hcd.o
 
 # echi
 COBJS-$(CONFIG_USB_EHCI) += ehci-hcd.o
+COBJS-$(CONFIG_USB_EHCI_ARMADA100) += ehci-armada100.o utmi-armada100.o
 ifdef CONFIG_MPC512X
 COBJS-$(CONFIG_USB_EHCI_FSL) += ehci-mpc512x.o
 else
diff --git a/drivers/usb/host/ehci-armada100.c b/drivers/usb/host/ehci-armada100.c
new file mode 100644
index 0000000..cf05d1a
--- /dev/null
+++ b/drivers/usb/host/ehci-armada100.c
@@ -0,0 +1,62 @@
+/*
+ * (C) Copyright 2012
+ * eInfochips Ltd. <www.einfochips.com>
+ * Written-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
+ *
+ * This driver is based on Kirkwood echi driver
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <usb.h>
+#include "ehci.h"
+#include "ehci-core.h"
+#include <asm/arch/cpu.h>
+#include <asm/arch/armada100.h>
+#include "utmi-armada100.h"
+
+/*
+ * EHCI host controller init
+ */
+int ehci_hcd_init(void)
+{
+	utmi_init();
+	hccr = (struct ehci_hccr *)(ARMD1_USB_HOST_BASE + 0x100);
+	hcor = (struct ehci_hcor *)((uint32_t) hccr
+			+ HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
+	printf("Kirkwood-ehci: init hccr %x and hcor %x hc_length %d\n",
+		(uint32_t)hccr, (uint32_t)hcor,
+		(uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
+	return 0;
+}
+
+/*
+ * EHCI host controller stop
+ */
+int ehci_hcd_stop(void)
+{
+	return 0;
+}
-- 
1.7.7.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 3/3] Armada100: gplugD: Add USB command support
  2012-01-25 12:19 [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Ajay Bhargav
  2012-01-25 12:19 ` [U-Boot] [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs Ajay Bhargav
@ 2012-01-25 12:19 ` Ajay Bhargav
  2012-01-26 18:05   ` Prafulla Wadaskar
  2012-01-26 17:59 ` [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Prafulla Wadaskar
  2012-02-26 23:12 ` Marek Vasut
  3 siblings, 1 reply; 9+ messages in thread
From: Ajay Bhargav @ 2012-01-25 12:19 UTC (permalink / raw)
  To: u-boot

This patch adds support for USB commands and USB storage device for
Marvell gplugD

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
---
 include/configs/gplugd.h |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/include/configs/gplugd.h b/include/configs/gplugd.h
index 9813309..f8dc74f 100644
--- a/include/configs/gplugd.h
+++ b/include/configs/gplugd.h
@@ -134,4 +134,21 @@
 #define CONFIG_CMD_EDITENV
 #define CONFIG_CMD_SAVEENV
 
+#define CONFIG_CMD_USB
+
+#ifdef CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_ARMADA100
+#define CONFIG_EHCI_IS_TDI
+#define CONFIG_USB_STORAGE
+
+#ifndef CONFIG_DOS_PARTITION
+#define CONFIG_DOS_PARTITION
+#endif /* CONFIG_DOS_PARTITION */
+
+#define CONFIG_ISO_PARTITION
+#define CONFIG_SUPPORT_VFAT
+#define CONFIG_CMD_EXT2
+#endif /* CONFIG_CMD_USB */
+
 #endif	/* __CONFIG_GPLUGD_H */
-- 
1.7.7.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver
  2012-01-25 12:19 [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Ajay Bhargav
  2012-01-25 12:19 ` [U-Boot] [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs Ajay Bhargav
  2012-01-25 12:19 ` [U-Boot] [PATCH 3/3] Armada100: gplugD: Add USB command support Ajay Bhargav
@ 2012-01-26 17:59 ` Prafulla Wadaskar
  2012-02-26 23:12 ` Marek Vasut
  3 siblings, 0 replies; 9+ messages in thread
From: Prafulla Wadaskar @ 2012-01-26 17:59 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: 25 January 2012 17:50
> To: linux at bohmer.net
> Cc: Prafulla Wadaskar; marek.vasut at gmail.com; u-boot at lists.denx.de;
> Ajay Bhargav
> Subject: [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver
> 
> This patch adds USB host controller's UTMI PHY interface driver for
> Armada100 SOCs.
> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> ---
>  arch/arm/include/asm/arch-armada100/armada100.h |    7 ++
>  drivers/usb/host/utmi-armada100.c               |   87
> +++++++++++++++++++++++
>  drivers/usb/host/utmi-armada100.h               |   79
> ++++++++++++++++++++
>  3 files changed, 173 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/host/utmi-armada100.c
>  create mode 100644 drivers/usb/host/utmi-armada100.h
> 
> diff --git a/arch/arm/include/asm/arch-armada100/armada100.h
> b/arch/arm/include/asm/arch-armada100/armada100.h
> index 0ed3a8e..d6984dc 100644
> --- a/arch/arm/include/asm/arch-armada100/armada100.h
> +++ b/arch/arm/include/asm/arch-armada100/armada100.h
> @@ -43,6 +43,13 @@
>  #define SSP2_APBCLK		0x01
>  #define SSP2_FNCLK		0x02
> 
> +/* USB Clock/reset control bits */
> +#define USB_SPH_AXICLK_EN	0x10
> +#define USB_SPH_AXI_RST		0x02
> +
> +/* MPMU Clocks */
> +#define MPMU_EN_ALL_CLKS	0x1EFFFF

Turning on all clocks is not logical to enable this support, only relevant clock necessary for this components SHOULD BE enabled.

Enabling clocks for unused peripherals/components may result in unnecessarily extra power consumption

Otherwise ack for rest of the patch

Regards..
Prafulla . . .

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs
  2012-01-25 12:19 ` [U-Boot] [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs Ajay Bhargav
@ 2012-01-26 18:01   ` Prafulla Wadaskar
  2012-01-27  6:04     ` Ajay Bhargav
  0 siblings, 1 reply; 9+ messages in thread
From: Prafulla Wadaskar @ 2012-01-26 18:01 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: 25 January 2012 17:50
> To: linux at bohmer.net
> Cc: Prafulla Wadaskar; marek.vasut at gmail.com; u-boot at lists.denx.de;
> Ajay Bhargav
> Subject: [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs
> 
> This patch adds support for USB EHCI driver for Armada100 SOCs.
> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> ---
>  arch/arm/include/asm/arch-armada100/armada100.h |    1 +
>  drivers/usb/host/Makefile                       |    1 +
>  drivers/usb/host/ehci-armada100.c               |   62
> +++++++++++++++++++++++
>  3 files changed, 64 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/host/ehci-armada100.c
> 
> diff --git a/arch/arm/include/asm/arch-armada100/armada100.h
> b/arch/arm/include/asm/arch-armada100/armada100.h
> index d6984dc..26f836e 100644
> --- a/arch/arm/include/asm/arch-armada100/armada100.h
> +++ b/arch/arm/include/asm/arch-armada100/armada100.h
> @@ -67,6 +67,7 @@
>  #define ARMD1_SSP5_BASE		0xD4021000
>  #define ARMD1_UART3_BASE	0xD4026000
>  #define ARMD1_MPMU_BASE		0xD4050000
> +#define ARMD1_USB_HOST_BASE	0xD4209000
>  #define ARMD1_APMU_BASE		0xD4282800
>  #define ARMD1_CPU_BASE		0xD4282C00
> 
> diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
> index 77e217f..94e72c3 100644
> --- a/drivers/usb/host/Makefile
> +++ b/drivers/usb/host/Makefile
> @@ -35,6 +35,7 @@ COBJS-$(CONFIG_USB_SL811HS) += sl811-hcd.o
> 
>  # echi
>  COBJS-$(CONFIG_USB_EHCI) += ehci-hcd.o
> +COBJS-$(CONFIG_USB_EHCI_ARMADA100) += ehci-armada100.o utmi-
> armada100.o
>  ifdef CONFIG_MPC512X
>  COBJS-$(CONFIG_USB_EHCI_FSL) += ehci-mpc512x.o
>  else
> diff --git a/drivers/usb/host/ehci-armada100.c
> b/drivers/usb/host/ehci-armada100.c
> new file mode 100644
> index 0000000..cf05d1a
> --- /dev/null
> +++ b/drivers/usb/host/ehci-armada100.c
> @@ -0,0 +1,62 @@
> +/*
> + * (C) Copyright 2012
> + * eInfochips Ltd. <www.einfochips.com>
> + * Written-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> + *
> + * This driver is based on Kirkwood echi driver
> + * (C) Copyright 2009
> + * Marvell Semiconductor <www.marvell.com>
> + * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <usb.h>
> +#include "ehci.h"
> +#include "ehci-core.h"
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/armada100.h>
> +#include "utmi-armada100.h"
> +
> +/*
> + * EHCI host controller init
> + */
> +int ehci_hcd_init(void)
> +{
> +	utmi_init();
> +	hccr = (struct ehci_hccr *)(ARMD1_USB_HOST_BASE + 0x100);
> +	hcor = (struct ehci_hcor *)((uint32_t) hccr
> +			+ HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
> +
> +	printf("Kirkwood-ehci: init hccr %x and hcor %x hc_length %d\n",

Wrong printf message, it's not Kirkwood.

Regards..
Prafulla . . .

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 3/3] Armada100: gplugD: Add USB command support
  2012-01-25 12:19 ` [U-Boot] [PATCH 3/3] Armada100: gplugD: Add USB command support Ajay Bhargav
@ 2012-01-26 18:05   ` Prafulla Wadaskar
  2012-01-27  7:05     ` Ajay Bhargav
  0 siblings, 1 reply; 9+ messages in thread
From: Prafulla Wadaskar @ 2012-01-26 18:05 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: 25 January 2012 17:50
> To: linux at bohmer.net
> Cc: Prafulla Wadaskar; marek.vasut at gmail.com; u-boot at lists.denx.de;
> Ajay Bhargav
> Subject: [PATCH 3/3] Armada100: gplugD: Add USB command support
> 
> This patch adds support for USB commands and USB storage device for
> Marvell gplugD
> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> ---
>  include/configs/gplugd.h |   17 +++++++++++++++++
>  1 files changed, 17 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/gplugd.h b/include/configs/gplugd.h
> index 9813309..f8dc74f 100644
> --- a/include/configs/gplugd.h
> +++ b/include/configs/gplugd.h
> @@ -134,4 +134,21 @@
>  #define CONFIG_CMD_EDITENV
>  #define CONFIG_CMD_SAVEENV
> 
> +#define CONFIG_CMD_USB

This line should be moved up where all the commands are defined (below config_cmd_default.h)

> +
> +#ifdef CONFIG_CMD_USB
> +#define CONFIG_USB_EHCI
> +#define CONFIG_USB_EHCI_ARMADA100
> +#define CONFIG_EHCI_IS_TDI
> +#define CONFIG_USB_STORAGE
> +
> +#ifndef CONFIG_DOS_PARTITION

Does this undef needed? remove it you can.

Regards..
Prafulla . . .

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs
  2012-01-26 18:01   ` Prafulla Wadaskar
@ 2012-01-27  6:04     ` Ajay Bhargav
  0 siblings, 0 replies; 9+ messages in thread
From: Ajay Bhargav @ 2012-01-27  6:04 UTC (permalink / raw)
  To: u-boot


----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:
[...snip...]
> > +
> > +        printf("Kirkwood-ehci: init hccr %x and hcor %x hc_length %d\n",
> 
> Wrong printf message, it's not Kirkwood.
> 
> Regards..
> Prafulla . . .
> 
I don't know how I missed that.. though, I did changed it :/
Any other comments on patches?

Regards,
Ajay Bhargav

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 3/3] Armada100: gplugD: Add USB command support
  2012-01-26 18:05   ` Prafulla Wadaskar
@ 2012-01-27  7:05     ` Ajay Bhargav
  0 siblings, 0 replies; 9+ messages in thread
From: Ajay Bhargav @ 2012-01-27  7:05 UTC (permalink / raw)
  To: u-boot


----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> > -----Original Message-----
> > From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> > Sent: 25 January 2012 17:50
> > To: linux at bohmer.net
> > Cc: Prafulla Wadaskar; marek.vasut at gmail.com; u-boot at lists.denx.de;
> > Ajay Bhargav
> > Subject: [PATCH 3/3] Armada100: gplugD: Add USB command support
> > 
> > This patch adds support for USB commands and USB storage device for
> > Marvell gplugD
[...snip...]
> > 
> > +#ifdef CONFIG_CMD_USB
> > +#define CONFIG_USB_EHCI
> > +#define CONFIG_USB_EHCI_ARMADA100
> > +#define CONFIG_EHCI_IS_TDI
> > +#define CONFIG_USB_STORAGE
> > +
> > +#ifndef CONFIG_DOS_PARTITION
> 
> Does this undef needed? remove it you can.
> 
> Regards..
> Prafulla . . .
> 

I will review it again and remove it if not needed.

Regards,
Ajay Bhargav

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver
  2012-01-25 12:19 [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Ajay Bhargav
                   ` (2 preceding siblings ...)
  2012-01-26 17:59 ` [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Prafulla Wadaskar
@ 2012-02-26 23:12 ` Marek Vasut
  3 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2012-02-26 23:12 UTC (permalink / raw)
  To: u-boot

> This patch adds USB host controller's UTMI PHY interface driver for
> Armada100 SOCs.
> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> ---
>  arch/arm/include/asm/arch-armada100/armada100.h |    7 ++
>  drivers/usb/host/utmi-armada100.c               |   87
> +++++++++++++++++++++++ drivers/usb/host/utmi-armada100.h               | 
>  79 ++++++++++++++++++++ 3 files changed, 173 insertions(+), 0
> deletions(-)
>  create mode 100644 drivers/usb/host/utmi-armada100.c
>  create mode 100644 drivers/usb/host/utmi-armada100.h
> 

Hi,

what's the status of this patch/patchset?

Thanks
M

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2012-02-26 23:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-25 12:19 [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Ajay Bhargav
2012-01-25 12:19 ` [U-Boot] [PATCH 2/3] USB: Armada100: ECHI Driver for Armada100 SOCs Ajay Bhargav
2012-01-26 18:01   ` Prafulla Wadaskar
2012-01-27  6:04     ` Ajay Bhargav
2012-01-25 12:19 ` [U-Boot] [PATCH 3/3] Armada100: gplugD: Add USB command support Ajay Bhargav
2012-01-26 18:05   ` Prafulla Wadaskar
2012-01-27  7:05     ` Ajay Bhargav
2012-01-26 17:59 ` [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Prafulla Wadaskar
2012-02-26 23:12 ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.