* [Buildroot] [PATCH] portmap: fix static linking
@ 2014-09-08 21:43 ANDY KENNEDY
2014-09-16 20:07 ` Thomas Petazzoni
2014-09-21 20:08 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: ANDY KENNEDY @ 2014-09-08 21:43 UTC (permalink / raw)
To: buildroot
Portmap builds and links, however, does not get built correctly when
BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in
rootfs.tar, however, portmap gets linked dynamically without regards to
the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of
portmap.
Signed-off-by: Andy Kennedy <andy.kennedy@adtran.com>
---
diff -Naur a/package/portmap/portmap.mk b/package/portmap/portmap.mk
--- a/package/portmap/portmap.mk 2014-02-27 14:51:23.000000000 -0600
+++ b/package/portmap/portmap.mk 2014-09-08 16:39:13.715370478 -0500
@@ -15,8 +15,7 @@
endif
define PORTMAP_BUILD_CMDS
- CFLAGS="$(TARGET_CFLAGS)" \
- $(MAKE) CC="$(TARGET_CC)" -C $(@D) $(PORTMAP_FLAGS)
+ $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) $(PORTMAP_FLAGS)
endef
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] portmap: fix static linking
2014-09-08 21:43 [Buildroot] [PATCH] portmap: fix static linking ANDY KENNEDY
@ 2014-09-16 20:07 ` Thomas Petazzoni
2014-09-21 20:08 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-09-16 20:07 UTC (permalink / raw)
To: buildroot
Dear ANDY KENNEDY,
On Mon, 8 Sep 2014 21:43:45 +0000, ANDY KENNEDY wrote:
> Portmap builds and links, however, does not get built correctly when
> BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in
> rootfs.tar, however, portmap gets linked dynamically without regards to
> the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of
> portmap.
>
> Signed-off-by: Andy Kennedy <andy.kennedy@adtran.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] portmap: fix static linking
2014-09-08 21:43 [Buildroot] [PATCH] portmap: fix static linking ANDY KENNEDY
2014-09-16 20:07 ` Thomas Petazzoni
@ 2014-09-21 20:08 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-09-21 20:08 UTC (permalink / raw)
To: buildroot
Dear ANDY KENNEDY,
On Mon, 8 Sep 2014 21:43:45 +0000, ANDY KENNEDY wrote:
> Portmap builds and links, however, does not get built correctly when
> BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in
> rootfs.tar, however, portmap gets linked dynamically without regards to
> the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of
> portmap.
>
> Signed-off-by: Andy Kennedy <andy.kennedy@adtran.com>
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-21 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-08 21:43 [Buildroot] [PATCH] portmap: fix static linking ANDY KENNEDY
2014-09-16 20:07 ` Thomas Petazzoni
2014-09-21 20:08 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.