All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm-bsp: n1sdp: linux-linaro-arm: Disable CONFIG_EXTRA_FIRMWARE
@ 2020-05-12 15:56 Diego Sueiro
  2020-05-12 16:37 ` [meta-arm] " Bertrand Marquis
  0 siblings, 1 reply; 3+ messages in thread
From: Diego Sueiro @ 2020-05-12 15:56 UTC (permalink / raw)
  To: meta-arm; +Cc: nd

We don't want to build firmware blobs into the kernel binary. Also,
add linux-firmware-rtl8168 package to MACHINE_ESSENTIAL_EXTRA_RDEPENDS
to have it installed in any image by default.

Change-Id: If8a88a4ccbc6d474438a2555498989695a4b19dc
Issue-Id: SCM-954
Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
---
 meta-arm-bsp/conf/machine/n1sdp.conf                                   | 3 +++
 .../linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg              | 2 ++
 meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend        | 1 +
 3 files changed, 6 insertions(+)
 create mode 100644 meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg

diff --git a/meta-arm-bsp/conf/machine/n1sdp.conf b/meta-arm-bsp/conf/machine/n1sdp.conf
index b19fb86..5fddcad 100644
--- a/meta-arm-bsp/conf/machine/n1sdp.conf
+++ b/meta-arm-bsp/conf/machine/n1sdp.conf
@@ -18,3 +18,6 @@ SERIAL_CONSOLES = "115200;ttyAMA0"
 # Use kernel provided by linaro (Contains support for SCMi or HDMI)
 PREFERRED_PROVIDER_virtual/kernel ?= "linux-linaro-arm"
 PREFERRED_VERSION_linux-linaro-arm ?= "5.4%"
+
+# RTL8168E Gigabit Ethernet Controller is attached to the PCIe interface
+MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "linux-firmware-rtl8168"
diff --git a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg
new file mode 100644
index 0000000..35afddd
--- /dev/null
+++ b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg
@@ -0,0 +1,2 @@
+# We don't want to build firmware blobs into the kernel binary
+CONFIG_EXTRA_FIRMWARE=""
diff --git a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
index 9634d43..0f516c7 100644
--- a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
+++ b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
@@ -11,6 +11,7 @@ SRC_URI_append_n1sdp = " \
     file://0002-pci_quirk-add-acs-override-for-PCI-devices.patch \
     file://0003-pcie-Add-quirk-for-the-Arm-Neoverse-N1SDP-platform.patch \
     file://0004-n1sdp-update-n1sdp-pci-quirk-for-SR-IOV-support.patch \
+    file://disable-extra-fw.cfg \
     "
 
 # Referring to commit TAG N1SDP-2020.03.26
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp: n1sdp: linux-linaro-arm: Disable CONFIG_EXTRA_FIRMWARE
  2020-05-12 15:56 [PATCH] arm-bsp: n1sdp: linux-linaro-arm: Disable CONFIG_EXTRA_FIRMWARE Diego Sueiro
@ 2020-05-12 16:37 ` Bertrand Marquis
  2020-05-12 20:29   ` Jon Mason
  0 siblings, 1 reply; 3+ messages in thread
From: Bertrand Marquis @ 2020-05-12 16:37 UTC (permalink / raw)
  To: meta-arm; +Cc: nd



> On 12 May 2020, at 16:56, Diego Sueiro via lists.yoctoproject.org <diego.sueiro=arm.com@lists.yoctoproject.org> wrote:
> 
> We don't want to build firmware blobs into the kernel binary. Also,
> add linux-firmware-rtl8168 package to MACHINE_ESSENTIAL_EXTRA_RDEPENDS
> to have it installed in any image by default.
> 
> Change-Id: If8a88a4ccbc6d474438a2555498989695a4b19dc
> Issue-Id: SCM-954
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

> ---
> meta-arm-bsp/conf/machine/n1sdp.conf                                   | 3 +++
> .../linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg              | 2 ++
> meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend        | 1 +
> 3 files changed, 6 insertions(+)
> create mode 100644 meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg
> 
> diff --git a/meta-arm-bsp/conf/machine/n1sdp.conf b/meta-arm-bsp/conf/machine/n1sdp.conf
> index b19fb86..5fddcad 100644
> --- a/meta-arm-bsp/conf/machine/n1sdp.conf
> +++ b/meta-arm-bsp/conf/machine/n1sdp.conf
> @@ -18,3 +18,6 @@ SERIAL_CONSOLES = "115200;ttyAMA0"
> # Use kernel provided by linaro (Contains support for SCMi or HDMI)
> PREFERRED_PROVIDER_virtual/kernel ?= "linux-linaro-arm"
> PREFERRED_VERSION_linux-linaro-arm ?= "5.4%"
> +
> +# RTL8168E Gigabit Ethernet Controller is attached to the PCIe interface
> +MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "linux-firmware-rtl8168"
> diff --git a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg
> new file mode 100644
> index 0000000..35afddd
> --- /dev/null
> +++ b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg
> @@ -0,0 +1,2 @@
> +# We don't want to build firmware blobs into the kernel binary
> +CONFIG_EXTRA_FIRMWARE=""
> diff --git a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
> index 9634d43..0f516c7 100644
> --- a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
> +++ b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
> @@ -11,6 +11,7 @@ SRC_URI_append_n1sdp = " \
>     file://0002-pci_quirk-add-acs-override-for-PCI-devices.patch \
>     file://0003-pcie-Add-quirk-for-the-Arm-Neoverse-N1SDP-platform.patch \
>     file://0004-n1sdp-update-n1sdp-pci-quirk-for-SR-IOV-support.patch \
> +    file://disable-extra-fw.cfg \
>     "
> 
> # Referring to commit TAG N1SDP-2020.03.26
> -- 
> 2.7.4
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp: n1sdp: linux-linaro-arm: Disable CONFIG_EXTRA_FIRMWARE
  2020-05-12 16:37 ` [meta-arm] " Bertrand Marquis
@ 2020-05-12 20:29   ` Jon Mason
  0 siblings, 0 replies; 3+ messages in thread
From: Jon Mason @ 2020-05-12 20:29 UTC (permalink / raw)
  To: Bertrand Marquis; +Cc: meta-arm, nd

On Tue, May 12, 2020 at 04:37:15PM +0000, Bertrand Marquis wrote:
> 
> 
> > On 12 May 2020, at 16:56, Diego Sueiro via lists.yoctoproject.org <diego.sueiro=arm.com@lists.yoctoproject.org> wrote:
> > 
> > We don't want to build firmware blobs into the kernel binary. Also,
> > add linux-firmware-rtl8168 package to MACHINE_ESSENTIAL_EXTRA_RDEPENDS
> > to have it installed in any image by default.
> > 
> > Change-Id: If8a88a4ccbc6d474438a2555498989695a4b19dc
> > Issue-Id: SCM-954
> > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Pulled in to the master branch.

Thanks,
Jon

> 
> > ---
> > meta-arm-bsp/conf/machine/n1sdp.conf                                   | 3 +++
> > .../linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg              | 2 ++
> > meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend        | 1 +
> > 3 files changed, 6 insertions(+)
> > create mode 100644 meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg
> > 
> > diff --git a/meta-arm-bsp/conf/machine/n1sdp.conf b/meta-arm-bsp/conf/machine/n1sdp.conf
> > index b19fb86..5fddcad 100644
> > --- a/meta-arm-bsp/conf/machine/n1sdp.conf
> > +++ b/meta-arm-bsp/conf/machine/n1sdp.conf
> > @@ -18,3 +18,6 @@ SERIAL_CONSOLES = "115200;ttyAMA0"
> > # Use kernel provided by linaro (Contains support for SCMi or HDMI)
> > PREFERRED_PROVIDER_virtual/kernel ?= "linux-linaro-arm"
> > PREFERRED_VERSION_linux-linaro-arm ?= "5.4%"
> > +
> > +# RTL8168E Gigabit Ethernet Controller is attached to the PCIe interface
> > +MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "linux-firmware-rtl8168"
> > diff --git a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg
> > new file mode 100644
> > index 0000000..35afddd
> > --- /dev/null
> > +++ b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm-5.4/n1sdp/disable-extra-fw.cfg
> > @@ -0,0 +1,2 @@
> > +# We don't want to build firmware blobs into the kernel binary
> > +CONFIG_EXTRA_FIRMWARE=""
> > diff --git a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
> > index 9634d43..0f516c7 100644
> > --- a/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
> > +++ b/meta-arm-bsp/recipes-kernel/linux/linux-linaro-arm_5.4.bbappend
> > @@ -11,6 +11,7 @@ SRC_URI_append_n1sdp = " \
> >     file://0002-pci_quirk-add-acs-override-for-PCI-devices.patch \
> >     file://0003-pcie-Add-quirk-for-the-Arm-Neoverse-N1SDP-platform.patch \
> >     file://0004-n1sdp-update-n1sdp-pci-quirk-for-SR-IOV-support.patch \
> > +    file://disable-extra-fw.cfg \
> >     "
> > 
> > # Referring to commit TAG N1SDP-2020.03.26
> > -- 
> > 2.7.4
> > 
> > 
> 

> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-12 20:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 15:56 [PATCH] arm-bsp: n1sdp: linux-linaro-arm: Disable CONFIG_EXTRA_FIRMWARE Diego Sueiro
2020-05-12 16:37 ` [meta-arm] " Bertrand Marquis
2020-05-12 20:29   ` Jon Mason

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.