* [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
@ 2021-10-05 4:05 Aditya Garg
2021-10-12 11:58 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: Aditya Garg @ 2021-10-05 4:05 UTC (permalink / raw)
To: stable; +Cc: Orlando Chamberlain, andriy.shevchenko, Lee Jones
Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
PCH-N UART controler present on the MacBookPro16,2.
Cc: stable@vger.kernel.org
Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3->v4: reviewed-by line
drivers/mfd/intel-lpss-pci.c
| 2 ++
1 file changed, 2 insertions(+)
diff
--git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index c54d19fb184c..a872b4485eac 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
+ /* ICL-N */
+ { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
/* TGL-H */
{ PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
{ PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
--
2.33.0
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-05 4:05 [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART Aditya Garg
@ 2021-10-12 11:58 ` Lee Jones
2021-10-14 4:15 ` Aditya Garg
0 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2021-10-12 11:58 UTC (permalink / raw)
To: Aditya Garg; +Cc: stable, Orlando Chamberlain, andriy.shevchenko
On Tue, 05 Oct 2021, Aditya Garg wrote:
> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
> PCH-N UART controler present on the MacBookPro16,2.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
Who is the author of this patch?
Why hasn't the submitter signed it off?
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3->v4: reviewed-by line
>
> drivers/mfd/intel-lpss-pci.c
> | 2 ++
> 1 file changed, 2 insertions(+)
>
>
> diff
This is not a format I recognise.
Did you use `git send-email` to submit this?
> --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index c54d19fb184c..a872b4485eac 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
>
> @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
>
> { PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
>
> + /* ICL-N */
> + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
>
> /* TGL-H */
> { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
> { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-12 11:58 ` Lee Jones
@ 2021-10-14 4:15 ` Aditya Garg
2021-10-14 14:33 ` andriy.shevchenko
0 siblings, 1 reply; 13+ messages in thread
From: Aditya Garg @ 2021-10-14 4:15 UTC (permalink / raw)
To: Lee Jones; +Cc: stable, Orlando Chamberlain, andriy.shevchenko
From: Orlando Chamberlain <redecorating@protonmail.com>
Subject: [Patch] Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
PCH-N UART controler present on the MacBookPro16,2.
Cc: stable@vger.kernel.org
Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
Signed-off-by: Aditya Garg <gargaditya08@live.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3->v4: reviewed-by line
drivers/mfd/intel-lpss-pci.c
| 2 ++
1 file changed, 2 insertions(+)
diff
--git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index c54d19fb184c..a872b4485eac 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
+ /* ICL-N */
+ { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
/* TGL-H */
{ PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
{ PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
--
2.33.0
> On 12-Oct-2021, at 5:28 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> On Tue, 05 Oct 2021, Aditya Garg wrote:
>
>> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
>> PCH-N UART controler present on the MacBookPro16,2.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
>
> Who is the author of this patch?
>
> Why hasn't the submitter signed it off?
>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> v3->v4: reviewed-by line
>>
>> drivers/mfd/intel-lpss-pci.c
>> | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>>
>> diff
>
> This is not a format I recognise.
>
> Did you use `git send-email` to submit this?
>
>> --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
>> index c54d19fb184c..a872b4485eac 100644
>> --- a/drivers/mfd/intel-lpss-pci.c
>> +++ b/drivers/mfd/intel-lpss-pci.c
>>
>> @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
>>
>> { PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
>> { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
>> { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
>>
>> + /* ICL-N */
>> + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
>>
>> /* TGL-H */
>> { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
>> { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
Sorry for the late reply. Actually my email client marked this email as spam and put it in the junk folder.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-14 4:15 ` Aditya Garg
@ 2021-10-14 14:33 ` andriy.shevchenko
2021-10-21 11:15 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: andriy.shevchenko @ 2021-10-14 14:33 UTC (permalink / raw)
To: Aditya Garg; +Cc: Lee Jones, stable, Orlando Chamberlain
On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
Entire message looks like a mess. Are you sure you are using proper tools
for sending it?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-14 14:33 ` andriy.shevchenko
@ 2021-10-21 11:15 ` Lee Jones
2021-10-22 4:24 ` Aditya Garg
0 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2021-10-21 11:15 UTC (permalink / raw)
To: andriy.shevchenko; +Cc: Aditya Garg, stable, Orlando Chamberlain
On Thu, 14 Oct 2021, andriy.shevchenko@linux.intel.com wrote:
> On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
>
> Entire message looks like a mess. Are you sure you are using proper tools
> for sending it?
Agreed.
I can't apply this until it's submitted properly.
- Please read Documentation/process/submitting-patches.rst
- Please read Documentation/process/coding-style.rst
If you have any questions, please reach out. We're happy to help.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-21 11:15 ` Lee Jones
@ 2021-10-22 4:24 ` Aditya Garg
2021-10-22 6:02 ` Greg KH
2021-10-22 7:58 ` Lee Jones
0 siblings, 2 replies; 13+ messages in thread
From: Aditya Garg @ 2021-10-22 4:24 UTC (permalink / raw)
To: Lee Jones; +Cc: andriy.shevchenko, stable, Orlando Chamberlain
From 76d8253d90233b2c2d3fbc82355c603bf0eb9964 Mon Sep 17 00:00:00 2001
From: Orlando Chamberlain <redecorating@protonmail.com>
Date: Fri, 1 Oct 2021 13:30:19 +0530
Subject: [PATCH] Add support for MacBookPro16,2 UART
Cc: stable@vger.kernel.org
Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controller present on the MacBookPro16,2.
Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
drivers/mfd/intel-lpss-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index c54d19fb1..33d5043fd 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
+ /* ICL-N*/
+ { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
/* TGL-H */
{ PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
{ PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
> On 21-Oct-2021, at 4:45 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> On Thu, 14 Oct 2021, andriy.shevchenko@linux.intel.com wrote:
>
>> On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
>>
>> Entire message looks like a mess. Are you sure you are using proper tools
>> for sending it?
>
> Agreed.
>
> I can't apply this until it's submitted properly.
>
> - Please read Documentation/process/submitting-patches.rst
> - Please read Documentation/process/coding-style.rst
>
> If you have any questions, please reach out. We're happy to help.
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-22 4:24 ` Aditya Garg
@ 2021-10-22 6:02 ` Greg KH
2021-10-22 7:58 ` Lee Jones
1 sibling, 0 replies; 13+ messages in thread
From: Greg KH @ 2021-10-22 6:02 UTC (permalink / raw)
To: Aditya Garg; +Cc: Lee Jones, andriy.shevchenko, stable, Orlando Chamberlain
On Fri, Oct 22, 2021 at 04:24:47AM +0000, Aditya Garg wrote:
>
> From 76d8253d90233b2c2d3fbc82355c603bf0eb9964 Mon Sep 17 00:00:00 2001
> From: Orlando Chamberlain <redecorating@protonmail.com>
> Date: Fri, 1 Oct 2021 13:30:19 +0530
> Subject: [PATCH] Add support for MacBookPro16,2 UART
> Cc: stable@vger.kernel.org
>
> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controller present on the MacBookPro16,2.
>
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
> drivers/mfd/intel-lpss-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-22 4:24 ` Aditya Garg
2021-10-22 6:02 ` Greg KH
@ 2021-10-22 7:58 ` Lee Jones
[not found] ` <PNZPR01MB44151488C970DB48157D5AFCB8809@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
1 sibling, 1 reply; 13+ messages in thread
From: Lee Jones @ 2021-10-22 7:58 UTC (permalink / raw)
To: Aditya Garg; +Cc: andriy.shevchenko, stable, Orlando Chamberlain
On Fri, 22 Oct 2021, Aditya Garg wrote:
>
> From 76d8253d90233b2c2d3fbc82355c603bf0eb9964 Mon Sep 17 00:00:00 2001
> From: Orlando Chamberlain <redecorating@protonmail.com>
> Date: Fri, 1 Oct 2021 13:30:19 +0530
> Subject: [PATCH] Add support for MacBookPro16,2 UART
> Cc: stable@vger.kernel.org
What is this?
These headers should not be part of the patch.
How are you submitting this?
What tools are you using?
Did you read the documents I sent you (see below)?
> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controller present on the MacBookPro16,2.
This line is too long.
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
> drivers/mfd/intel-lpss-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
This diff looks better.
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index c54d19fb1..33d5043fd 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> { PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
> + /* ICL-N*/
> + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
> /* TGL-H */
> { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
> { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
>
> > On 21-Oct-2021, at 4:45 PM, Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Thu, 14 Oct 2021, andriy.shevchenko@linux.intel.com wrote:
> >
> >> On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
> >>
> >> Entire message looks like a mess. Are you sure you are using proper tools
> >> for sending it?
> >
> > Agreed.
> >
> > I can't apply this until it's submitted properly.
> >
> > - Please read Documentation/process/submitting-patches.rst
> > - Please read Documentation/process/coding-style.rst
> >
> > If you have any questions, please reach out. We're happy to help.
> >
This quoted text can't be part of a submitted patch.
Please submit the patch on its own, as a new thread, using the correct
tooling (provided mostly by the Git package (i.e. `git format-patch`
and `git send-email`).
If you're stuck, or there is something you do not understand, please
ask.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
[not found] ` <PNZPR01MB44151488C970DB48157D5AFCB8809@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
@ 2021-10-22 15:09 ` andriy.shevchenko
0 siblings, 0 replies; 13+ messages in thread
From: andriy.shevchenko @ 2021-10-22 15:09 UTC (permalink / raw)
To: Aditya Garg; +Cc: Lee Jones, stable, Orlando Chamberlain
On Fri, Oct 22, 2021 at 12:43:33PM +0000, Aditya Garg wrote:
> I am really sorry. I don’t have any experience regarding submitting patches upstream. I copied and pasted the diff generated using git. My email client doesn’t seem to support git send email. I would be happy if I could get some guidance.
First and very important guidance: do not top-post!
Next, as Lee pointed out there are available documents on how to submit patches
properly. Please, read them (they are available inside kernel source tree as
well).
TL;DR: again as Lee said, `git format-patch` (produces a file in mbox format)
followed by `git send-email` will suffice.
> From: Lee Jones <lee.jones@linaro.org>
> Sent: Friday, October 22, 2021 1:28:42 PM
> To: Aditya Garg <gargaditya08@live.com>
> Cc: andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com>; stable@vger.kernel.org <stable@vger.kernel.org>; Orlando Chamberlain <redecorating@protonmail.com>
> Subject: Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
>
> On Fri, 22 Oct 2021, Aditya Garg wrote:
>
> >
> > From 76d8253d90233b2c2d3fbc82355c603bf0eb9964 Mon Sep 17 00:00:00 2001
> > From: Orlando Chamberlain <redecorating@protonmail.com>
> > Date: Fri, 1 Oct 2021 13:30:19 +0530
> > Subject: [PATCH] Add support for MacBookPro16,2 UART
> > Cc: stable@vger.kernel.org
>
> What is this?
>
> These headers should not be part of the patch.
>
> How are you submitting this?
> What tools are you using?
> Did you read the documents I sent you (see below)?
>
> > Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controller present on the MacBookPro16,2.
>
> This line is too long.
>
> > Signed-off-by: Aditya Garg <gargaditya08@live.com>
> > ---
> > drivers/mfd/intel-lpss-pci.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> This diff looks better.
>
> > diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> > index c54d19fb1..33d5043fd 100644
> > --- a/drivers/mfd/intel-lpss-pci.c
> > +++ b/drivers/mfd/intel-lpss-pci.c
> > @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> > { PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
> > { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
> > { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
> > + /* ICL-N*/
> > + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
> > /* TGL-H */
> > { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
> > { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
> >
> > > On 21-Oct-2021, at 4:45 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Thu, 14 Oct 2021, andriy.shevchenko@linux.intel.com wrote:
> > >
> > >> On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
> > >>
> > >> Entire message looks like a mess. Are you sure you are using proper tools
> > >> for sending it?
> > >
> > > Agreed.
> > >
> > > I can't apply this until it's submitted properly.
> > >
> > > - Please read Documentation/process/submitting-patches.rst
> > > - Please read Documentation/process/coding-style.rst
> > >
> > > If you have any questions, please reach out. We're happy to help.
> > >
>
> This quoted text can't be part of a submitted patch.
>
> Please submit the patch on its own, as a new thread, using the correct
> tooling (provided mostly by the Git package (i.e. `git format-patch`
> and `git send-email`).
>
> If you're stuck, or there is something you do not understand, please
> ask.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-04 15:58 ` Aditya Garg
@ 2021-10-04 16:10 ` Lee Jones
0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-10-04 16:10 UTC (permalink / raw)
To: Aditya Garg; +Cc: Orlando Chamberlain, andriy.shevchenko, linux-kernel
On Mon, 04 Oct 2021, Aditya Garg wrote:
> Hi Lee
>
> I request you to Backport this to 5.10 as well
Please read:
Documentation/process/stable-kernel-rules.rst
If you think this patches meets the criteria you can submit it for
inclusion to the Stable kernel yourself using one of the documented
'Options'.
> > On 04-Oct-2021, at 12:47 PM, Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Sat, 02 Oct 2021, Orlando Chamberlain wrote:
> >
> >> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
> >> PCH-N UART controler present on the MacBookPro16,2.
> >>
> >> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> ---
> >> v3->v4: reviewed-by line
> >> drivers/mfd/intel-lpss-pci.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >
> > Applied, thanks.
> >
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-04 7:17 ` Lee Jones
@ 2021-10-04 15:58 ` Aditya Garg
2021-10-04 16:10 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: Aditya Garg @ 2021-10-04 15:58 UTC (permalink / raw)
To: Lee Jones; +Cc: Orlando Chamberlain, andriy.shevchenko, linux-kernel
Hi Lee
I request you to Backport this to 5.10 as well
Regards
Aditya
> On 04-Oct-2021, at 12:47 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> On Sat, 02 Oct 2021, Orlando Chamberlain wrote:
>
>> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
>> PCH-N UART controler present on the MacBookPro16,2.
>>
>> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> v3->v4: reviewed-by line
>> drivers/mfd/intel-lpss-pci.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Applied, thanks.
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-02 11:16 ` [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART Orlando Chamberlain
@ 2021-10-04 7:17 ` Lee Jones
2021-10-04 15:58 ` Aditya Garg
0 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2021-10-04 7:17 UTC (permalink / raw)
To: Orlando Chamberlain; +Cc: andriy.shevchenko, linux-kernel
On Sat, 02 Oct 2021, Orlando Chamberlain wrote:
> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
> PCH-N UART controler present on the MacBookPro16,2.
>
> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3->v4: reviewed-by line
> drivers/mfd/intel-lpss-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
2021-10-01 8:51 [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART Orlando Chamberlain
@ 2021-10-02 11:16 ` Orlando Chamberlain
2021-10-04 7:17 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: Orlando Chamberlain @ 2021-10-02 11:16 UTC (permalink / raw)
To: redecorating; +Cc: andriy.shevchenko, lee.jones, linux-kernel
Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
PCH-N UART controler present on the MacBookPro16,2.
Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3->v4: reviewed-by line
drivers/mfd/intel-lpss-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index c54d19fb184c..a872b4485eac 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
+ /* ICL-N */
+ { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
/* TGL-H */
{ PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
{ PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
--
2.33.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-10-22 15:09 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-05 4:05 [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART Aditya Garg
2021-10-12 11:58 ` Lee Jones
2021-10-14 4:15 ` Aditya Garg
2021-10-14 14:33 ` andriy.shevchenko
2021-10-21 11:15 ` Lee Jones
2021-10-22 4:24 ` Aditya Garg
2021-10-22 6:02 ` Greg KH
2021-10-22 7:58 ` Lee Jones
[not found] ` <PNZPR01MB44151488C970DB48157D5AFCB8809@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
2021-10-22 15:09 ` andriy.shevchenko
-- strict thread matches above, loose matches on Subject: below --
2021-10-01 8:51 [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART Orlando Chamberlain
2021-10-02 11:16 ` [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART Orlando Chamberlain
2021-10-04 7:17 ` Lee Jones
2021-10-04 15:58 ` Aditya Garg
2021-10-04 16:10 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.