All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nelson, Shannon" <shannon.nelson@intel.com>
To: "Liang, Kan" <kan.liang@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"bwh@kernel.org" <bwh@kernel.org>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
	"andi@firstfloor.org" <andi@firstfloor.org>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@intel.com>,
	"Skidmore, Donald C" <donald.c.skidmore@intel.com>,
	"Williams, Mitch A" <mitch.a.williams@intel.com>,
	"ogerlitz@mellanox.com" <ogerlitz@mellanox.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"jiri@mellanox.com" <jiri@mellanox.com>,
	"sfeldma@gmail.com" <sfeldma@gmail.com>,
	"gospo@cumulusnetworks.com" <gospo@cumulusnetworks.com>,
	"sasha.levin@oracle.com" <sasha.levin@oracle.com>,
	"dsahern@gmail.com" <dsahern@gmail.com>,
	"tj@kernel.org" <tj@kernel.org>,
	"cascardo@redhat.com" <cascardo@redhat.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"ben@decadent.org.uk" <ben@decadent.org
Subject: RE: [PATCH V2 5/5] i40e/ethtool: support coalesce setting by queue
Date: Wed, 13 Jan 2016 18:19:30 +0000	[thread overview]
Message-ID: <FC41C24E35F18A40888AACA1A36F3E418AFE4C1F@fmsmsx115.amr.corp.intel.com> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0770586E7D8@SHSMSX103.ccr.corp.intel.com>

> From: Liang, Kan
> >
> > This looks reasonable, but be aware that since there's no concept of
> > queue-specific settings in the driver proper, these settings will get
> lost on
> > the next reset - see i40e_vsi_configure_msix().  A reset can be driven
> by a
> > number of things such as MTU changes, LLDP events, tx timeout recovery,
> > promiscuous on/off, and various other configuration changes.  This might
> > not be acceptable for your needs.
> >
> 
> Yes, the reset could be an issue.
> I guess we may make the concept of queue-specific settings for i40e by
> moving
> rx_itr_setting and tx_itr_setting to i40e_ring.
> 
> How about the patch as below?
> The patch only move itr_setting from i40e_vsi to i40e_ring.
> There should be no behavior change.
> 

Thanks, I finally had a chance to look through this.  On an initial read-through, yes, this would probably take care of it.

sln

      reply	other threads:[~2016-01-13 18:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 12:53 [PATCH V2 1/5] net/ethtool: introduce a new ioctl for per queue setting kan.liang
2016-01-04 12:53 ` [PATCH V2 2/5] net/ethtool: support get coalesce per queue kan.liang
2016-01-04 12:53 ` [PATCH V2 3/5] net/ethtool: support set " kan.liang
2016-01-04 12:54 ` [PATCH V2 4/5] i40e/ethtool: support coalesce getting by queue kan.liang
2016-01-07 22:19   ` Nelson, Shannon
2016-01-04 12:54 ` [PATCH V2 5/5] i40e/ethtool: support coalesce setting " kan.liang
2016-01-07 22:25   ` Nelson, Shannon
2016-01-08 19:55     ` Liang, Kan
2016-01-13 18:19       ` Nelson, Shannon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FC41C24E35F18A40888AACA1A36F3E418AFE4C1F@fmsmsx115.amr.corp.intel.com \
    --to=shannon.nelson@intel.com \
    --cc=alexander.duyck@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=ben@decadent.org \
    --cc=bwh@kernel.org \
    --cc=carolyn.wyborny@intel.com \
    --cc=cascardo@redhat.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=donald.c.skidmore@intel.com \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jiri@mellanox.com \
    --cc=kan.liang@intel.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=sasha.levin@oracle.com \
    --cc=sfeldma@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.