[PATCH v3 0/3] OMAP: DSS2: OMAPFB: Allow FB_OMAP2 to build without VRFB

[PATCH v3 0/3] OMAP: DSS2: OMAPFB: Allow FB_OMAP2 to build without VRFB

[Guruswamy Senthilvadivu]

From: Senthilvadivu Guruswamy  <svadivu@ti.com>

This patch series is the same as v3 content along with the naming
conventions followed for the patch subject.

The changelog till v3 are:
	- Address Multi-omap build issue
	- Added a check to warn the wrong usage of vrfb 
	in non-vrfb omap devices.
	

Thanks,
Senthil

[PATCH v3 1/3] OMAP: DSS2: OMAPFB: Allow FB_OMAP2 to build without VRFB

[Guruswamy Senthilvadivu]

From: Senthilvadivu Guruswamy <svadivu@ti.com>

FB_OMAP2 can work without VRFB, but currently does not build. Fix this.

Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
---
 arch/arm/plat-omap/include/plat/vrfb.h |   16 ++++++++++++++++
 1 file changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-omap/include/plat/vrfb.h b/arch/arm/plat-omap/include/plat/vrfb.h
index d8a03ce..3792bde 100644
--- a/arch/arm/plat-omap/include/plat/vrfb.h
+++ b/arch/arm/plat-omap/include/plat/vrfb.h
@@ -35,6 +35,7 @@ struct vrfb {
 	bool yuv_mode;
 };
 
+#ifdef CONFIG_OMAP2_VRFB
 extern int omap_vrfb_request_ctx(struct vrfb *vrfb);
 extern void omap_vrfb_release_ctx(struct vrfb *vrfb);
 extern void omap_vrfb_adjust_size(u16 *width, u16 *height,
@@ -47,4 +48,19 @@ extern void omap_vrfb_setup(struct vrfb *vrfb, unsigned long paddr,
 extern int omap_vrfb_map_angle(struct vrfb *vrfb, u16 height, u8 rot);
 extern void omap_vrfb_restore_context(void);
 
+#else
+static inline int omap_vrfb_request_ctx(struct vrfb *vrfb) { return 0; }
+static inline void omap_vrfb_release_ctx(struct vrfb *vrfb) {}
+static inline void omap_vrfb_adjust_size(u16 *width, u16 *height,
+		u8 bytespp) {}
+static inline u32 omap_vrfb_min_phys_size(u16 width, u16 height, u8 bytespp)
+		{ return 0; }
+static inline u16 omap_vrfb_max_height(u32 phys_size, u16 width, u8 bytespp)
+		{ return 0; }
+static inline void omap_vrfb_setup(struct vrfb *vrfb, unsigned long paddr,
+		u16 width, u16 height, unsigned bytespp, bool yuv_mode) {}
+static inline int omap_vrfb_map_angle(struct vrfb *vrfb, u16 height, u8 rot)
+		{ return 0; }
+static inline void omap_vrfb_restore_context(void) {}
+#endif
 #endif /* __VRFB_H */
-- 
1.5.4.7

[PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Guruswamy Senthilvadivu]

From: Senthilvadivu Guruswamy <svadivu@ti.com>

config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.

Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
---
 drivers/video/omap2/Kconfig            |    4 ++++
 drivers/video/omap2/omapfb/Kconfig     |    1 -
 2 files changed,  4 insertions(+), 1 deletions(-)

diff --git a/drivers/video/omap2/Kconfig b/drivers/video/omap2/Kconfig
index d877c36..18bb835 100644
--- a/drivers/video/omap2/Kconfig
+++ b/drivers/video/omap2/Kconfig
@@ -3,6 +3,10 @@ config OMAP2_VRAM
 
 config OMAP2_VRFB
 	bool
+	depends on ARCH_OMAP2 || ARCH_OMAP3
+	default y if FB_OMAP2
+	help
+	  OMAP VRFB buffer support is efficient for rotation
 
 source "drivers/video/omap2/dss/Kconfig"
 source "drivers/video/omap2/omapfb/Kconfig"
diff --git a/drivers/video/omap2/omapfb/Kconfig b/drivers/video/omap2/omapfb/Kconfig
index a3ed15c..f186c2b 100644
--- a/drivers/video/omap2/omapfb/Kconfig
+++ b/drivers/video/omap2/omapfb/Kconfig
@@ -3,7 +3,6 @@ menuconfig FB_OMAP2
         depends on FB && OMAP2_DSS
 
 	select OMAP2_VRAM
-	select OMAP2_VRFB
         select FB_CFB_FILLRECT
         select FB_CFB_COPYAREA
         select FB_CFB_IMAGEBLIT
-- 
1.5.4.7

[PATCH v3 3/3] OMAP: DSS2: OMAPFB: Allow usage of def_vrfb only for omap2,3

[Guruswamy Senthilvadivu]

From: Senthilvadivu Guruswamy <svadivu@ti.com>

Force def_vrfb to 0 for non omap2, omap3 devices

Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
---
 drivers/video/omap2/omapfb/omapfb-main.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 4b4506d..0f79db8 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -2128,6 +2128,16 @@ static int omapfb_probe(struct platform_device *pdev)
 		goto err0;
 	}
 
+	/* TODO : Replace cpu check with omap_has_vrfb once HAS_FEATURE
+	*	 available for OMAP2 and OMAP3
+	*/
+	if (def_vrfb && (!cpu_is_omap24xx()) && (!cpu_is_omap34xx())) {
+		def_vrfb = 0;
+		dev_warn(&pdev->dev, "VRFB is not in this device,"
+				"using DMA for rotation\n");
+	}
+
+
 	mutex_init(&fbdev->mtx);
 
 	fbdev->dev = &pdev->dev;
-- 
1.6.3.3

Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Tomi Valkeinen]

On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy Senthilvadivu wrote:
> From: Senthilvadivu Guruswamy <svadivu@ti.com>
> 
> config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> 
> Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
> ---
>  drivers/video/omap2/Kconfig            |    4 ++++
>  drivers/video/omap2/omapfb/Kconfig     |    1 -
>  2 files changed,  4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/omap2/Kconfig b/drivers/video/omap2/Kconfig
> index d877c36..18bb835 100644
> --- a/drivers/video/omap2/Kconfig
> +++ b/drivers/video/omap2/Kconfig
> @@ -3,6 +3,10 @@ config OMAP2_VRAM
>  
>  config OMAP2_VRFB
>  	bool
> +	depends on ARCH_OMAP2 || ARCH_OMAP3
> +	default y if FB_OMAP2
> +	help
> +	  OMAP VRFB buffer support is efficient for rotation
>  
>  source "drivers/video/omap2/dss/Kconfig"
>  source "drivers/video/omap2/omapfb/Kconfig"
> diff --git a/drivers/video/omap2/omapfb/Kconfig b/drivers/video/omap2/omapfb/Kconfig
> index a3ed15c..f186c2b 100644
> --- a/drivers/video/omap2/omapfb/Kconfig
> +++ b/drivers/video/omap2/omapfb/Kconfig
> @@ -3,7 +3,6 @@ menuconfig FB_OMAP2
>          depends on FB && OMAP2_DSS
>  
>  	select OMAP2_VRAM
> -	select OMAP2_VRFB
>          select FB_CFB_FILLRECT
>          select FB_CFB_COPYAREA
>          select FB_CFB_IMAGEBLIT

This is second patch set marked as v3. Please update the version for
every patch set.

I think the config selection is now a bit confusing. I think it should
either be:

The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3

or

Let the user select VRFB.

 Tomi

RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: Monday, June 21, 2010 2:21 PM
> To: Guruswamy, Senthilvadivu
> Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; tony@atomide.com;
> Hiremath, Vaibhav
> Subject: Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3
> 
> On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy Senthilvadivu wrote:
> > From: Senthilvadivu Guruswamy <svadivu@ti.com>
> >
> > config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> >
> > Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
> > ---
> >  drivers/video/omap2/Kconfig            |    4 ++++
> >  drivers/video/omap2/omapfb/Kconfig     |    1 -
> >  2 files changed,  4 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/video/omap2/Kconfig b/drivers/video/omap2/Kconfig
> > index d877c36..18bb835 100644
> > --- a/drivers/video/omap2/Kconfig
> > +++ b/drivers/video/omap2/Kconfig
> > @@ -3,6 +3,10 @@ config OMAP2_VRAM
> >
> >  config OMAP2_VRFB
> >  	bool
> > +	depends on ARCH_OMAP2 || ARCH_OMAP3
> > +	default y if FB_OMAP2
> > +	help
> > +	  OMAP VRFB buffer support is efficient for rotation
> >
> >  source "drivers/video/omap2/dss/Kconfig"
> >  source "drivers/video/omap2/omapfb/Kconfig"
> > diff --git a/drivers/video/omap2/omapfb/Kconfig
> b/drivers/video/omap2/omapfb/Kconfig
> > index a3ed15c..f186c2b 100644
> > --- a/drivers/video/omap2/omapfb/Kconfig
> > +++ b/drivers/video/omap2/omapfb/Kconfig
> > @@ -3,7 +3,6 @@ menuconfig FB_OMAP2
> >          depends on FB && OMAP2_DSS
> >
> >  	select OMAP2_VRAM
> > -	select OMAP2_VRFB
> >          select FB_CFB_FILLRECT
> >          select FB_CFB_COPYAREA
> >          select FB_CFB_IMAGEBLIT
> 
> This is second patch set marked as v3. Please update the version for
> every patch set.
> 
> I think the config selection is now a bit confusing. I think it should
> either be:
> 
> The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
> select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
> 
[Hiremath, Vaibhav] If you are doing something like this, then please do not forget to change V4L2 Display driver also.

Thanks,
Vaibhav

> or
> 
> Let the user select VRFB.
> 
>  Tomi
> 

RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Guruswamy, Senthilvadivu]

 

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com] 
> Sent: Monday, June 21, 2010 2:21 PM
> To: Guruswamy, Senthilvadivu
> Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; 
> tony@atomide.com; Hiremath, Vaibhav
> Subject: Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB 
> depends on OMAP2,3
> 
> On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy Senthilvadivu wrote:
> > From: Senthilvadivu Guruswamy <svadivu@ti.com>
> > 
> > config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> > 
> > Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
> > ---
> >  drivers/video/omap2/Kconfig            |    4 ++++
> >  drivers/video/omap2/omapfb/Kconfig     |    1 -
> >  2 files changed,  4 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/video/omap2/Kconfig 
> b/drivers/video/omap2/Kconfig
> > index d877c36..18bb835 100644
> > --- a/drivers/video/omap2/Kconfig
> > +++ b/drivers/video/omap2/Kconfig
> > @@ -3,6 +3,10 @@ config OMAP2_VRAM
> >  
> >  config OMAP2_VRFB
> >  	bool
> > +	depends on ARCH_OMAP2 || ARCH_OMAP3
> > +	default y if FB_OMAP2
> > +	help
> > +	  OMAP VRFB buffer support is efficient for rotation
> >  
> >  source "drivers/video/omap2/dss/Kconfig"
> >  source "drivers/video/omap2/omapfb/Kconfig"
> > diff --git a/drivers/video/omap2/omapfb/Kconfig 
> b/drivers/video/omap2/omapfb/Kconfig
> > index a3ed15c..f186c2b 100644
> > --- a/drivers/video/omap2/omapfb/Kconfig
> > +++ b/drivers/video/omap2/omapfb/Kconfig
> > @@ -3,7 +3,6 @@ menuconfig FB_OMAP2
> >          depends on FB && OMAP2_DSS
> >  
> >  	select OMAP2_VRAM
> > -	select OMAP2_VRFB
> >          select FB_CFB_FILLRECT
> >          select FB_CFB_COPYAREA
> >          select FB_CFB_IMAGEBLIT
> 
> This is second patch set marked as v3. Please update the version for
> every patch set.
[Senthil]  With this comment the patch would really become v3.  
Do you mean to say that the 1/3 should be of v1, and 2/3 of v3 and 3/3 of no version number?
I though I should apply the latest version to the whole patches in the series.

> I think the config selection is now a bit confusing. I think it should
> either be:
> 
> The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
> select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
[Senthil]  I would choose this to avoid another user selection in menuconfig.
Selecting conditionally would be of minimal change than the present patch.
> or
> 
> Let the user select VRFB.
> 
>  Tomi
> 
> 
> 

RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Guruswamy, Senthilvadivu]

 

> -----Original Message-----
> From: Hiremath, Vaibhav 
> Sent: Monday, June 21, 2010 2:27 PM
> To: Tomi Valkeinen; Guruswamy, Senthilvadivu
> Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; 
> tony@atomide.com
> Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB 
> depends on OMAP2,3
> 
> > -----Original Message-----
> > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> > Sent: Monday, June 21, 2010 2:21 PM
> > To: Guruswamy, Senthilvadivu
> > Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; 
> tony@atomide.com;
> > Hiremath, Vaibhav
> > Subject: Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB 
> depends on OMAP2,3
> > 
> > On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy 
> Senthilvadivu wrote:
> > > From: Senthilvadivu Guruswamy <svadivu@ti.com>
> > >
> > > config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> > >
> > > Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
> > > ---
> > >  drivers/video/omap2/Kconfig            |    4 ++++
> > >  drivers/video/omap2/omapfb/Kconfig     |    1 -
> > >  2 files changed,  4 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/video/omap2/Kconfig 
> b/drivers/video/omap2/Kconfig
> > > index d877c36..18bb835 100644
> > > --- a/drivers/video/omap2/Kconfig
> > > +++ b/drivers/video/omap2/Kconfig
> > > @@ -3,6 +3,10 @@ config OMAP2_VRAM
> > >
> > >  config OMAP2_VRFB
> > >  	bool
> > > +	depends on ARCH_OMAP2 || ARCH_OMAP3
> > > +	default y if FB_OMAP2
> > > +	help
> > > +	  OMAP VRFB buffer support is efficient for rotation
> > >
> > >  source "drivers/video/omap2/dss/Kconfig"
> > >  source "drivers/video/omap2/omapfb/Kconfig"
> > > diff --git a/drivers/video/omap2/omapfb/Kconfig
> > b/drivers/video/omap2/omapfb/Kconfig
> > > index a3ed15c..f186c2b 100644
> > > --- a/drivers/video/omap2/omapfb/Kconfig
> > > +++ b/drivers/video/omap2/omapfb/Kconfig
> > > @@ -3,7 +3,6 @@ menuconfig FB_OMAP2
> > >          depends on FB && OMAP2_DSS
> > >
> > >  	select OMAP2_VRAM
> > > -	select OMAP2_VRFB
> > >          select FB_CFB_FILLRECT
> > >          select FB_CFB_COPYAREA
> > >          select FB_CFB_IMAGEBLIT
> > 
> > This is second patch set marked as v3. Please update the version for
> > every patch set.
> > 
> > I think the config selection is now a bit confusing. I 
> think it should
> > either be:
> > 
> > The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
> > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
> > 
> [Hiremath, Vaibhav] If you are doing something like this, 
> then please do not forget to change V4L2 Display driver also.
[Senthil]  Yes, I would send a patch with a similar change in
media/video/omap/Kconfig also.
> Thanks,
> Vaibhav
> 
> > or
> > 
> > Let the user select VRFB.
> > 
> >  Tomi
> > 
> 
> 

RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Guruswamy, Senthilvadivu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 2609 bytes --]

 

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com] 
> Sent: Monday, June 21, 2010 2:21 PM
> To: Guruswamy, Senthilvadivu
> Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; 
> tony@atomide.com; Hiremath, Vaibhav
> Subject: Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB 
> depends on OMAP2,3
> 
> On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy Senthilvadivu wrote:
> > From: Senthilvadivu Guruswamy <svadivu@ti.com>
> > 
> > config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> > 
> > Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
> > ---
> >  drivers/video/omap2/Kconfig            |    4 ++++
> >  drivers/video/omap2/omapfb/Kconfig     |    1 -
> >  2 files changed,  4 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/video/omap2/Kconfig 
> b/drivers/video/omap2/Kconfig
> > index d877c36..18bb835 100644
> > --- a/drivers/video/omap2/Kconfig
> > +++ b/drivers/video/omap2/Kconfig
> > @@ -3,6 +3,10 @@ config OMAP2_VRAM
> >  
> >  config OMAP2_VRFB
> >  	bool
> > +	depends on ARCH_OMAP2 || ARCH_OMAP3
> > +	default y if FB_OMAP2
> > +	help
> > +	  OMAP VRFB buffer support is efficient for rotation
> >  
> >  source "drivers/video/omap2/dss/Kconfig"
> >  source "drivers/video/omap2/omapfb/Kconfig"
> > diff --git a/drivers/video/omap2/omapfb/Kconfig 
> b/drivers/video/omap2/omapfb/Kconfig
> > index a3ed15c..f186c2b 100644
> > --- a/drivers/video/omap2/omapfb/Kconfig
> > +++ b/drivers/video/omap2/omapfb/Kconfig
> > @@ -3,7 +3,6 @@ menuconfig FB_OMAP2
> >          depends on FB && OMAP2_DSS
> >  
> >  	select OMAP2_VRAM
> > -	select OMAP2_VRFB
> >          select FB_CFB_FILLRECT
> >          select FB_CFB_COPYAREA
> >          select FB_CFB_IMAGEBLIT
> 
> This is second patch set marked as v3. Please update the version for
> every patch set.
[Senthil]  With this comment the patch would really become v3.  
Do you mean to say that the 1/3 should be of v1, and 2/3 of v3 and 3/3 of no version number?
I though I should apply the latest version to the whole patches in the series.

> I think the config selection is now a bit confusing. I think it should
> either be:
> 
> The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
> select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
[Senthil]  I would choose this to avoid another user selection in menuconfig.
Selecting conditionally would be of minimal change than the present patch.
> or
> 
> Let the user select VRFB.
> 
>  Tomi
> 
> 
> ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ýöÝzÿâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm

RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Tomi Valkeinen]

On Mon, 2010-06-21 at 11:17 +0200, ext Guruswamy, Senthilvadivu wrote:

> > This is second patch set marked as v3. Please update the version for
> > every patch set.
> [Senthil]  With this comment the patch would really become v3.  
> Do you mean to say that the 1/3 should be of v1, and 2/3 of v3 and 3/3 of no version number?
> I though I should apply the latest version to the whole patches in the series.

I mean that you sent a v3 patch set at 10th of june, and again a
different v3 patch set at 17th of june.

 Tomi

RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Tomi Valkeinen]

On Mon, 2010-06-21 at 11:17 +0200, ext Guruswamy, Senthilvadivu wrote:

> > This is second patch set marked as v3. Please update the version for
> > every patch set.
> [Senthil]  With this comment the patch would really become v3.  
> Do you mean to say that the 1/3 should be of v1, and 2/3 of v3 and 3/3 of no version number?
> I though I should apply the latest version to the whole patches in the series.

I mean that you sent a v3 patch set at 10th of june, and again a
different v3 patch set at 17th of june.

 Tomi

RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Guruswamy, Senthilvadivu]

 

> -----Original Message-----
> From: Guruswamy, Senthilvadivu 
> Sent: Monday, June 21, 2010 2:52 PM
> To: Hiremath, Vaibhav; Tomi Valkeinen
> Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; 
> tony@atomide.com
> Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB 
> depends on OMAP2,3
> 
>  
> 
> > -----Original Message-----
> > From: Hiremath, Vaibhav 
> > Sent: Monday, June 21, 2010 2:27 PM
> > To: Tomi Valkeinen; Guruswamy, Senthilvadivu
> > Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; 
> > tony@atomide.com
> > Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB 
> > depends on OMAP2,3
> > 
> > > -----Original Message-----
> > > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> > > Sent: Monday, June 21, 2010 2:21 PM
> > > To: Guruswamy, Senthilvadivu
> > > Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; 
> > tony@atomide.com;
> > > Hiremath, Vaibhav
> > > Subject: Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB 
> > depends on OMAP2,3
> > > 
> > > On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy 
> > Senthilvadivu wrote:
> > > > From: Senthilvadivu Guruswamy <svadivu@ti.com>
> > > >
> > > > config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> > > >
> > > > Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
> > > > ---
> > > >  drivers/video/omap2/Kconfig            |    4 ++++
> > > >  drivers/video/omap2/omapfb/Kconfig     |    1 -
> > > >  2 files changed,  4 insertions(+), 1 deletions(-)
<snip>
> > > The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
> > > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
> > > 
> > [Hiremath, Vaibhav] If you are doing something like this, 
> > then please do not forget to change V4L2 Display driver also.
> [Senthil]  Yes, I would send a patch with a similar change in
> media/video/omap/Kconfig also.
[Senthil]  This V4L2 related patch would be along with the V4L2 change
set, as it requires some work on the omap_vout.c also along with the kconfig change.

Regards,
Senthil

RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Guruswamy, Senthilvadivu
> Sent: Tuesday, June 22, 2010 5:29 PM
> To: Guruswamy, Senthilvadivu; Hiremath, Vaibhav; Tomi Valkeinen
> Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org; tony@atomide.com
> Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3
> 
> 
> 
> > -----Original Message-----
> > From: Guruswamy, Senthilvadivu
> > Sent: Monday, June 21, 2010 2:52 PM
> > To: Hiremath, Vaibhav; Tomi Valkeinen
> > Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org;
> > tony@atomide.com
> > Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB
> > depends on OMAP2,3
> >
> >
> >
> > > -----Original Message-----
> > > From: Hiremath, Vaibhav
> > > Sent: Monday, June 21, 2010 2:27 PM
> > > To: Tomi Valkeinen; Guruswamy, Senthilvadivu
> > > Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org;
> > > tony@atomide.com
> > > Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB
> > > depends on OMAP2,3
> > >
> > > > -----Original Message-----
> > > > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> > > > Sent: Monday, June 21, 2010 2:21 PM
> > > > To: Guruswamy, Senthilvadivu
> > > > Cc: linux-omap@vger.kernel.org; linux-dev@vger.kernel.org;
> > > tony@atomide.com;
> > > > Hiremath, Vaibhav
> > > > Subject: Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB
> > > depends on OMAP2,3
> > > >
> > > > On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy
> > > Senthilvadivu wrote:
> > > > > From: Senthilvadivu Guruswamy <svadivu@ti.com>
> > > > >
> > > > > config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> > > > >
> > > > > Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
> > > > > ---
> > > > >  drivers/video/omap2/Kconfig            |    4 ++++
> > > > >  drivers/video/omap2/omapfb/Kconfig     |    1 -
> > > > >  2 files changed,  4 insertions(+), 1 deletions(-)
> <snip>
> > > > The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
> > > > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
> > > >
> > > [Hiremath, Vaibhav] If you are doing something like this,
> > > then please do not forget to change V4L2 Display driver also.
> > [Senthil]  Yes, I would send a patch with a similar change in
> > media/video/omap/Kconfig also.
> [Senthil]  This V4L2 related patch would be along with the V4L2 change
> set, as it requires some work on the omap_vout.c also along with the kconfig
> change.
> 
[Hiremath, Vaibhav] I think we are creating confusion here, on Fbdev side it looks clean, but on V4L2 side you are still enabling VRFB. So if you try to enable V4L2 display driver then it automatically enabled VRFB.

I still feel changes in V4L2 driver should be part of this patch series to maintain consistency.

Thanks,
Vaibhav

> Regards,
> Senthil