Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs

Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs

[Andrew Cooper]

On 14/07/2022 11:12, Luca Fancellu wrote:
> + CC x86 maintainers
>
>> On 14 Jul 2022, at 10:40, Mathieu Tarral <mathieu.tarral@protonmail.com> wrote:
>>
>> Hi Luca,
>>
>>> Hi Mathieu,
>>>
>>> You are missing wget in your packages.
>> Indeed, installing wget solved the issue and I was able to generate
>> a debian package.
>>
>> Still, we have a build system that silently depends on gawk and wget, and there is no check in the configure script to ensure these tools are installed.
>>
>> And the errors in the build system are quite obscure, it's hard to understand that you were missing gawk or wget in the first place.
>>
>> What do you think about this ?
> Hi Mathieu,
>
> I’ve CC the x86 maintainer, probably they know better the reasons.

These are two different problems.

The configure script does check for WGET (or more generally FETCHER) and
will object if something is not present.  This is only relevant for
tools/ which you should have been forced to run configure for anyway, so
I'm really not sure what went on there.

For valid-addrs vs all-addrs, that's come up on xen-devel before.  I
think the general consensus is that we don't want to silently depend on
gawk.

(We're trying some new project management tools.) Can you try opening a
bug here: https://gitlab.com/xen-project/xen/-/issues about the
check-endbr.sh issue?

This ought to be a 4.17 release blocker seeing as its a regression from
4.16.  (CC'ing Henry as release manager.)

~Andrew

Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs

[Bertrand Marquis]

Hi Andy,

> On 14 Jul 2022, at 11:33, Andrew Cooper <Andrew.Cooper3@citrix.com> wrote:
> 
> On 14/07/2022 11:12, Luca Fancellu wrote:
>> + CC x86 maintainers
>> 
>>> On 14 Jul 2022, at 10:40, Mathieu Tarral <mathieu.tarral@protonmail.com> wrote:
>>> 
>>> Hi Luca,
>>> 
>>>> Hi Mathieu,
>>>> 
>>>> You are missing wget in your packages.
>>> Indeed, installing wget solved the issue and I was able to generate
>>> a debian package.
>>> 
>>> Still, we have a build system that silently depends on gawk and wget, and there is no check in the configure script to ensure these tools are installed.
>>> 
>>> And the errors in the build system are quite obscure, it's hard to understand that you were missing gawk or wget in the first place.
>>> 
>>> What do you think about this ?
>> Hi Mathieu,
>> 
>> I’ve CC the x86 maintainer, probably they know better the reasons.
> 
> These are two different problems.
> 
> The configure script does check for WGET (or more generally FETCHER) and
> will object if something is not present.  This is only relevant for
> tools/ which you should have been forced to run configure for anyway, so
> I'm really not sure what went on there.
> 
> For valid-addrs vs all-addrs, that's come up on xen-devel before.  I
> think the general consensus is that we don't want to silently depend on
> gawk.
> 
> (We're trying some new project management tools.) Can you try opening a
> bug here: https://gitlab.com/xen-project/xen/-/issues about the
> check-endbr.sh issue?

I will do that for you Luca as you can only do it if you are a project member right now.

> 
> This ought to be a 4.17 release blocker seeing as its a regression from
> 4.16.  (CC'ing Henry as release manager.)

Ack

Bertrand

> 
> ~Andrew

Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs

[Jan Beulich]

On 14.07.2022 12:33, Andrew Cooper wrote:
> On 14/07/2022 11:12, Luca Fancellu wrote:
>> + CC x86 maintainers
>>
>>> On 14 Jul 2022, at 10:40, Mathieu Tarral <mathieu.tarral@protonmail.com> wrote:
>>>
>>> Hi Luca,
>>>
>>>> Hi Mathieu,
>>>>
>>>> You are missing wget in your packages.
>>> Indeed, installing wget solved the issue and I was able to generate
>>> a debian package.
>>>
>>> Still, we have a build system that silently depends on gawk and wget, and there is no check in the configure script to ensure these tools are installed.
>>>
>>> And the errors in the build system are quite obscure, it's hard to understand that you were missing gawk or wget in the first place.
>>>
>>> What do you think about this ?
>> Hi Mathieu,
>>
>> I’ve CC the x86 maintainer, probably they know better the reasons.
> 
> These are two different problems.
> 
> The configure script does check for WGET (or more generally FETCHER) and
> will object if something is not present.  This is only relevant for
> tools/ which you should have been forced to run configure for anyway, so
> I'm really not sure what went on there.
> 
> For valid-addrs vs all-addrs, that's come up on xen-devel before.  I
> think the general consensus is that we don't want to silently depend on
> gawk.
> 
> (We're trying some new project management tools.) Can you try opening a
> bug here: https://gitlab.com/xen-project/xen/-/issues about the
> check-endbr.sh issue?
> 
> This ought to be a 4.17 release blocker seeing as its a regression from
> 4.16.  (CC'ing Henry as release manager.)

Except that 4.16 and older then already have regressed as well, due to
the backports they've received.

Jan

Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs

[Bertrand Marquis]

> On 14 Jul 2022, at 11:33, Andrew Cooper <Andrew.Cooper3@citrix.com> wrote:
> 
> On 14/07/2022 11:12, Luca Fancellu wrote:
>> + CC x86 maintainers
>> 
>>> On 14 Jul 2022, at 10:40, Mathieu Tarral <mathieu.tarral@protonmail.com> wrote:
>>> 
>>> Hi Luca,
>>> 
>>>> Hi Mathieu,
>>>> 
>>>> You are missing wget in your packages.
>>> Indeed, installing wget solved the issue and I was able to generate
>>> a debian package.
>>> 
>>> Still, we have a build system that silently depends on gawk and wget, and there is no check in the configure script to ensure these tools are installed.
>>> 
>>> And the errors in the build system are quite obscure, it's hard to understand that you were missing gawk or wget in the first place.
>>> 
>>> What do you think about this ?
>> Hi Mathieu,
>> 
>> I’ve CC the x86 maintainer, probably they know better the reasons.
> 
> These are two different problems.
> 
> The configure script does check for WGET (or more generally FETCHER) and
> will object if something is not present.  This is only relevant for
> tools/ which you should have been forced to run configure for anyway, so
> I'm really not sure what went on there.
> 
> For valid-addrs vs all-addrs, that's come up on xen-devel before.  I
> think the general consensus is that we don't want to silently depend on
> gawk.
> 
> (We're trying some new project management tools.) Can you try opening a
> bug here: https://gitlab.com/xen-project/xen/-/issues about the
> check-endbr.sh issue?

https://gitlab.com/xen-project/xen/-/issues/26

Please complete if needed.

@marc: We have a first example of something to be used as a potential release
blocker. Also the template is quite extensive and hard to fill, we might want to simplify it.

Cheers
Bertrand 

> 
> This ought to be a 4.17 release blocker seeing as its a regression from
> 4.16.  (CC'ing Henry as release manager.)
> 
> ~Andrew

Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs

[Andrew Cooper]

On 14/07/2022 11:39, Jan Beulich wrote:
> On 14.07.2022 12:33, Andrew Cooper wrote:
>> On 14/07/2022 11:12, Luca Fancellu wrote:
>>> + CC x86 maintainers
>>>
>>>> On 14 Jul 2022, at 10:40, Mathieu Tarral <mathieu.tarral@protonmail.com> wrote:
>>>>
>>>> Hi Luca,
>>>>
>>>>> Hi Mathieu,
>>>>>
>>>>> You are missing wget in your packages.
>>>> Indeed, installing wget solved the issue and I was able to generate
>>>> a debian package.
>>>>
>>>> Still, we have a build system that silently depends on gawk and wget, and there is no check in the configure script to ensure these tools are installed.
>>>>
>>>> And the errors in the build system are quite obscure, it's hard to understand that you were missing gawk or wget in the first place.
>>>>
>>>> What do you think about this ?
>>> Hi Mathieu,
>>>
>>> I’ve CC the x86 maintainer, probably they know better the reasons.
>> These are two different problems.
>>
>> The configure script does check for WGET (or more generally FETCHER) and
>> will object if something is not present.  This is only relevant for
>> tools/ which you should have been forced to run configure for anyway, so
>> I'm really not sure what went on there.
>>
>> For valid-addrs vs all-addrs, that's come up on xen-devel before.  I
>> think the general consensus is that we don't want to silently depend on
>> gawk.
>>
>> (We're trying some new project management tools.) Can you try opening a
>> bug here: https://gitlab.com/xen-project/xen/-/issues about the
>> check-endbr.sh issue?
>>
>> This ought to be a 4.17 release blocker seeing as its a regression from
>> 4.16.  (CC'ing Henry as release manager.)
> Except that 4.16 and older then already have regressed as well, due to
> the backports they've received.

Luckily not.

Remember that we decided to only backport the less invasive parts of
CET-IBT for the security fix, which is "endbr64 on all functions".

When every function is open to (ab)use, there's no point searching for
misaligned ones too.

~Andrew

Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs

[Mathieu Tarral]

> > > (We're trying some new project management tools.) Can you try opening a
> > > bug here: https://gitlab.com/xen-project/xen/-/issues about the
> > > check-endbr.sh issue?

I'm getting a Gitlab 404 page when trying to access this link.
Are there access restrictions in place ?

And same for:
https://gitlab.com/xen-project/xen/-/issues/26

I see the fix is already on its way !
Thank you for the great support.

Mathieu

Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs

[Bertrand Marquis]

Hi Matthieu,

> On 15 Jul 2022, at 09:53, Mathieu Tarral <mathieu.tarral@protonmail.com> wrote:
> 
>>>> (We're trying some new project management tools.) Can you try opening a
>>>> bug here: https://gitlab.com/xen-project/xen/-/issues about the
>>>> check-endbr.sh issue?
> 
> I'm getting a Gitlab 404 page when trying to access this link.
> Are there access restrictions in place ?
> 
> And same for:
> https://gitlab.com/xen-project/xen/-/issues/26

Yes there are at the moment.
@marc: is there a way to let everybody read the tickets ?

Cheers
Bertrand

> 
> I see the fix is already on its way !
> Thank you for the great support.
> 
> Mathieu
>