All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Martin Weiser <martin.weiser@allegro-packets.com>
Cc: "Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
	"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Ferruh Yigit" <ferruh.yigit@intel.com>
Subject: Re: Mellanox ConnectX-5 crashes and mbuf leak
Date: Sat, 7 Oct 2017 22:19:14 +0000	[thread overview]
Message-ID: <FFCEA33F-02F0-4056-99B1-A8CA004BEE51@mellanox.com> (raw)
In-Reply-To: <374F8C13-CFB0-42FD-8993-BF7F0401F891@mellanox.com>

> On Oct 6, 2017, at 3:30 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
> 
> Hi, Martin
> 
> Even though I had done quite serious tests before sending out the patch,
> I figured out deadlock could happen if the Rx queue size is smaller. It is 128
> by default in testpmd while I usually use 256.
> 
> I've fixed the bug and submitted a new patch [1], which actually reverts the
> previous patch. So, you can apply the attached with disregarding the old one.
> 
> And I have also done extensive tests for this new patch but please let me know
> your test results.
> 
> [1]
> "net/mlx5: fix deadlock due to buffered slots in Rx SW ring"
> at http://dpdk.org/dev/patchwork/patch/29847

Hi Martin

I've submitted v2 of the patch [1]. I just replaced vector insns with regular
statements.  This is just for ease of maintenance because I'm about to add
vectorized PMD for ARM NEON.  In terms of functionality and performance it is
identical.

Please proceed your testing with this and let me know the result.

[1]
[dpdk-dev,v2] net/mlx5: fix deadlock due to buffered slots in Rx SW ring
, which is at http://dpdk.org/dev/patchwork/patch/29879/

Thanks,
Yongseok

  reply	other threads:[~2017-10-07 22:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26  9:23 Mellanox ConnectX-5 crashes and mbuf leak Martin Weiser
2017-09-26 10:32 ` Olga Shern
2017-10-05 21:46 ` Yongseok Koh
2017-10-06 14:10   ` Martin Weiser
2017-10-06 22:31     ` Yongseok Koh
2017-10-07 22:19       ` Yongseok Koh [this message]
2017-10-10  8:10         ` Martin Weiser
2017-10-10 14:28           ` Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FFCEA33F-02F0-4056-99B1-A8CA004BEE51@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=martin.weiser@allegro-packets.com \
    --cc=nelio.laranjeiro@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.