* [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-01-12 19:34 ` Frank Li
0 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-01-12 19:34 UTC (permalink / raw)
To: Minghuan Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list
Cc: imx
From: Xiaowei Bao <xiaowei.bao@nxp.com>
Add PCIe EP mode support for ls1028a.
Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp>
Acked-by: Roy Zang <Roy.Zang@nxp.com>
---
Added
Signed-off-by: Frank Li <Frank.Li@nxp>
Acked-by: Roy Zang <Roy.Zang@nxp.com>
All other patches were already accepte by maintainer in
https://lore.kernel.org/lkml/20211112223457.10599-1-leoyang.li@nxp.com/
But missed this one.
Re-post.
drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index ad99707b3b99..ed5cfc9408d9 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -112,6 +112,7 @@ static const struct ls_pcie_ep_drvdata lx2_ep_drvdata = {
static const struct of_device_id ls_pcie_ep_of_match[] = {
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
{ .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
{ },
--
2.34.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-01-12 19:34 ` Frank Li
0 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-01-12 19:34 UTC (permalink / raw)
To: Minghuan Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list
Cc: imx
From: Xiaowei Bao <xiaowei.bao@nxp.com>
Add PCIe EP mode support for ls1028a.
Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp>
Acked-by: Roy Zang <Roy.Zang@nxp.com>
---
Added
Signed-off-by: Frank Li <Frank.Li@nxp>
Acked-by: Roy Zang <Roy.Zang@nxp.com>
All other patches were already accepte by maintainer in
https://lore.kernel.org/lkml/20211112223457.10599-1-leoyang.li@nxp.com/
But missed this one.
Re-post.
drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index ad99707b3b99..ed5cfc9408d9 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -112,6 +112,7 @@ static const struct ls_pcie_ep_drvdata lx2_ep_drvdata = {
static const struct of_device_id ls_pcie_ep_of_match[] = {
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
{ .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
{ },
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
2023-01-12 19:34 ` Frank Li
@ 2023-02-02 17:41 ` Frank Li
-1 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-02-02 17:41 UTC (permalink / raw)
To: Frank Li, M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list
Cc: imx
> Subject: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for
> ls1028a
>
> Caution: EXT Email
>
> From: Xiaowei Bao <xiaowei.bao@nxp.com>
>
> Add PCIe EP mode support for ls1028a.
>
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp>
> Acked-by: Roy Zang <Roy.Zang@nxp.com>
>
[Frank Li] ping
> ---
>
> Added
> Signed-off-by: Frank Li <Frank.Li@nxp>
> Acked-by: Roy Zang <Roy.Zang@nxp.com>
>
>
> All other patches were already accepte by maintainer in
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k
> ernel.org%2Flkml%2F20211112223457.10599-1-
> leoyang.li%40nxp.com%2F&data=05%7C01%7Cfrank.li%40nxp.com%7C29d1
> 5c05d59346e552be08daf4d573e5%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0%7C638091494850726163%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
> iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
> 00%7C%7C%7C&sdata=0wnHTyuX%2FyLAiioKNvlFbBM83nVyF%2FCdhqsEmV
> f2sI4%3D&reserved=0
>
> But missed this one.
>
> Re-post.
>
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index ad99707b3b99..ed5cfc9408d9 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -112,6 +112,7 @@ static const struct ls_pcie_ep_drvdata
> lx2_ep_drvdata = {
> static const struct of_device_id ls_pcie_ep_of_match[] = {
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
> { .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
> { },
> --
> 2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-02 17:41 ` Frank Li
0 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-02-02 17:41 UTC (permalink / raw)
To: Frank Li, M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list
Cc: imx
> Subject: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for
> ls1028a
>
> Caution: EXT Email
>
> From: Xiaowei Bao <xiaowei.bao@nxp.com>
>
> Add PCIe EP mode support for ls1028a.
>
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp>
> Acked-by: Roy Zang <Roy.Zang@nxp.com>
>
[Frank Li] ping
> ---
>
> Added
> Signed-off-by: Frank Li <Frank.Li@nxp>
> Acked-by: Roy Zang <Roy.Zang@nxp.com>
>
>
> All other patches were already accepte by maintainer in
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k
> ernel.org%2Flkml%2F20211112223457.10599-1-
> leoyang.li%40nxp.com%2F&data=05%7C01%7Cfrank.li%40nxp.com%7C29d1
> 5c05d59346e552be08daf4d573e5%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0%7C638091494850726163%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
> iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
> 00%7C%7C%7C&sdata=0wnHTyuX%2FyLAiioKNvlFbBM83nVyF%2FCdhqsEmV
> f2sI4%3D&reserved=0
>
> But missed this one.
>
> Re-post.
>
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index ad99707b3b99..ed5cfc9408d9 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -112,6 +112,7 @@ static const struct ls_pcie_ep_drvdata
> lx2_ep_drvdata = {
> static const struct of_device_id ls_pcie_ep_of_match[] = {
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
> { .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
> { },
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
2023-02-02 17:41 ` Frank Li
@ 2023-02-03 5:17 ` ALOK TIWARI
-1 siblings, 0 replies; 17+ messages in thread
From: ALOK TIWARI @ 2023-02-03 5:17 UTC (permalink / raw)
To: Frank Li, M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list
Cc: imx
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
can it be like this for better readability. ?
Thanks,
Alok
On 2/2/2023 11:11 PM, Frank Li wrote:
>> Subject: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for
>> ls1028a
>>
>> Caution: EXT Email
>>
>> From: Xiaowei Bao <xiaowei.bao@nxp.com>
>>
>> Add PCIe EP mode support for ls1028a.
>>
>> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
>> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> Signed-off-by: Frank Li <Frank.Li@nxp>
>> Acked-by: Roy Zang <Roy.Zang@nxp.com>
>>
> [Frank Li] ping
>
>> ---
>>
>> Added
>> Signed-off-by: Frank Li <Frank.Li@nxp>
>> Acked-by: Roy Zang <Roy.Zang@nxp.com>
>>
>>
>> All other patches were already accepte by maintainer in
>> https://urldefense.com/v3/__https://eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Flore.k__;JSUl!!ACWV5N9M2RV99hQ!PIKq0-lb3ccjBcAZNFo48kfWvbGPlh7_Wiws1olaNdTthUzhcGFrpLbw3vOMDaeops5LkajDO_y_vGPyuhE$
>> ernel.org%2Flkml%2F20211112223457.10599-1-
>> leoyang.li%40nxp.com%2F&data=05%7C01%7Cfrank.li%40nxp.com%7C29d1
>> 5c05d59346e552be08daf4d573e5%7C686ea1d3bc2b4c6fa92cd99c5c301635%
>> 7C0%7C0%7C638091494850726163%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
>> iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
>> 00%7C%7C%7C&sdata=0wnHTyuX%2FyLAiioKNvlFbBM83nVyF%2FCdhqsEmV
>> f2sI4%3D&reserved=0
>>
>> But missed this one.
>>
>> Re-post.
>>
>> drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
>> b/drivers/pci/controller/dwc/pci-layerscape-ep.c
>> index ad99707b3b99..ed5cfc9408d9 100644
>> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
>> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
>> @@ -112,6 +112,7 @@ static const struct ls_pcie_ep_drvdata
>> lx2_ep_drvdata = {
>> static const struct of_device_id ls_pcie_ep_of_match[] = {
>> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
>> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
>> { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
>> { .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
>> { },
>> --
>> 2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-03 5:17 ` ALOK TIWARI
0 siblings, 0 replies; 17+ messages in thread
From: ALOK TIWARI @ 2023-02-03 5:17 UTC (permalink / raw)
To: Frank Li, M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list
Cc: imx
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
can it be like this for better readability. ?
Thanks,
Alok
On 2/2/2023 11:11 PM, Frank Li wrote:
>> Subject: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for
>> ls1028a
>>
>> Caution: EXT Email
>>
>> From: Xiaowei Bao <xiaowei.bao@nxp.com>
>>
>> Add PCIe EP mode support for ls1028a.
>>
>> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
>> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> Signed-off-by: Frank Li <Frank.Li@nxp>
>> Acked-by: Roy Zang <Roy.Zang@nxp.com>
>>
> [Frank Li] ping
>
>> ---
>>
>> Added
>> Signed-off-by: Frank Li <Frank.Li@nxp>
>> Acked-by: Roy Zang <Roy.Zang@nxp.com>
>>
>>
>> All other patches were already accepte by maintainer in
>> https://urldefense.com/v3/__https://eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Flore.k__;JSUl!!ACWV5N9M2RV99hQ!PIKq0-lb3ccjBcAZNFo48kfWvbGPlh7_Wiws1olaNdTthUzhcGFrpLbw3vOMDaeops5LkajDO_y_vGPyuhE$
>> ernel.org%2Flkml%2F20211112223457.10599-1-
>> leoyang.li%40nxp.com%2F&data=05%7C01%7Cfrank.li%40nxp.com%7C29d1
>> 5c05d59346e552be08daf4d573e5%7C686ea1d3bc2b4c6fa92cd99c5c301635%
>> 7C0%7C0%7C638091494850726163%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
>> iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
>> 00%7C%7C%7C&sdata=0wnHTyuX%2FyLAiioKNvlFbBM83nVyF%2FCdhqsEmV
>> f2sI4%3D&reserved=0
>>
>> But missed this one.
>>
>> Re-post.
>>
>> drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
>> b/drivers/pci/controller/dwc/pci-layerscape-ep.c
>> index ad99707b3b99..ed5cfc9408d9 100644
>> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
>> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
>> @@ -112,6 +112,7 @@ static const struct ls_pcie_ep_drvdata
>> lx2_ep_drvdata = {
>> static const struct of_device_id ls_pcie_ep_of_match[] = {
>> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
>> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
>> { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
>> { .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
>> { },
>> --
>> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
2023-02-03 5:17 ` ALOK TIWARI
@ 2023-02-07 16:20 ` Frank Li
-1 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-02-07 16:20 UTC (permalink / raw)
To: ALOK TIWARI, M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list
Cc: imx
> Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
> mode support for ls1028a
>
> Caution: EXT Email
>
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>
> can it be like this for better readability. ?
It is just chip name and follow name conversion, which already upstreamed and documented.
Why do you think it not is good readability?
Frank Li
>
> Thanks,
> Alok
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-07 16:20 ` Frank Li
0 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-02-07 16:20 UTC (permalink / raw)
To: ALOK TIWARI, M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list
Cc: imx
> Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
> mode support for ls1028a
>
> Caution: EXT Email
>
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>
> can it be like this for better readability. ?
It is just chip name and follow name conversion, which already upstreamed and documented.
Why do you think it not is good readability?
Frank Li
>
> Thanks,
> Alok
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
2023-02-07 16:20 ` Frank Li
(?)
@ 2023-02-08 22:23 ` Bjorn Helgaas
-1 siblings, 0 replies; 17+ messages in thread
From: Bjorn Helgaas @ 2023-02-08 22:23 UTC (permalink / raw)
To: Frank Li
Cc: ALOK TIWARI, M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list,
imx
On Tue, Feb 07, 2023 at 04:20:21PM +0000, Frank Li wrote:
> > Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
> > mode support for ls1028a
> >
> > { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> > { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
> >
> > can it be like this for better readability. ?
>
> It is just chip name and follow name conversion, which already
> upstreamed and documented.
>
> Why do you think it not is good readability?
I thought maybe ALOK's point was to sort the list, which does make a
lot of sense. But if you want to sort by the .data member, I would
think you would make .compatible a secondary sort key, which means
ls1028a would come before ls1046a, so you would end up with this
instead:
static const struct of_device_id ls_pcie_ep_of_match[] = {
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
{ .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
{ .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
{ },
};
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-08 22:23 ` Bjorn Helgaas
0 siblings, 0 replies; 17+ messages in thread
From: Bjorn Helgaas @ 2023-02-08 22:23 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, imx, Roy Zang, ALOK TIWARI, Lorenzo Pieralisi,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list,
M.H. Lian, moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
Krzysztof Wilczyński, Bjorn Helgaas, Mingkai Hu
On Tue, Feb 07, 2023 at 04:20:21PM +0000, Frank Li wrote:
> > Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
> > mode support for ls1028a
> >
> > { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> > { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
> >
> > can it be like this for better readability. ?
>
> It is just chip name and follow name conversion, which already
> upstreamed and documented.
>
> Why do you think it not is good readability?
I thought maybe ALOK's point was to sort the list, which does make a
lot of sense. But if you want to sort by the .data member, I would
think you would make .compatible a secondary sort key, which means
ls1028a would come before ls1046a, so you would end up with this
instead:
static const struct of_device_id ls_pcie_ep_of_match[] = {
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
{ .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
{ .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
{ },
};
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-08 22:23 ` Bjorn Helgaas
0 siblings, 0 replies; 17+ messages in thread
From: Bjorn Helgaas @ 2023-02-08 22:23 UTC (permalink / raw)
To: Frank Li
Cc: ALOK TIWARI, M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list,
imx
On Tue, Feb 07, 2023 at 04:20:21PM +0000, Frank Li wrote:
> > Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
> > mode support for ls1028a
> >
> > { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> > { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
> >
> > can it be like this for better readability. ?
>
> It is just chip name and follow name conversion, which already
> upstreamed and documented.
>
> Why do you think it not is good readability?
I thought maybe ALOK's point was to sort the list, which does make a
lot of sense. But if you want to sort by the .data member, I would
think you would make .compatible a secondary sort key, which means
ls1028a would come before ls1046a, so you would end up with this
instead:
static const struct of_device_id ls_pcie_ep_of_match[] = {
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
{ .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
{ .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
{ },
};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
2023-02-08 22:23 ` Bjorn Helgaas
(?)
@ 2023-02-09 10:37 ` ALOK TIWARI
-1 siblings, 0 replies; 17+ messages in thread
From: ALOK TIWARI @ 2023-02-09 10:37 UTC (permalink / raw)
To: Bjorn Helgaas, Frank Li
Cc: M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list,
imx
yes, it is more about sort the list using .data and .compatible. key
much better if it we keep this as suggested by Frank,
static const struct of_device_id ls_pcie_ep_of_match[] = {
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
Thanks,
Alok
On 2/9/2023 3:53 AM, Bjorn Helgaas wrote:
> On Tue, Feb 07, 2023 at 04:20:21PM +0000, Frank Li wrote:
>>> Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
>>> mode support for ls1028a
>>>
>>> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
>>> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
>>> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>>>
>>> can it be like this for better readability. ?
>> It is just chip name and follow name conversion, which already
>> upstreamed and documented.
>>
>> Why do you think it not is good readability?
> I thought maybe ALOK's point was to sort the list, which does make a
> lot of sense. But if you want to sort by the .data member, I would
> think you would make .compatible a secondary sort key, which means
> ls1028a would come before ls1046a, so you would end up with this
> instead:
>
> static const struct of_device_id ls_pcie_ep_of_match[] = {
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
> { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
> { .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
> { },
> };
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-09 10:37 ` ALOK TIWARI
0 siblings, 0 replies; 17+ messages in thread
From: ALOK TIWARI @ 2023-02-09 10:37 UTC (permalink / raw)
To: Bjorn Helgaas, Frank Li
Cc: M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list,
imx
yes, it is more about sort the list using .data and .compatible. key
much better if it we keep this as suggested by Frank,
static const struct of_device_id ls_pcie_ep_of_match[] = {
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
Thanks,
Alok
On 2/9/2023 3:53 AM, Bjorn Helgaas wrote:
> On Tue, Feb 07, 2023 at 04:20:21PM +0000, Frank Li wrote:
>>> Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
>>> mode support for ls1028a
>>>
>>> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
>>> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
>>> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>>>
>>> can it be like this for better readability. ?
>> It is just chip name and follow name conversion, which already
>> upstreamed and documented.
>>
>> Why do you think it not is good readability?
> I thought maybe ALOK's point was to sort the list, which does make a
> lot of sense. But if you want to sort by the .data member, I would
> think you would make .compatible a secondary sort key, which means
> ls1028a would come before ls1046a, so you would end up with this
> instead:
>
> static const struct of_device_id ls_pcie_ep_of_match[] = {
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
> { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
> { .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
> { },
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-09 10:37 ` ALOK TIWARI
0 siblings, 0 replies; 17+ messages in thread
From: ALOK TIWARI @ 2023-02-09 10:37 UTC (permalink / raw)
To: Bjorn Helgaas, Frank Li
Cc: Krzysztof Wilczyński, imx, Rob Herring,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE, Lorenzo Pieralisi,
open list, M.H. Lian,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, Roy Zang,
Bjorn Helgaas, open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
Mingkai Hu
yes, it is more about sort the list using .data and .compatible. key
much better if it we keep this as suggested by Frank,
static const struct of_device_id ls_pcie_ep_of_match[] = {
+ { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
Thanks,
Alok
On 2/9/2023 3:53 AM, Bjorn Helgaas wrote:
> On Tue, Feb 07, 2023 at 04:20:21PM +0000, Frank Li wrote:
>>> Subject: Re: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
>>> mode support for ls1028a
>>>
>>> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
>>> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
>>> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>>>
>>> can it be like this for better readability. ?
>> It is just chip name and follow name conversion, which already
>> upstreamed and documented.
>>
>> Why do you think it not is good readability?
> I thought maybe ALOK's point was to sort the list, which does make a
> lot of sense. But if you want to sort by the .data member, I would
> think you would make .compatible a secondary sort key, which means
> ls1028a would come before ls1046a, so you would end up with this
> instead:
>
> static const struct of_device_id ls_pcie_ep_of_match[] = {
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
> { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
> { .compatible = "fsl,lx2160ar2-pcie-ep", .data = &lx2_ep_drvdata },
> { },
> };
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
2023-02-09 10:37 ` ALOK TIWARI
(?)
@ 2023-02-09 15:12 ` Frank Li
-1 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-02-09 15:12 UTC (permalink / raw)
To: ALOK TIWARI, Bjorn Helgaas
Cc: M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list,
imx
>
> Caution: EXT Email
>
> yes, it is more about sort the list using .data and .compatible. key
>
> much better if it we keep this as suggested by Frank,
>
> static const struct of_device_id ls_pcie_ep_of_match[] = {
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
Thanks, v3 sent.
Frank Li
>
>
>
> Thanks,
>
> Alok
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-09 15:12 ` Frank Li
0 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-02-09 15:12 UTC (permalink / raw)
To: ALOK TIWARI, Bjorn Helgaas
Cc: Krzysztof Wilczyński, imx, Rob Herring,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE, Lorenzo Pieralisi,
open list, M.H. Lian,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, Roy Zang,
Bjorn Helgaas, open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
Mingkai Hu
>
> Caution: EXT Email
>
> yes, it is more about sort the list using .data and .compatible. key
>
> much better if it we keep this as suggested by Frank,
>
> static const struct of_device_id ls_pcie_ep_of_match[] = {
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
Thanks, v3 sent.
Frank Li
>
>
>
> Thanks,
>
> Alok
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a
@ 2023-02-09 15:12 ` Frank Li
0 siblings, 0 replies; 17+ messages in thread
From: Frank Li @ 2023-02-09 15:12 UTC (permalink / raw)
To: ALOK TIWARI, Bjorn Helgaas
Cc: M.H. Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
open list:PCI DRIVER FOR FREESCALE LAYERSCAPE,
moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE, open list,
imx
>
> Caution: EXT Email
>
> yes, it is more about sort the list using .data and .compatible. key
>
> much better if it we keep this as suggested by Frank,
>
> static const struct of_device_id ls_pcie_ep_of_match[] = {
> + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
> { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
Thanks, v3 sent.
Frank Li
>
>
>
> Thanks,
>
> Alok
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2023-02-09 16:03 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-12 19:34 [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a Frank Li
2023-01-12 19:34 ` Frank Li
2023-02-02 17:41 ` [EXT] " Frank Li
2023-02-02 17:41 ` Frank Li
2023-02-03 5:17 ` [External] : " ALOK TIWARI
2023-02-03 5:17 ` ALOK TIWARI
2023-02-07 16:20 ` Frank Li
2023-02-07 16:20 ` Frank Li
2023-02-08 22:23 ` Bjorn Helgaas
2023-02-08 22:23 ` Bjorn Helgaas
2023-02-08 22:23 ` Bjorn Helgaas
2023-02-09 10:37 ` ALOK TIWARI
2023-02-09 10:37 ` ALOK TIWARI
2023-02-09 10:37 ` ALOK TIWARI
2023-02-09 15:12 ` Frank Li
2023-02-09 15:12 ` Frank Li
2023-02-09 15:12 ` Frank Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.