All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
@ 2020-04-29 10:04 ` fugang.duan
  0 siblings, 0 replies; 10+ messages in thread
From: fugang.duan @ 2020-04-29 10:04 UTC (permalink / raw)
  To: robh+dt, shawnguo, s.hauer
  Cc: kernel, festevam, Anson.Huang, devicetree, fugang.duan,
	aisheng.dong, linux-arm-kernel, linux-kernel

From: Fugang Duan <fugang.duan@nxp.com>

Add "fsl,imx6sx-fec" compatible string for fec node, then
i.MX8MP EVK ethernet function can work now.

Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 9b1616e59d58..b5df957c5063 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -615,7 +615,7 @@
 			};
 
 			fec: ethernet@30be0000 {
-				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
+				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec", "fsl,imx6sx-fec";
 				reg = <0x30be0000 0x10000>;
 				interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
 					     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 1/1] arm64: dts: imx8mp: add "fsl, imx6sx-fec" compatible string
@ 2020-04-29 10:04 ` fugang.duan
  0 siblings, 0 replies; 10+ messages in thread
From: fugang.duan @ 2020-04-29 10:04 UTC (permalink / raw)
  To: robh+dt, shawnguo, s.hauer
  Cc: aisheng.dong, devicetree, fugang.duan, Anson.Huang, linux-kernel,
	kernel, festevam, linux-arm-kernel

From: Fugang Duan <fugang.duan@nxp.com>

Add "fsl,imx6sx-fec" compatible string for fec node, then
i.MX8MP EVK ethernet function can work now.

Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 9b1616e59d58..b5df957c5063 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -615,7 +615,7 @@
 			};
 
 			fec: ethernet@30be0000 {
-				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
+				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec", "fsl,imx6sx-fec";
 				reg = <0x30be0000 0x10000>;
 				interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
 					     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* RE: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
  2020-04-29 10:04 ` [PATCH 1/1] arm64: dts: imx8mp: add "fsl, imx6sx-fec" " fugang.duan
@ 2020-04-29 10:13   ` Aisheng Dong
  -1 siblings, 0 replies; 10+ messages in thread
From: Aisheng Dong @ 2020-04-29 10:13 UTC (permalink / raw)
  To: Andy Duan, robh+dt, shawnguo, s.hauer
  Cc: kernel, festevam, Anson Huang, devicetree, linux-arm-kernel,
	linux-kernel

> From: Andy Duan <fugang.duan@nxp.com>
> Sent: Wednesday, April 29, 2020 6:04 PM
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK ethernet
> function can work now.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>

Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Aisheng

> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
>  			};
> 
>  			fec: ethernet@30be0000 {
> -				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> +				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec",
> "fsl,imx6sx-fec";
>  				reg = <0x30be0000 0x10000>;
>  				interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
@ 2020-04-29 10:13   ` Aisheng Dong
  0 siblings, 0 replies; 10+ messages in thread
From: Aisheng Dong @ 2020-04-29 10:13 UTC (permalink / raw)
  To: Andy Duan, robh+dt, shawnguo, s.hauer
  Cc: devicetree, Anson Huang, linux-kernel, kernel, festevam,
	linux-arm-kernel

> From: Andy Duan <fugang.duan@nxp.com>
> Sent: Wednesday, April 29, 2020 6:04 PM
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK ethernet
> function can work now.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>

Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Aisheng

> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
>  			};
> 
>  			fec: ethernet@30be0000 {
> -				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> +				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec",
> "fsl,imx6sx-fec";
>  				reg = <0x30be0000 0x10000>;
>  				interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
  2020-04-29 10:04 ` [PATCH 1/1] arm64: dts: imx8mp: add "fsl, imx6sx-fec" " fugang.duan
@ 2020-05-13  8:49   ` Shawn Guo
  -1 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2020-05-13  8:49 UTC (permalink / raw)
  To: fugang.duan
  Cc: robh+dt, s.hauer, kernel, festevam, Anson.Huang, devicetree,
	aisheng.dong, linux-arm-kernel, linux-kernel

On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
>  			};
>  
>  			fec: ethernet@30be0000 {
> -				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> +				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec", "fsl,imx6sx-fec";

In this case, "fsl,imx8mq-fec" can be dropped?

Shawn

>  				reg = <0x30be0000 0x10000>;
>  				interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
@ 2020-05-13  8:49   ` Shawn Guo
  0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2020-05-13  8:49 UTC (permalink / raw)
  To: fugang.duan
  Cc: aisheng.dong, devicetree, Anson.Huang, s.hauer, linux-kernel,
	robh+dt, kernel, festevam, linux-arm-kernel

On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
>  			};
>  
>  			fec: ethernet@30be0000 {
> -				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> +				compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec", "fsl,imx6sx-fec";

In this case, "fsl,imx8mq-fec" can be dropped?

Shawn

>  				reg = <0x30be0000 0x10000>;
>  				interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
  2020-05-13  8:49   ` Shawn Guo
@ 2020-05-13  8:58     ` Andy Duan
  -1 siblings, 0 replies; 10+ messages in thread
From: Andy Duan @ 2020-05-13  8:58 UTC (permalink / raw)
  To: Shawn Guo
  Cc: robh+dt, s.hauer, kernel, festevam, Anson Huang, devicetree,
	Aisheng Dong, linux-arm-kernel, linux-kernel

From: Shawn Guo <shawnguo@kernel.org> Sent: Wednesday, May 13, 2020 4:50 PM
> On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK
> > ethernet function can work now.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 9b1616e59d58..b5df957c5063 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -615,7 +615,7 @@
> >                       };
> >
> >                       fec: ethernet@30be0000 {
> > -                             compatible = "fsl,imx8mp-fec",
> "fsl,imx8mq-fec";
> > +                             compatible = "fsl,imx8mp-fec",
> > + "fsl,imx8mq-fec", "fsl,imx6sx-fec";
> 
> In this case, "fsl,imx8mq-fec" can be dropped?
> 
> Shawn
Please don't drop the compatible string, there have little difference for 8mq
that support eee feature, the feature will be upstreamed.

Thanks.
> 
> >                               reg = <0x30be0000 0x10000>;
> >                               interrupts = <GIC_SPI 118
> IRQ_TYPE_LEVEL_HIGH>,
> >                                            <GIC_SPI 119
> > IRQ_TYPE_LEVEL_HIGH>,
> > --
> > 2.17.1
> >

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
@ 2020-05-13  8:58     ` Andy Duan
  0 siblings, 0 replies; 10+ messages in thread
From: Andy Duan @ 2020-05-13  8:58 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Aisheng Dong, devicetree, Anson Huang, s.hauer, linux-kernel,
	robh+dt, kernel, festevam, linux-arm-kernel

From: Shawn Guo <shawnguo@kernel.org> Sent: Wednesday, May 13, 2020 4:50 PM
> On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK
> > ethernet function can work now.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 9b1616e59d58..b5df957c5063 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -615,7 +615,7 @@
> >                       };
> >
> >                       fec: ethernet@30be0000 {
> > -                             compatible = "fsl,imx8mp-fec",
> "fsl,imx8mq-fec";
> > +                             compatible = "fsl,imx8mp-fec",
> > + "fsl,imx8mq-fec", "fsl,imx6sx-fec";
> 
> In this case, "fsl,imx8mq-fec" can be dropped?
> 
> Shawn
Please don't drop the compatible string, there have little difference for 8mq
that support eee feature, the feature will be upstreamed.

Thanks.
> 
> >                               reg = <0x30be0000 0x10000>;
> >                               interrupts = <GIC_SPI 118
> IRQ_TYPE_LEVEL_HIGH>,
> >                                            <GIC_SPI 119
> > IRQ_TYPE_LEVEL_HIGH>,
> > --
> > 2.17.1
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
  2020-04-29 10:04 ` [PATCH 1/1] arm64: dts: imx8mp: add "fsl, imx6sx-fec" " fugang.duan
@ 2020-05-17 14:14   ` Shawn Guo
  -1 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2020-05-17 14:14 UTC (permalink / raw)
  To: fugang.duan
  Cc: robh+dt, s.hauer, kernel, festevam, Anson.Huang, devicetree,
	aisheng.dong, linux-arm-kernel, linux-kernel

On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
@ 2020-05-17 14:14   ` Shawn Guo
  0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2020-05-17 14:14 UTC (permalink / raw)
  To: fugang.duan
  Cc: aisheng.dong, devicetree, Anson.Huang, s.hauer, linux-kernel,
	robh+dt, kernel, festevam, linux-arm-kernel

On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-05-17 14:14 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 10:04 [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string fugang.duan
2020-04-29 10:04 ` [PATCH 1/1] arm64: dts: imx8mp: add "fsl, imx6sx-fec" " fugang.duan
2020-04-29 10:13 ` [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" " Aisheng Dong
2020-04-29 10:13   ` Aisheng Dong
2020-05-13  8:49 ` Shawn Guo
2020-05-13  8:49   ` Shawn Guo
2020-05-13  8:58   ` [EXT] " Andy Duan
2020-05-13  8:58     ` Andy Duan
2020-05-17 14:14 ` Shawn Guo
2020-05-17 14:14   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.