All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Karlman <jonas@kwiboo.se>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org" 
	<linux-rockchip@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 00/12] media: hantro: H264 fixes and improvements
Date: Mon, 2 Sep 2019 16:28:57 +0000	[thread overview]
Message-ID: <HE1PR06MB40118B3C30939861DD91113CACBE0@HE1PR06MB4011.eurprd06.prod.outlook.com> (raw)
In-Reply-To: <f204a408f980f3ae0cfb859acdc765cdc1c0ff01.camel@collabora.com>

On 2019-09-02 15:02, Ezequiel Garcia wrote:
> Hi Jonas,
>
> Thanks for the series, I'll be reviewing this shortly.
>
> On Sun, 2019-09-01 at 12:42 +0000, Jonas Karlman wrote:
>> This series contains fixes and improvements for the hantro H264 decoder.
>>
>> Patch 1-6 fixes issues and limitations observed when preparing support
>> for field encoded content.
>>
>> Patch 7 introduce new DPB entry flags that is used to signal how a reference
>> frame is referenced. This information is needed to correctly build a
>> reference list for field encoded content.
>>
>> Patch 8 adds bits to handle field encoded content, this is a rough patch
>> and should be reworked with proper code style and formatting.
>> Please get back with feedback on how to improve this.
>>
>> The following samples from [1] are now playable with patch 1-8
>> - H264_1080i-25-interlace_Kaesescheibchen.mkv
>> - H264_10_1080i_50_AC3-Astra19.2_ProSieben_HD.ts
>> - big_buck_bunny_1080p_H264_AAC_25fps_7200K.mp4
>> - h264_tivo_sample.ts
>>
>> The rest of the patches refactors G1 H264 code to more closely match
>> the code generated by my rockchip-vpu-regtool at [2] and then adds
>> support for H264 decoding on RK3399/RK3328 using the VPU2 block.
>> This code is early work and needs proper code style and formatting,
>> I just wanted to share the early work and get some initial feedback.
>>
>> This series has been tested using ffmpeg v4l2 request hwaccel at [3] [4]
>>
> What boards have you tested this on?

Main testing has been done on a Tinker Board S (RK3288) and a Rock64 (RK3328) device.
Very limited testing on a Rock Pi 4 (RK3399) using earlier version of the patchset,
I will redo some RK3399 testing to make sure it is not only VPU2 on RK3328 that works.

Regards,
Jonas

>
> Thanks,
> Ezequiel
>


  reply	other threads:[~2019-09-02 16:29 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-01 12:42 [PATCH RFC 00/12] media: hantro: H264 fixes and improvements Jonas Karlman
2019-09-01 12:42 ` Jonas Karlman
2019-09-01 12:45 ` [PATCH 01/12] media: hantro: Fix H264 max frmsize supported on RK3288 Jonas Karlman
2019-09-01 12:45   ` Jonas Karlman
2019-09-04 13:07   ` Ezequiel Garcia
2019-09-04 13:07     ` Ezequiel Garcia
2019-09-09 19:25     ` Jonas Karlman
2019-09-09 19:25       ` Jonas Karlman
     [not found] ` <20190901124531.23645-1-jonas@kwiboo.se>
2019-09-01 12:45   ` [PATCH 02/12] media: hantro: Do not reorder H264 scaling list Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-02 14:00     ` Philipp Zabel
2019-09-02 14:00       ` Philipp Zabel
2019-09-02 16:18       ` Jonas Karlman
2019-09-02 16:18         ` Jonas Karlman
2019-09-03  7:54         ` Jonas Karlman
2019-09-03  7:54           ` Jonas Karlman
2019-09-03 12:53           ` Philipp Zabel
2019-09-03 12:53             ` Philipp Zabel
2019-09-03  9:56         ` Philipp Zabel
2019-09-03  9:56           ` Philipp Zabel
2019-09-10 10:14         ` Ezequiel Garcia
2019-09-10 10:14           ` Ezequiel Garcia
2019-09-01 12:45   ` [PATCH 03/12] media: hantro: Fix H264 motion vector buffer offset Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-03 10:58     ` Philipp Zabel
2019-09-03 10:58       ` Philipp Zabel
2019-09-03 20:13       ` Jonas Karlman
2019-09-03 20:13         ` Jonas Karlman
2019-09-10 10:18     ` Ezequiel Garcia
2019-09-10 10:18       ` Ezequiel Garcia
2019-09-10 11:34     ` Ezequiel Garcia
2019-09-10 11:34       ` Ezequiel Garcia
2019-09-01 12:45   ` [PATCH 05/12] media: hantro: Remove now unused H264 pic_size Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-01 12:45   ` [PATCH 04/12] media: hantro: Reduce H264 extra space for motion vectors Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-01 12:45   ` [PATCH 06/12] media: hantro: Set H264 FIELDPIC_FLAG_E flag correctly Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-01 12:45   ` [RFC 08/12] media: hantro: Fix H264 decoding of field encoded content Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-03 13:21     ` Philipp Zabel
2019-09-03 13:21       ` Philipp Zabel
2019-09-03 14:02       ` Jonas Karlman
2019-09-03 14:02         ` Jonas Karlman
2019-09-03 15:01         ` Philipp Zabel
2019-09-03 15:01           ` Philipp Zabel
2019-09-03 19:47           ` Jonas Karlman
2019-09-03 19:47             ` Jonas Karlman
2019-09-01 12:45   ` [RFC 07/12] media: uapi: h264: Add DPB entry field reference flags Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2020-07-10  4:21     ` Ezequiel Garcia
2020-07-10  4:21       ` Ezequiel Garcia
2020-07-10  8:13       ` Boris Brezillon
2020-07-10  8:13         ` Boris Brezillon
2020-07-10  8:48         ` Jonas Karlman
2020-07-10  8:48           ` Jonas Karlman
2020-07-10 12:18           ` Ezequiel Garcia
2020-07-10 12:18             ` Ezequiel Garcia
2020-07-10 11:50         ` Ezequiel Garcia
2020-07-10 11:50           ` Ezequiel Garcia
2020-07-10 12:05           ` Boris Brezillon
2020-07-10 12:05             ` Boris Brezillon
2020-07-10 12:25             ` Ezequiel Garcia
2020-07-10 12:25               ` Ezequiel Garcia
2020-07-10 21:49               ` Nicolas Dufresne
2020-07-10 21:49                 ` Nicolas Dufresne
2020-07-11 10:21                 ` Jonas Karlman
2020-07-11 10:21                   ` Jonas Karlman
2020-07-11 18:36                   ` Nicolas Dufresne
2020-07-11 18:36                     ` Nicolas Dufresne
2020-07-12 22:59                   ` Ezequiel Garcia
2020-07-12 22:59                     ` Ezequiel Garcia
2020-07-14 16:04                     ` Nicolas Dufresne
2020-07-14 16:04                       ` Nicolas Dufresne
2019-09-01 12:45   ` [RFC 09/12] media: hantro: Refactor G1 H264 code Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-01 12:45   ` [RFC 10/12] media: hantro: Add support for H264 decoding on RK3399 Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-02 11:46     ` Hans Verkuil
2019-09-02 11:46       ` Hans Verkuil
2019-09-02 15:25       ` Jonas Karlman
2019-09-02 15:25         ` Jonas Karlman
2019-09-01 12:45   ` [RFC 11/12] media: hantro: Enable " Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-01 12:45   ` [RFC 12/12] media: hantro: Enable H264 decoding on RK3328 Jonas Karlman
2019-09-01 12:45     ` Jonas Karlman
2019-09-02 13:02 ` [PATCH RFC 00/12] media: hantro: H264 fixes and improvements Ezequiel Garcia
2019-09-02 13:02   ` Ezequiel Garcia
2019-09-02 16:28   ` Jonas Karlman [this message]
2019-09-02 16:28     ` Jonas Karlman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HE1PR06MB40118B3C30939861DD91113CACBE0@HE1PR06MB4011.eurprd06.prod.outlook.com \
    --to=jonas@kwiboo.se \
    --cc=boris.brezillon@collabora.com \
    --cc=ezequiel@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=paul.kocialkowski@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.