[PATCH] classes/npm: replace cache clear with cache clean --force

[PATCH] classes/npm: replace cache clear with cache clean --force

[mpvader]

npm now requires --force to clean the cache, see [1]. Also, use
clean instead of clear since the latter is an alias.

[1] https://github.com/npm/npm/commit/34f24c8381235790945208d25ac193bc97a21b79

Signed-off-by: mpvader <mvader@victronenergy.com>
---
 meta/classes/npm.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
index a69bedb..43aed36 100644
--- a/meta/classes/npm.bbclass
+++ b/meta/classes/npm.bbclass
@@ -31,7 +31,7 @@ npm_do_compile() {
 	fi
 	npm set cache ${WORKDIR}/npm_cache
 	# clear cache before every build
-	npm cache clear
+	npm cache clean --force
 	# Install pkg into ${S} without going to the registry
 	if [  "${NPM_INSTALL_DEV}" = "1" ]; then
 		npm --arch=${NPM_ARCH} --target_arch=${NPM_ARCH} --no-registry install
-- 
2.7.4

Re: [PATCH] classes/npm: replace cache clear with cache clean --force

[Böszörményi Zoltán]

I have already sent this patch (although a little extended) last week:
http://lists.openembedded.org/pipermail/openembedded-core/2018-February/147071.html

2018-02-04 23:23 keltezéssel, mpvader írta:
> npm now requires --force to clean the cache, see [1]. Also, use
> clean instead of clear since the latter is an alias.
> 
> [1] https://github.com/npm/npm/commit/34f24c8381235790945208d25ac193bc97a21b79
> 
> Signed-off-by: mpvader <mvader@victronenergy.com>
> ---
>   meta/classes/npm.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
> index a69bedb..43aed36 100644
> --- a/meta/classes/npm.bbclass
> +++ b/meta/classes/npm.bbclass
> @@ -31,7 +31,7 @@ npm_do_compile() {
>   	fi
>   	npm set cache ${WORKDIR}/npm_cache
>   	# clear cache before every build
> -	npm cache clear
> +	npm cache clean --force
>   	# Install pkg into ${S} without going to the registry
>   	if [  "${NPM_INSTALL_DEV}" = "1" ]; then
>   		npm --arch=${NPM_ARCH} --target_arch=${NPM_ARCH} --no-registry install
> 

Re: [PATCH] classes/npm: replace cache clear with cache clean --force

[Matthijs Vader]

Hi,

2018-02-05 15:07, zboszor wrote:
> I have already sent this patch (although a little extended) last week:
> http://lists.openembedded.org/pipermail/openembedded-core/2018-
> February/147071.html

Thanks! The second patch you sent in with that actually solved some other problems I was having as well. Still one left to fix:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=12534

See also the comment I added to that bugreport just now.

Best regards, Matthijs


> 2018-02-04 23:23 keltezéssel, mpvader írta:
> > npm now requires --force to clean the cache, see [1]. Also, use clean
> > instead of clear since the latter is an alias.
> >
> > [1]
> >
> https://github.com/npm/npm/commit/34f24c8381235790945208d25ac193bc
> 97a2
> > 1b79
> >
> > Signed-off-by: mpvader <mvader@victronenergy.com>
> > ---
> >   meta/classes/npm.bbclass | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass index
> > a69bedb..43aed36 100644
> > --- a/meta/classes/npm.bbclass
> > +++ b/meta/classes/npm.bbclass
> > @@ -31,7 +31,7 @@ npm_do_compile() {
> >   	fi
> >   	npm set cache ${WORKDIR}/npm_cache
> >   	# clear cache before every build
> > -	npm cache clear
> > +	npm cache clean --force
> >   	# Install pkg into ${S} without going to the registry
> >   	if [  "${NPM_INSTALL_DEV}" = "1" ]; then
> >   		npm --arch=${NPM_ARCH} --target_arch=${NPM_ARCH} --
> no-registry
> > install
> >

Re: [PATCH] classes/npm: replace cache clear with cache clean --force

[Böszörményi Zoltán]

2018-02-05 16:55 keltezéssel, Matthijs Vader írta:
> Hi,
> 
> 2018-02-05 15:07, zboszor wrote:
>> I have already sent this patch (although a little extended) last week:
>> http://lists.openembedded.org/pipermail/openembedded-core/2018-
>> February/147071.html
> 
> Thanks! The second patch you sent in with that actually solved some other problems I was having as well. Still one left to fix:
> 
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=12534
> 
> See also the comment I added to that bugreport just now.

Cool! Can we have a joint effort in the merged patches?

Also, can you please look into this fix I made against bitbake?
At least one node module (cli-color) has cyclic dependencies,
making the npm fetcher looping infinitely.
http://lists.openembedded.org/pipermail/bitbake-devel/2018-February/009199.html

> 
> Best regards, Matthijs
> 
> 
>> 2018-02-04 23:23 keltezéssel, mpvader írta:
>>> npm now requires --force to clean the cache, see [1]. Also, use clean
>>> instead of clear since the latter is an alias.
>>>
>>> [1]
>>>
>> https://github.com/npm/npm/commit/34f24c8381235790945208d25ac193bc
>> 97a2
>>> 1b79
>>>
>>> Signed-off-by: mpvader <mvader@victronenergy.com>
>>> ---
>>>    meta/classes/npm.bbclass | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass index
>>> a69bedb..43aed36 100644
>>> --- a/meta/classes/npm.bbclass
>>> +++ b/meta/classes/npm.bbclass
>>> @@ -31,7 +31,7 @@ npm_do_compile() {
>>>    	fi
>>>    	npm set cache ${WORKDIR}/npm_cache
>>>    	# clear cache before every build
>>> -	npm cache clear
>>> +	npm cache clean --force
>>>    	# Install pkg into ${S} without going to the registry
>>>    	if [  "${NPM_INSTALL_DEV}" = "1" ]; then
>>>    		npm --arch=${NPM_ARCH} --target_arch=${NPM_ARCH} --
>> no-registry
>>> install
>>>
> 
> 

Re: [PATCH] classes/npm: replace cache clear with cache clean --force

[Matthijs Vader]

Hi,

You wrote:

> 2018-02-05 16:55 keltezéssel, Matthijs Vader írta:
> > Hi,
> >
> > 2018-02-05 15:07, zboszor wrote:
> >> I have already sent this patch (although a little extended) last week:
> >> http://lists.openembedded.org/pipermail/openembedded-core/2018-
> >> February/147071.html
> >
> > Thanks! The second patch you sent in with that actually solved some other
> problems I was having as well. Still one left to fix:
> >
> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=12534
> >
> > See also the comment I added to that bugreport just now.
> 
> Cool! Can we have a joint effort in the merged patches?

Yes I will. I'll contact you off list.
 
> Also, can you please look into this fix I made against bitbake?
> At least one node module (cli-color) has cyclic dependencies, making the
> npm fetcher looping infinitely.
> http://lists.openembedded.org/pipermail/bitbake-devel/2018-
> February/009199.html

I'll look at that & test that.

> >
> > Best regards, Matthijs
> >
> >
> >> 2018-02-04 23:23 keltezéssel, mpvader írta:
> >>> npm now requires --force to clean the cache, see [1]. Also, use
> >>> clean instead of clear since the latter is an alias.
> >>>
> >>> [1]
> >>>
> >>
> https://github.com/npm/npm/commit/34f24c8381235790945208d25ac193bc
> >> 97a2
> >>> 1b79
> >>>
> >>> Signed-off-by: mpvader <mvader@victronenergy.com>
> >>> ---
> >>>    meta/classes/npm.bbclass | 2 +-
> >>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
> >>> index
> >>> a69bedb..43aed36 100644
> >>> --- a/meta/classes/npm.bbclass
> >>> +++ b/meta/classes/npm.bbclass
> >>> @@ -31,7 +31,7 @@ npm_do_compile() {
> >>>    	fi
> >>>    	npm set cache ${WORKDIR}/npm_cache
> >>>    	# clear cache before every build
> >>> -	npm cache clear
> >>> +	npm cache clean --force
> >>>    	# Install pkg into ${S} without going to the registry
> >>>    	if [  "${NPM_INSTALL_DEV}" = "1" ]; then
> >>>    		npm --arch=${NPM_ARCH} --target_arch=${NPM_ARCH} --
> >> no-registry
> >>> install
> >>>
> >
> >