From: Wen Yang <yellowriver2010@hotmail.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cocci@systeme.lip6.fr" <cocci@systeme.lip6.fr>,
Cheng Shengyu <cheng.shengyu@zte.com.cn>,
Wen Yang <wen.yang99@zte.com.cn>
Subject: [Cocci] 答复: [v6] coccinelle: semantic code search for missing put_device()
Date: Sun, 17 Feb 2019 02:32:38 +0000 [thread overview]
Message-ID: <HK0PR02MB3634E4B3441651D4F7737399B2620@HK0PR02MB3634.apcprd02.prod.outlook.com> (raw)
In-Reply-To: <52c3fdf6-0d04-eed5-da57-ef7d1008c291@web.de>
Hi Markus,
> > In a function, for a local variable obtained by of_find_device_by_node(),
>
> I got a software understanding where such a variable can not be obtained
> from this function call.
> The return value (like a pointer in this use case) can be stored there.
>
> > v6:
> > - to be double sure, replace &id->dev with (T)(&id->dev).
>
> The support for data type casts is another interesting extension for
> this source code analysis approach.
> Further adjustments might become possible at other places of the presented SmPL script
> after specific clarifications of previously mentioned implementation details.
First of all, thank you for your comments.
But please also refer to the examples of coccinelle, such as:
http://coccinelle.lip6.fr/rules/kmalloc.html
and
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/free/pci_free_consistent.cocci
You will find that there are differences between coccinelle and c.
Regards,
Wen
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-02-17 2:33 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 16:05 [Cocci] [PATCH v6] coccinelle: semantic code search for missing put_device() Wen Yang
2019-02-16 16:33 ` Julia Lawall
2019-02-16 16:33 ` [Cocci] " Julia Lawall
2019-02-16 18:39 ` [v6] " Markus Elfring
2019-02-16 18:39 ` [Cocci] " Markus Elfring
2019-02-16 18:39 ` Markus Elfring
2019-02-17 2:32 ` Wen Yang [this message]
2019-02-17 7:42 ` 答复: " Markus Elfring
2019-02-17 7:42 ` [Cocci] " Markus Elfring
2019-02-17 7:42 ` 答复: [v6] coccinelle: semantic code =?UTF-8?Q?_search_for_missing_p Markus Elfring
2019-02-17 9:50 ` [PATCH v6] coccinelle: semantic code search for missing put_device() Markus Elfring
2019-02-17 9:50 ` [Cocci] " Markus Elfring
2019-02-17 9:50 ` Markus Elfring
2019-02-17 11:37 ` Julia Lawall
2019-02-17 11:37 ` [Cocci] " Julia Lawall
2019-02-17 11:37 ` Julia Lawall
2019-02-17 11:42 ` Markus Elfring
2019-02-17 11:42 ` [Cocci] " Markus Elfring
2019-02-17 11:42 ` Markus Elfring
2019-02-17 11:48 ` Julia Lawall
2019-02-17 11:48 ` [Cocci] " Julia Lawall
2019-02-17 11:48 ` Julia Lawall
2019-02-17 12:00 ` [v6] " Markus Elfring
2019-02-17 12:00 ` [Cocci] " Markus Elfring
2019-02-17 12:00 ` Markus Elfring
2019-02-17 12:05 ` Julia Lawall
2019-02-17 12:05 ` [Cocci] " Julia Lawall
2019-02-17 12:05 ` Julia Lawall
2019-02-17 12:20 ` Markus Elfring
2019-02-17 12:20 ` [Cocci] " Markus Elfring
2019-02-17 12:20 ` Markus Elfring
2019-02-17 12:52 ` Julia Lawall
2019-02-17 12:52 ` [Cocci] " Julia Lawall
2019-02-17 12:52 ` Julia Lawall
2019-02-17 13:14 ` Markus Elfring
2019-02-17 13:14 ` [Cocci] " Markus Elfring
2019-02-17 13:14 ` Markus Elfring
2019-02-18 3:22 ` [Cocci] " wen.yang99
2019-02-18 6:43 ` Julia Lawall
2019-02-18 6:43 ` [Cocci] " Julia Lawall
2019-02-18 6:43 ` Julia Lawall
2019-02-18 8:19 ` Markus Elfring
2019-02-18 8:19 ` [Cocci] " Markus Elfring
2019-02-18 8:19 ` Markus Elfring
2019-02-19 2:14 ` [Cocci] " wen.yang99
2019-02-19 7:04 ` Julia Lawall
2019-02-19 7:04 ` [Cocci] " Julia Lawall
2019-02-19 7:04 ` Julia Lawall
2019-02-19 8:12 ` Markus Elfring
2019-02-19 8:12 ` [Cocci] " Markus Elfring
2019-02-19 8:12 ` Markus Elfring
2019-02-19 8:29 ` Markus Elfring
2019-02-19 8:29 ` [Cocci] " Markus Elfring
2019-02-19 8:29 ` Markus Elfring
2019-02-19 9:09 ` [Cocci] " wen.yang99
2019-02-19 9:30 ` Markus Elfring
2019-02-19 9:30 ` [Cocci] " Markus Elfring
2019-02-19 9:30 ` Markus Elfring
2019-03-06 11:18 ` Markus Elfring
2019-03-06 11:18 ` [Cocci] " Markus Elfring
2019-03-06 11:18 ` Markus Elfring
2019-02-18 21:40 ` Markus Elfring
2019-02-18 21:40 ` [Cocci] " Markus Elfring
2019-02-18 21:40 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK0PR02MB3634E4B3441651D4F7737399B2620@HK0PR02MB3634.apcprd02.prod.outlook.com \
--to=yellowriver2010@hotmail.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cheng.shengyu@zte.com.cn \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.